linux/drivers/usb
William Wu eda2124949 usb: dwc3: gadget: properly skip over trbs on ep_dequeue
There is a problem that incorrectly advances the TRB dequeue
pointer if more than one request in the started_list need to
be dequeue. If the request was already started, we issue the
END_TRANSFER command, then wait for END_TRANSFER completion
and only after that jump over the TRBs of the request by
clearing HWO and incrementing the TRB dequeue pointer. But we
don't skip over the TRBs of the rest started request, this
cause we to get incorrect TRB dequeue pointer on completion
next time.

We can easily reproduce this problem on RK3399 EVB Android Q
platform. Use MTP/PTP to transfer a big file, and then cancel
the transition, check if it can transfer again. If retransmission
fails, the problem happens. And if you enable the DWC3 trace
via tracing interface:

echo 1 > /sys/kernel/debug/tracing/events/dwc3/enable

You can get the error log:
irq/71-dwc3-1591  [000] d..1   389.337189: dwc3_complete_trb: ep1out: trb 00000000213b87d9 buf 00000000a84c0000 size 16384
irq/71-dwc3-1591  [000] d..1   389.337195: dwc3_gadget_giveback: ep1out: req 00000000d8c093a2 length 4294951424/512 zsI ==> 0
...
kworker/u12:2-111   [003] ....   389.337380: dwc3_free_request: ep1out: req 00000000d8c093a2 length 4294951424/512 zsI ==> 0

The req actual length is error. It's because that it get the
incorrect TRB dequeue pointer that belong to previous request.

Change-Id: I123ff779d5e2933449581f8b570e2e6ad6b75458
Signed-off-by: William Wu <william.wu@rock-chips.com>
2020-05-25 18:19:49 +08:00
..
atm Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
c67x00
chipidea Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
class Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
common usb: common: Consider only available nodes for dr_mode 2019-04-03 06:26:27 +02:00
core Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
dwc2 usb: dwc2: hcd: fix isoc out transfer with unaligned dma address 2020-04-26 22:04:39 +08:00
dwc3 usb: dwc3: gadget: properly skip over trbs on ep_dequeue 2020-05-25 18:19:49 +08:00
early
gadget usb: gadget: uvc: configfs: fix the desc of framebased format 2020-05-09 16:51:50 +08:00
host Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
image Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2019-10-28 20:26:28 +08:00
isp1760 BACKPORT: USB: add missing SPDX lines to Kconfig and Makefiles 2019-05-16 19:19:54 +08:00
misc Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
mon Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
mtu3 Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
musb Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
phy Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
renesas_usbhs usb: renesas_usbhs: add suspend event support in gadget mode 2019-12-31 16:34:54 +01:00
roles Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
serial Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
storage Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
typec Merge remote branch 'android-4.19' of https://android.googlesource.com/kernel/common 2020-03-21 19:46:46 +08:00
usbip Merge tag 'ASB-2020-02-05_4.19' of https://android.googlesource.com/kernel/common 2020-02-17 16:00:29 +08:00
wusbcore BACKPORT: USB: add missing SPDX lines to Kconfig and Makefiles 2019-05-16 19:19:54 +08:00
Kconfig BACKPORT: USB: add missing SPDX lines to Kconfig and Makefiles 2019-05-16 19:19:54 +08:00
Makefile
README
usb-skeleton.c USB: usb-skeleton: fix NULL-deref on disconnect 2019-10-17 13:44:50 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.