linux/drivers/media
Hans de Goede 0a77d44cc1 media: uvcvideo: Fix uvc_ctrl_fixup_xu_info() not having any effect
commit 93df48d37c upstream.

uvc_ctrl_add_info() calls uvc_ctrl_get_flags() which will override
the fixed-up flags set by uvc_ctrl_fixup_xu_info().

uvc_ctrl_init_xu_ctrl() already calls uvc_ctrl_get_flags() before
calling uvc_ctrl_add_info(), so the uvc_ctrl_get_flags() call in
uvc_ctrl_add_info() is not necessary for xu ctrls.

This commit moves the uvc_ctrl_get_flags() call for normal controls
from uvc_ctrl_add_info() to uvc_ctrl_init_ctrl(), so that we no longer
call uvc_ctrl_get_flags() twice for xu controls and so that we no longer
override the fixed-up flags set by uvc_ctrl_fixup_xu_info().

This fixes the xu motor controls not working properly on a Logitech
046d:08cc, and presumably also on the other Logitech models which have
a quirk for this in the uvc_ctrl_fixup_xu_info() function.

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-05 11:08:46 +01:00
..
cec cec-api: prevent leaking memory through hole in structure 2020-09-03 11:24:21 +02:00
common media: videobuf2-dma-sg: Prevent size from overflowing 2019-07-26 09:14:24 +02:00
dvb-core media: don't drop front-end reference count for ->detach 2019-10-05 13:10:05 +02:00
dvb-frontends media: tda10071: fix unsigned sign extension overflow 2020-10-01 13:14:37 +02:00
firewire media: firewire: fix memory leak 2020-10-30 10:38:26 +01:00
i2c media: imx274: fix frame interval handling 2020-11-05 11:08:40 +01:00
mmc
pci media: tw5864: check status of tw5864_frameinterval_get 2020-11-05 11:08:40 +01:00
platform media: platform: Improve queue set up flow for bug fixing 2020-11-05 11:08:40 +01:00
radio media: si470x-i2c: Move free() past last use of 'radio' 2020-02-05 14:43:40 +00:00
rc media: ati_remote: sanity check for both endpoints 2020-10-30 10:38:26 +01:00
spi media: cxd2880-spi: fix probe when dvb_attach fails 2019-12-13 08:52:23 +01:00
tuners media: tuner-simple: fix regression in simple_set_radio_freq 2020-10-29 09:55:01 +01:00
usb media: uvcvideo: Fix uvc_ctrl_fixup_xu_info() not having any effect 2020-11-05 11:08:46 +01:00
v4l2-core media: v4l2-mem2mem.c: fix broken links 2020-03-11 14:15:03 +01:00
Kconfig
Makefile
media-device.c media: mc-device.c: fix memleak in media_device_register_entity 2020-10-01 13:14:23 +02:00
media-devnode.c
media-entity.c