Eric Dumazet a06fa34d73 UPSTREAM: kcm: disable preemption in kcm_parse_func_strparser() ... After commit a2c11b0341 ("kcm: use BPF_PROG_RUN") syzbot easily triggers the warning in cant_sleep(). As explained in commit 6cab5e90ab ("bpf: run bpf programs with preemption disabled") we need to disable preemption before running bpf programs. BUG: assuming atomic context at net/kcm/kcmsock.c:382 in_atomic(): 0, irqs_disabled(): 0, pid: 7, name: kworker/u4:0 3 locks held by kworker/u4:0/7: #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: __write_once_size include/linux/compiler.h:226 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: atomic64_set include/asm-generic/atomic-instrumented.h:855 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: atomic_long_set include/asm-generic/atomic-long.h:40 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: set_work_data kernel/workqueue.c:620 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: set_work_pool_and_clear_pending kernel/workqueue.c:647 [inline] #0: ffff888216726128 ((wq_completion)kstrp){+.+.}, at: process_one_work+0x88b/0x1740 kernel/workqueue.c:2240 #1: ffff8880a989fdc0 ((work_completion)(&strp->work)){+.+.}, at: process_one_work+0x8c1/0x1740 kernel/workqueue.c:2244 #2: ffff888098998d10 (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1522 [inline] #2: ffff888098998d10 (sk_lock-AF_INET){+.+.}, at: strp_sock_lock+0x2e/0x40 net/strparser/strparser.c:440 CPU: 0 PID: 7 Comm: kworker/u4:0 Not tainted 5.3.0+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: kstrp strp_work Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 __cant_sleep kernel/sched/core.c:6826 [inline] __cant_sleep.cold+0xa4/0xbc kernel/sched/core.c:6803 kcm_parse_func_strparser+0x54/0x200 net/kcm/kcmsock.c:382 __strp_recv+0x5dc/0x1b20 net/strparser/strparser.c:221 strp_recv+0xcf/0x10b net/strparser/strparser.c:343 tcp_read_sock+0x285/0xa00 net/ipv4/tcp.c:1639 strp_read_sock+0x14d/0x200 net/strparser/strparser.c:366 do_strp_work net/strparser/strparser.c:414 [inline] strp_work+0xe3/0x130 net/strparser/strparser.c:423 process_one_work+0x9af/0x1740 kernel/workqueue.c:2269 Fixes: a2c11b0341 ("kcm: use BPF_PROG_RUN") Fixes: 6cab5e90ab ("bpf: run bpf programs with preemption disabled") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit 0355d6c1d5) Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> Change-Id: Ie65823d4101c1178182a1995f698cf3bfd2b2b70		2020-11-16 09:22:35 +01:00
..
6lowpan	6lowpan: Off by one handling ->nexthdr	2020-01-27 14:50:41 +01:00
9p	net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid	2020-11-05 11:08:44 +01:00
802
8021q	vlan: vlan_changelink() should propagate errors	2020-01-12 12:17:28 +01:00
appletalk	appletalk: Set error code if register_snap_client failed	2019-12-13 08:52:59 +01:00
atm	atm: fix a memory leak of vcc->user_back	2020-10-01 13:14:43 +02:00
ax25	AX.25: Prevent integer overflows in connect and sendmsg	2020-07-31 18:37:48 +02:00
batman-adv	batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh	2020-10-01 13:14:52 +02:00
bluetooth	Bluetooth: Only mark socket zapped after unlocking	2020-10-30 10:38:30 +01:00
bpf
bpfilter	signal/bpfilter: Fix bpfilter_kernl to use send_sig not force_sig	2020-01-27 14:50:51 +01:00
bridge	net: bridge: enfore alignment for ethernet address	2020-06-30 23:17:03 -04:00
caif	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
can	can: gw: Fix error path of cgw_module_init	2019-08-29 08:28:30 +02:00
ceph	libceph: clear con->out_msg on Policy::stateful_server faults	2020-11-05 11:08:53 +01:00
core	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
dcb	net: DCB: Validate DCB_ATTR_DCB_BUFFER argument	2020-09-26 18:01:29 +02:00
dccp	net: ipv6: add net argument to ip6_dst_lookup_flow	2020-04-29 16:31:16 +02:00
decnet	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:13:37 +01:00
dns_resolver	KEYS: Don't write out to userspace while holding key semaphore	2020-04-23 10:30:24 +02:00
dsa	net: dsa: read mac address from DT for slave device	2020-11-10 12:36:02 +01:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:19:09 +01:00
hsr	hsr: check protocol version in hsr_newlink()	2020-04-21 09:03:03 +02:00
ieee802154	nl802154: add missing attribute validation for dev_type	2020-03-18 07:14:15 +01:00
ife
ipv4	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
ipv6	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
iucv	net/af_iucv: always register net_device notifier	2020-01-27 14:50:56 +01:00
kcm	UPSTREAM: kcm: disable preemption in kcm_parse_func_strparser()	2020-11-16 09:22:35 +01:00
key	af_key: pfkey_dump needs parameter validation	2020-09-26 18:01:28 +02:00
l2tp	l2tp: remove skb_dst_set() from l2tp_xmit_skb()	2020-07-22 09:31:59 +02:00
l3mdev
lapb	lapb: fixed leak of control-blocks.	2019-06-22 08:15:13 +02:00
llc	net: silence data-races on sk_backlog.tail	2020-10-01 13:14:26 +02:00
mac80211	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
mac802154	mac802154: tx: fix use-after-free	2020-10-01 13:14:51 +02:00
mpls	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2020-04-29 16:31:17 +02:00
ncsi
netfilter	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
netlabel	netlabel: fix problems with mapping removal	2020-09-12 13:40:22 +02:00
netlink	Revert "genetlink: remove genl_bind"	2020-07-23 10:12:18 -07:00
netrom	net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node	2020-04-29 16:31:21 +02:00
nfc	nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()	2020-10-29 09:54:58 +01:00
nsh
openvswitch	openvswitch: handle DNAT tuple collision	2020-10-14 10:31:24 +02:00
packet	net/packet: fix overflow in tpacket_rcv	2020-10-07 08:00:08 +02:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
psample	net: psample: fix skb_over_panic	2019-12-05 09:21:30 +01:00
qrtr	net: qrtr: check skb_put_padto() return value	2020-09-26 18:01:30 +02:00
rds	rds: Prevent kernel-infoleak in rds_notify_queue_get()	2020-08-05 10:06:01 +02:00
rfkill	rfkill: Fix incorrect check to avoid NULL pointer dereference	2020-01-12 12:17:17 +01:00
rose
rxrpc	rxrpc: Fix server keyring leak	2020-10-14 10:31:26 +02:00
sched	netem: fix zero division in tabledist	2020-11-05 11:08:33 +01:00
sctp	sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms	2020-11-10 12:35:54 +01:00
smc	net/smc: fix valid DMBE buffer sizes	2020-10-29 09:54:55 +01:00
strparser
sunrpc	SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()	2020-10-30 10:38:23 +01:00
switchdev
tipc	tipc: fix use-after-free in tipc_bcast_get_mode	2020-11-10 12:35:53 +01:00
tls	net/tls: sendfile fails with ktls offload	2020-10-29 09:54:56 +01:00
unix	skbuff: fix a data race in skb_queue_len()	2020-10-01 13:14:32 +02:00
vmw_vsock	vsock: use ns_capable_noaudit() on socket create	2020-11-10 12:35:59 +01:00
wimax
wireless	UPSTREAM: cfg80211: validate SSID/MBSSID element ordering assumption	2020-11-16 09:22:34 +01:00
x25	net/x25: Fix null-ptr-deref in x25_disconnect	2020-08-05 10:06:02 +02:00
xdp	xdp: Fix xsk_generic_xmit errno	2020-06-25 15:33:05 +02:00
xfrm	ANDROID: Temporarily disable XFRM_USER_COMPAT filtering	2020-11-05 18:12:45 +00:00
compat.c	net/compat: Add missing sock updates for SCM_RIGHTS	2020-08-21 11:05:32 +02:00
Kconfig	BACKPORT: net: disable BRIDGE_NETFILTER by default	2020-02-28 10:42:51 -08:00
Makefile
socket.c	net: Set fput_needed iff FDPUT_FPUT is set	2020-08-19 08:15:03 +02:00
sysctl_net.c