Taehee Yoo 69b6b5ba33 UPSTREAM: virt_wifi: fix refcnt leak in module exit routine ... virt_wifi_newlink() calls netdev_upper_dev_link() and it internally holds reference count of lower interface. Current code does not release a reference count of the lower interface when the lower interface is being deleted. So, reference count leaks occur. Test commands: ip link add dummy0 type dummy ip link add vw1 link dummy0 type virt_wifi ip link del dummy0 Splat looks like: [ 133.787526][ T788] WARNING: CPU: 1 PID: 788 at net/core/dev.c:8274 rollback_registered_many+0x835/0xc80 [ 133.788355][ T788] Modules linked in: virt_wifi cfg80211 dummy team af_packet sch_fq_codel ip_tables x_tables unix [ 133.789377][ T788] CPU: 1 PID: 788 Comm: ip Not tainted 5.4.0-rc3+ #96 [ 133.790069][ T788] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 133.791167][ T788] RIP: 0010:rollback_registered_many+0x835/0xc80 [ 133.791906][ T788] Code: 00 4d 85 ff 0f 84 b5 fd ff ff ba c0 0c 00 00 48 89 de 4c 89 ff e8 9b 58 04 00 48 89 df e8 30 [ 133.794317][ T788] RSP: 0018:ffff88805ba3f338 EFLAGS: 00010202 [ 133.795080][ T788] RAX: ffff88805e57e801 RBX: ffff88805ba34000 RCX: ffffffffa9294723 [ 133.796045][ T788] RDX: 1ffff1100b746816 RSI: 0000000000000008 RDI: ffffffffabcc4240 [ 133.797006][ T788] RBP: ffff88805ba3f4c0 R08: fffffbfff5798849 R09: fffffbfff5798849 [ 133.797993][ T788] R10: 0000000000000001 R11: fffffbfff5798848 R12: dffffc0000000000 [ 133.802514][ T788] R13: ffff88805ba3f440 R14: ffff88805ba3f400 R15: ffff88805ed622c0 [ 133.803237][ T788] FS: 00007f2e9608c0c0(0000) GS:ffff88806cc00000(0000) knlGS:0000000000000000 [ 133.804002][ T788] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 133.804664][ T788] CR2: 00007f2e95610603 CR3: 000000005f68c004 CR4: 00000000000606e0 [ 133.805363][ T788] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 133.806073][ T788] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 133.806787][ T788] Call Trace: [ 133.807069][ T788] ? generic_xdp_install+0x310/0x310 [ 133.807612][ T788] ? lock_acquire+0x164/0x3b0 [ 133.808077][ T788] ? is_bpf_text_address+0x5/0xf0 [ 133.808640][ T788] ? deref_stack_reg+0x9c/0xd0 [ 133.809138][ T788] ? __nla_validate_parse+0x98/0x1ab0 [ 133.809944][ T788] unregister_netdevice_many.part.122+0x13/0x1b0 [ 133.810599][ T788] rtnl_delete_link+0xbc/0x100 [ 133.811073][ T788] ? rtnl_af_register+0xc0/0xc0 [ 133.811672][ T788] rtnl_dellink+0x30e/0x8a0 [ 133.812205][ T788] ? is_bpf_text_address+0x5/0xf0 [ ... ] [ 144.110530][ T788] unregister_netdevice: waiting for dummy0 to become free. Usage count = 1 This patch adds notifier routine to delete upper interface before deleting lower interface. Fixes: c7cdba31ed ("mac80211-next: rtnetlink wifi simulation device") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit 1962f86b42) Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> Change-Id: I6cd61c66c92363b7f59615ceb753b91bc3965287		2020-11-16 09:22:34 +01:00
..
accessibility
acpi	This is the 4.19.156 stable release	2020-11-10 13:23:09 +01:00
amba
android	UPSTREAM: binderfs: use refcount for binder control devices too	2020-11-16 07:43:08 +01:00
ata	ata: sata_nv: Fix retrieving of active qcs	2020-11-05 11:08:38 +01:00
atm	atm: eni: fix the missed pci_disable_device() for eni_init_one()	2020-10-01 13:14:51 +02:00
auxdisplay
base	UPSTREAM: PM: sleep: wakeup: Skip wakeup_source_sysfs_remove() if device is not there	2020-11-16 07:43:08 +01:00
bcma
block	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
bluetooth	Bluetooth: hci_uart: Cancel init work before unregistering	2020-10-29 09:55:05 +01:00
bus	bus/fsl_mc: Do not rely on caller to provide non NULL mc_io	2020-11-05 11:08:43 +01:00
cdrom
char	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
clk	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
clocksource	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
connector
cpufreq	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
cpuidle	This is the 4.19.144 stable release	2020-09-09 19:48:58 +02:00
crypto	This is the 4.19.156 stable release	2020-11-10 13:23:09 +01:00
dax
dca
devfreq	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
dio
dma	dmaengine: dma-jz4780: Fix race in jz4780_dma_tx_status	2020-11-05 11:08:50 +01:00
dma-buf	UPSTREAM: dma-buf: free dmabuf->name in dma_buf_release()	2020-11-15 15:40:31 +00:00
edac	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
eisa
energy_model
extcon	This is the 4.19.130 stable release	2020-06-27 09:50:13 +02:00
firewire
firmware	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
fmc
fpga	fpga: dfl: fix bug in port reset handshake	2020-07-29 10:16:48 +02:00
fsi
gnss	This is the 4.19.129 stable release	2020-06-22 10:50:54 +02:00
gpio	This is the 4.19.150 stable release	2020-10-07 08:45:35 +02:00
gpu	This is the 4.19.156 stable release	2020-11-10 13:23:09 +01:00
hid	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
hsi
hv	Drivers: hv: vmbus: Add timeout to vmbus_wait_for_unload	2020-09-23 12:10:59 +02:00
hwmon	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
hwspinlock
hwtracing	UPSTREAM: coresight: tmc: Fix bad register address for CLAIM	2020-11-15 15:06:03 +01:00
i2c	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
ide	ide: serverworks: potential overflow in svwks_set_pio_mode()	2020-02-24 08:34:49 +01:00
idle
iio	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
infiniband	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
input	UPSTREAM: Input: fix stale timestamp on key autorepeat events	2020-11-16 07:43:08 +01:00
iommu	This is the 4.19.150 stable release	2020-10-07 08:45:35 +02:00
ipack	ipack: tpci200: fix error return code in tpci200_register()	2020-05-27 17:37:43 +02:00
irqchip	This is the 4.19.143 stable release	2020-09-03 13:19:20 +02:00
isdn	PCI: add USR vendor id and use it in r8169 and w6692 driver	2020-06-22 09:05:23 +02:00
leds	leds: bcm6328, bcm6358: use devres LED registering function	2020-11-05 11:08:46 +01:00
lightnvm
macintosh	drivers/macintosh: Fix memleak in windfarm_pm112 driver	2020-06-22 09:05:29 +02:00
mailbox	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
mcb
md	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
media	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
memory	memory: emif: Remove bogus debugfs error handling	2020-11-05 11:08:45 +01:00
memstick
message	scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()	2020-11-05 11:08:47 +01:00
mfd	mfd: sm501: Fix leaks in probe()	2020-10-29 09:55:13 +01:00
misc	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
mmc	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
mtd	ubi: check kthread_should_stop() after the setting of task state	2020-11-05 11:08:52 +01:00
mux
net	UPSTREAM: virt_wifi: fix refcnt leak in module exit routine	2020-11-16 09:22:34 +01:00
nfc	NFC: st95hf: Fix memleak in st95hf_in_send_cmd	2020-09-17 13:45:24 +02:00
ntb	NTB: hw: amd: fix an issue about leak system resources	2020-10-30 10:38:25 +01:00
nubus
nvdimm	This is the 4.19.127 stable release	2020-06-07 14:25:43 +02:00
nvme	nvme-rdma: fix crash when connect rejected	2020-11-05 11:08:45 +01:00
nvmem	This is the 4.19.128 stable release	2020-06-11 09:16:29 +02:00
of	UPSTREAM: of/platform: Unconditionally pause/resume sync state during kernel init	2020-11-16 09:22:34 +01:00
opp
oprofile
parisc	parisc: mask out enable and reserved bits from sba imask	2020-08-19 08:15:07 +02:00
parport
pci	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
pcmcia
perf	drivers/perf: xgene_pmu: Fix uninitialized resource struct	2020-10-29 09:55:00 +01:00
phy	phy: samsung: s5pv210-usb2: Add delay after reset	2020-10-01 13:14:44 +02:00
pinctrl	pinctrl: mcp23s08: Fix mcp23x17 precious range	2020-10-29 09:55:10 +01:00
platform	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
pnp
power	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
powercap	powercap: restrict energy meter to root access	2020-11-10 21:11:27 +01:00
pps
ps3
ptp
pwm	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
rapidio	rapidio: fix the missed put_device() for rio_mport_add_riodev	2020-10-30 10:38:21 +01:00
ras
regulator	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
remoteproc	remoteproc: qcom: q6v5: Update running state before requesting stop	2020-08-21 11:05:34 +02:00
reset	reset: uniphier: Add SCSSI reset control for each channel	2020-02-24 08:34:44 +01:00
rpmsg	rpmsg: glink: Use complete_all for open states	2020-11-05 11:08:43 +01:00
rtc	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
s390	s390/zcrypt: Fix ZCRYPT_PERDEV_REQCNT ioctl	2020-10-01 13:14:54 +02:00
sbus
scsi	This is the 4.19.156 stable release	2020-11-10 13:23:09 +01:00
sfi
sh
siox
slimbus	slimbus: qcom-ngd-ctrl: disable ngd in qmi server down callback	2020-10-29 09:55:12 +01:00
sn
soc	This is the 4.19.140 stable release	2020-08-19 08:43:22 +02:00
soundwire
spi	This is the 4.19.153 stable release	2020-10-29 11:36:20 +01:00
spmi	Revert "ANDROID: GKI: spmi: pmic-arb: don't enable SPMI_MSM_PMIC_ARB by default"	2020-05-01 19:41:44 +00:00
ssb
staging	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
target	scsi: target: tcmu: Fix warning: 'page' may be used uninitialized	2020-10-29 09:55:14 +01:00
tc
tee
thermal	This is the 4.19.149 stable release	2020-10-01 16:49:05 +02:00
thunderbolt	thunderbolt: Drop duplicated get_switch_at_route()	2020-05-27 17:37:40 +02:00
tty	This is the 4.19.156 stable release	2020-11-10 13:23:09 +01:00
uio	uio: free uio id after uio file node is freed	2020-11-05 11:08:42 +01:00
usb	UPSTREAM: usb: typec: altmode: Fix typec_altmode_get_partner sometimes returning an invalid pointer	2020-11-16 07:43:08 +01:00
uwb
vfio	This is the 4.19.154 stable release	2020-10-30 11:43:26 +01:00
vhost	This is the 4.19.155 stable release	2020-11-05 14:02:27 +01:00
video	video: fbdev: pvr2fb: initialize variables	2020-11-05 11:08:39 +01:00
virt	drivers/virt/fsl_hypervisor: Fix error handling path	2020-10-29 09:55:09 +01:00
virtio	This is the 4.19.142 stable release	2020-08-26 11:07:03 +02:00
visorbus	visorbus: fix uninitialized variable access	2020-02-24 08:34:47 +01:00
vlynq
vme	vme: bridges: reduce stack usage	2020-02-24 08:34:47 +01:00
w1	w1: mxc_w1: Fix timeout resolution problem leading to bus error	2020-11-05 11:08:47 +01:00
watchdog	drivers: watchdog: rdc321x_wdt: Fix race condition bugs	2020-11-05 11:08:44 +01:00
xen	xen/events: block rogue events for some time	2020-11-05 11:08:37 +01:00
zorro
Kconfig	UPSTREAM: gpu/trace: add a gpu total memory usage tracepoint	2020-04-21 15:34:05 +00:00
Makefile