linux/fs/hfsplus
Ernesto A. Fernández 5f427ca479 hfsplus: prevent btree data loss on root split
[ Upstream commit 0a3021d4f5 ]

Creating, renaming or deleting a file may cause catalog corruption and
data loss.  This bug is randomly triggered by xfstests generic/027, but
here is a faster reproducer:

  truncate -s 50M fs.iso
  mkfs.hfsplus fs.iso
  mount fs.iso /mnt
  i=100
  while [ $i -le 150 ]; do
    touch /mnt/$i &>/dev/null
    ((++i))
  done
  i=100
  while [ $i -le 150 ]; do
    mv /mnt/$i /mnt/$(perl -e "print $i x82") &>/dev/null
    ((++i))
  done
  umount /mnt
  fsck.hfsplus -n fs.iso

The bug is triggered whenever hfs_brec_update_parent() needs to split the
root node.  The height of the btree is not increased, which leaves the new
node orphaned and its records lost.

Link: http://lkml.kernel.org/r/26d882184fc43043a810114258f45277752186c7.1535682461.git.ernesto.mnd.fernandez@gmail.com
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2018-11-27 16:08:00 +01:00
..
acl.h
attributes.c
bfind.c
bitmap.c
bnode.c
brec.c hfsplus: prevent btree data loss on root split 2018-11-27 16:08:00 +01:00
btree.c
catalog.c
dir.c hfsplus: fix NULL dereference in hfsplus_lookup() 2018-09-15 09:40:38 +02:00
extents.c
hfsplus_fs.h
hfsplus_raw.h
inode.c
ioctl.c
Kconfig
Makefile
options.c
part_tbl.c
posix_acl.c
super.c hfsplus: don't return 0 when fill_super() failed 2018-09-15 09:40:37 +02:00
tables.c
unicode.c
wrapper.c
xattr_security.c
xattr_trusted.c
xattr_user.c
xattr.c
xattr.h