linux/drivers/tty/vt
Gustavo A. R. Silva 1aa698b651 tty: vt_ioctl: fix potential Spectre v1
commit e97267cb4d upstream.

vsa.console is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

drivers/tty/vt/vt_ioctl.c:711 vt_ioctl() warn: potential spectre issue
'vc_cons' [r]

Fix this by sanitizing vsa.console before using it to index vc_cons

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-09-29 03:08:53 -07:00
..
.gitignore
consolemap.c tty: consolemap.c: move assignment out of if () block 2015-05-10 19:04:16 +02:00
cp437.uni
defkeymap.c_shipped
defkeymap.map
keyboard.c vt: fix Scroll Lock LED trigger name 2017-01-09 08:07:47 +01:00
Makefile tty: vt/Makefile: set the variables to static 2013-01-15 21:52:24 -08:00
selection.c tty: vt: Fix !TASK_RUNNING diagnostic warning from paste_selection() 2015-07-23 18:08:29 -07:00
vc_screen.c vc: switch to fixed_size_llseek() 2013-06-29 12:57:30 +04:00
vt_ioctl.c tty: vt_ioctl: fix potential Spectre v1 2018-09-29 03:08:53 -07:00
vt.c vt: change SGR 21 to follow the standards 2018-04-08 11:52:01 +02:00