Pavel Skripkin ab5bef9780 nilfs2: fix memory leak in nilfs_sysfs_delete_device_group ... [ Upstream commit 8fd0c1b064 ] My local syzbot instance hit memory leak in nilfs2. The problem was in missing kobject_put() in nilfs_sysfs_delete_device_group(). kobject_del() does not call kobject_cleanup() for passed kobject and it leads to leaking duped kobject name if kobject_put() was not called. Fail log: BUG: memory leak unreferenced object 0xffff8880596171e0 (size 8): comm "syz-executor379", pid 8381, jiffies 4294980258 (age 21.100s) hex dump (first 8 bytes): 6c 6f 6f 70 30 00 00 00 loop0... backtrace: kstrdup+0x36/0x70 mm/util.c:60 kstrdup_const+0x53/0x80 mm/util.c:83 kvasprintf_const+0x108/0x190 lib/kasprintf.c:48 kobject_set_name_vargs+0x56/0x150 lib/kobject.c:289 kobject_add_varg lib/kobject.c:384 [inline] kobject_init_and_add+0xc9/0x160 lib/kobject.c:473 nilfs_sysfs_create_device_group+0x150/0x800 fs/nilfs2/sysfs.c:999 init_nilfs+0xe26/0x12b0 fs/nilfs2/the_nilfs.c:637 Link: https://lkml.kernel.org/r/20210612140559.20022-1-paskripkin@gmail.com Fixes: da7141fb78 ("nilfs2: add /sys/fs/nilfs2/<device> group") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Cc: Michael L. Semon <mlsemon35@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-06-30 08:47:24 -04:00
..
alloc.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
alloc.h
bmap.c	nilfs2: fix some kernel-doc warnings for nilfs2	2020-10-16 11:11:22 -07:00
bmap.h
btnode.c
btnode.h
btree.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
btree.h
cpfile.c	nilfs2: fix some kernel-doc warnings for nilfs2	2020-10-16 11:11:22 -07:00
cpfile.h
dat.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
dat.h
dir.c
direct.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
direct.h
export.h
file.c	nilfs2: make splice write available again	2021-02-13 13:55:16 +01:00
gcinode.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
ifile.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
ifile.h
inode.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
ioctl.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
Kconfig
Makefile
mdt.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
mdt.h
namei.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
nilfs.h	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
page.c	nilfs2: fix some kernel-doc warnings for nilfs2	2020-10-16 11:11:22 -07:00
page.h
recovery.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
segbuf.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
segbuf.h
segment.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
segment.h
sufile.c	nilfs2: fix some kernel-doc warnings for nilfs2	2020-10-16 11:11:22 -07:00
sufile.h
super.c	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
sysfs.c	nilfs2: fix memory leak in nilfs_sysfs_delete_device_group	2021-06-30 08:47:24 -04:00
sysfs.h
the_nilfs.c	nilfs2: use a more common logging style	2020-08-12 10:58:01 -07:00
the_nilfs.h