Marc Zyngier ce744a898e phy: tegra: xusb: Fix dangling pointer on probe failure ... [ Upstream commit eb9c4dd9bd ] If, for some reason, the xusb PHY fails to probe, it leaves a dangling pointer attached to the platform device structure. This would normally be harmless, but the Tegra XHCI driver then goes and extract that pointer from the PHY device. Things go downhill from there: 8.752082] [004d554e5145533c] address between user and kernel address ranges [ 8.752085] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 8.752088] Modules linked in: max77620_regulator(E+) xhci_tegra(E+) sdhci_tegra(E+) xhci_hcd(E) sdhci_pltfm(E) cqhci(E) fixed(E) usbcore(E) scsi_mod(E) sdhci(E) host1x(E+) [ 8.752103] CPU: 4 PID: 158 Comm: systemd-udevd Tainted: G S W E 5.9.0-rc7-00298-gf6337624c4fe #1980 [ 8.752105] Hardware name: NVIDIA Jetson TX2 Developer Kit (DT) [ 8.752108] pstate: 20000005 (nzCv daif -PAN -UAO BTYPE=--) [ 8.752115] pc : kobject_put+0x1c/0x21c [ 8.752120] lr : put_device+0x20/0x30 [ 8.752121] sp : ffffffc012eb3840 [ 8.752122] x29: ffffffc012eb3840 x28: ffffffc010e82638 [ 8.752125] x27: ffffffc008d56440 x26: 0000000000000000 [ 8.752128] x25: ffffff81eb508200 x24: 0000000000000000 [ 8.752130] x23: ffffff81eb538800 x22: 0000000000000000 [ 8.752132] x21: 00000000fffffdfb x20: ffffff81eb538810 [ 8.752134] x19: 3d4d554e51455300 x18: 0000000000000020 [ 8.752136] x17: ffffffc008d00270 x16: ffffffc008d00c94 [ 8.752138] x15: 0000000000000004 x14: ffffff81ebd4ae90 [ 8.752140] x13: 0000000000000000 x12: ffffff81eb86a4e8 [ 8.752142] x11: ffffff81eb86a480 x10: ffffff81eb862fea [ 8.752144] x9 : ffffffc01055fb28 x8 : ffffff81eb86a4a8 [ 8.752146] x7 : 0000000000000001 x6 : 0000000000000001 [ 8.752148] x5 : ffffff81dff8bc38 x4 : 0000000000000000 [ 8.752150] x3 : 0000000000000001 x2 : 0000000000000001 [ 8.752152] x1 : 0000000000000002 x0 : 3d4d554e51455300 [ 8.752155] Call trace: [ 8.752157] kobject_put+0x1c/0x21c [ 8.752160] put_device+0x20/0x30 [ 8.752164] tegra_xusb_padctl_put+0x24/0x3c [ 8.752170] tegra_xusb_probe+0x8b0/0xd10 [xhci_tegra] [ 8.752174] platform_drv_probe+0x60/0xb4 [ 8.752176] really_probe+0xf0/0x504 [ 8.752179] driver_probe_device+0x100/0x170 [ 8.752181] device_driver_attach+0xcc/0xd4 [ 8.752183] __driver_attach+0xb0/0x17c [ 8.752185] bus_for_each_dev+0x7c/0xd4 [ 8.752187] driver_attach+0x30/0x3c [ 8.752189] bus_add_driver+0x154/0x250 [ 8.752191] driver_register+0x84/0x140 [ 8.752193] __platform_driver_register+0x54/0x60 [ 8.752197] tegra_xusb_init+0x40/0x1000 [xhci_tegra] [ 8.752201] do_one_initcall+0x54/0x2d0 [ 8.752205] do_init_module+0x68/0x29c [ 8.752207] load_module+0x2178/0x26c0 [ 8.752209] __do_sys_finit_module+0xb0/0x120 [ 8.752211] __arm64_sys_finit_module+0x2c/0x40 [ 8.752215] el0_svc_common.constprop.0+0x80/0x240 [ 8.752218] do_el0_svc+0x30/0xa0 [ 8.752220] el0_svc+0x18/0x50 [ 8.752223] el0_sync_handler+0x90/0x318 [ 8.752225] el0_sync+0x158/0x180 [ 8.752230] Code: a9bd7bfd 910003fd a90153f3 aa0003f3 (3940f000) [ 8.752232] ---[ end trace 90f6c89d62d85ff5 ]--- Reset the pointer on probe failure fixes the issue. Fixes: 53d2a715c2 ("phy: Add Tegra XUSB pad controller support") Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20201013095820.311376-1-maz@kernel.org Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-12-02 08:48:10 +01:00
..
allwinner	phy: sun4i-usb: fix dereference of pointer phy0 before it is null checked	2020-07-22 09:32:05 +02:00
amlogic	phy: amlogic: add USB3 PHY support for Meson GXL and GXM	2018-03-16 13:40:44 +05:30
broadcom	phy: usb: phy-brcm-usb: Remove sysfs attributes upon driver removal	2020-01-27 14:50:54 +01:00
hisilicon	phy: add inno-usb2-phy driver for hi3798cv200 SoC	2018-03-16 16:55:29 +05:30
lantiq	phy: lantiq: Fix compile warning	2019-11-20 18:47:35 +01:00
marvell	phy: mvebu-cp110-comphy: switch to SPDX identifier	2018-07-24 11:12:15 +05:30
mediatek	phy: phy-mtk-tphy: add property for BC12	2018-07-10 13:45:08 +05:30
motorola	phy: mapphone-mdm6600: Fix write timeouts with shorter GPIO toggle interval	2020-03-11 14:15:10 +01:00
qualcomm	phy: qcom-qmp: Use correct values for ipq8074 PCIe Gen2 PHY init	2020-09-17 13:45:30 +02:00
ralink	phy: add 'depends on HAS_IOMEM' to fix unmet dependency	2018-03-16 13:40:45 +05:30
renesas	phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"	2019-12-17 20:34:45 +01:00
rockchip	phy: rockchip-typec: fall back to working in host-mode if extcon is missing.	2018-03-16 16:55:37 +05:30
samsung	phy: samsung: s5pv210-usb2: Add delay after reset	2020-10-01 13:14:44 +02:00
st	phy: stm32: fix usbphyc static checker and checkpatch warnings	2018-05-20 21:51:25 +05:30
tegra	phy: tegra: xusb: Fix dangling pointer on probe failure	2020-12-02 08:48:10 +01:00
ti	phy: phy-twl4030-usb: fix denied runtime access	2019-11-20 18:47:24 +01:00
Kconfig	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
phy-core.c	phy: core: Allow phy_pm_runtime_xxx API calls with NULL phy	2018-04-25 10:52:59 +05:30
phy-lpc18xx-usb-otg.c	phy: lpc18xx-usb-otg: error handling in lpc18xx_usb_otg_phy_power_on()	2018-03-16 13:40:42 +05:30
phy-pistachio-usb.c
phy-xgene.c