Leon Romanovsky 4a754d7637 RDMA/mlx5: Don't access NULL-cleared mpi pointer ... The "dev->port[i].mp.mpi" is set to NULL during mlx5_ib_unbind_slave_port() execution, however that field is needed to add device to unaffiliated list. Such flow causes to the following kernel panic while unloading mlx5_ib module in multi-port mode, hence the device should be added to the list prior to unbind call. RPC: Unregistered rdma transport module. RPC: Unregistered rdma backchannel transport module. BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor write access in kernel mode #PF: error_code(0x0002) - not-present page PGD 0 P4D 0 Oops: 0002 [#1] SMP NOPTI CPU: 4 PID: 1904 Comm: modprobe Not tainted 5.13.0-rc7_for_upstream_min_debug_2021_06_24_12_08 #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 RIP: 0010:mlx5_ib_cleanup_multiport_master+0x18b/0x2d0 [mlx5_ib] Code: 00 04 0f 85 c4 00 00 00 48 89 df e8 ef fa ff ff 48 8b 83 40 0d 00 00 48 8b 15 b9 e8 05 00 4a 8b 44 28 20 48 89 05 ad e8 05 00 <48> c7 00 d0 57 c5 a0 48 89 50 08 48 89 02 39 ab 88 0a 00 00 0f 86 RSP: 0018:ffff888116ee3df8 EFLAGS: 00010296 RAX: 0000000000000000 RBX: ffff8881154f6000 RCX: 0000000000000080 RDX: ffffffffa0c557d0 RSI: ffff88810b69d200 RDI: 000000000002d8a0 RBP: 0000000000000002 R08: ffff888110780408 R09: 0000000000000000 R10: ffff88812452e1c0 R11: fffffffffff7e028 R12: 0000000000000000 R13: 0000000000000080 R14: ffff888102c58000 R15: 0000000000000000 FS: 00007f884393a740(0000) GS:ffff8882f5a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 00000001249f6004 CR4: 0000000000370ea0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: mlx5_ib_stage_init_cleanup+0x16/0xd0 [mlx5_ib] __mlx5_ib_remove+0x33/0x90 [mlx5_ib] mlx5r_remove+0x22/0x30 [mlx5_ib] auxiliary_bus_remove+0x18/0x30 __device_release_driver+0x177/0x220 driver_detach+0xc4/0x100 bus_remove_driver+0x58/0xd0 auxiliary_driver_unregister+0x12/0x20 mlx5_ib_cleanup+0x13/0x897 [mlx5_ib] __x64_sys_delete_module+0x154/0x230 ? exit_to_user_mode_prepare+0x104/0x140 do_syscall_64+0x3f/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f8842e095c7 Code: 73 01 c3 48 8b 0d d9 48 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 48 2c 00 f7 d8 64 89 01 48 RSP: 002b:00007ffc68f6e758 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0 RAX: ffffffffffffffda RBX: 00005638207929c0 RCX: 00007f8842e095c7 RDX: 0000000000000000 RSI: 0000000000000800 RDI: 0000563820792a28 RBP: 00005638207929c0 R08: 00007ffc68f6d701 R09: 0000000000000000 R10: 00007f8842e82880 R11: 0000000000000206 R12: 0000563820792a28 R13: 0000000000000001 R14: 0000563820792a28 R15: 00007ffc68f6fb40 Modules linked in: xt_MASQUERADE nf_conntrack_netlink nfnetlink iptable_nat xt_addrtype xt_conntrack nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 br_netfilter overlay rdma_ucm ib_iser libiscsi scsi_transport_iscsi rdma_cm iw_cm ib_ipoib ib_cm ib_umad mlx5_ib(-) mlx4_ib ib_uverbs ib_core mlx4_en mlx4_core mlx5_core ptp pps_core [last unloaded: rpcrdma] CR2: 0000000000000000 ---[ end trace a0bb7e20804e9e9b ]--- Fixes: 7ce6095e3b ("RDMA/mlx5: Don't add slave port to unaffiliated list") Link: https://lore.kernel.org/r/899ac1b33a995be5ec0e16a4765c4e43c2b1ba5b.1624956444.git.leonro@nvidia.com Reviewed-by: Itay Aveksis <itayav@nvidia.com> Reviewed-by: Maor Gottlieb <maorg@nvidia.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>		2021-06-29 19:57:02 -03:00
..
accessibility	TTY/Serial driver updates for 5.13-rc1	2021-04-26 11:20:10 -07:00
acpi	Merge branch 'acpi-bus'	2021-06-11 17:57:24 +02:00
amba
android	binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION	2021-05-13 20:35:26 +02:00
ata	pci-v5.13-changes	2021-05-05 13:24:11 -07:00
atm	atm: firestream: Use fallthrough pseudo-keyword	2021-05-07 16:01:08 -07:00
auxdisplay	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
base	drivers/base/memory: fix trying offlining memory blocks with memory holes on aarch64	2021-06-05 08:58:11 -07:00
bcma	bcma: remove unused function	2021-04-18 09:36:56 +03:00
block	Linux 5.13-rc7	2021-06-22 14:43:51 -03:00
bluetooth	Networking fixes for 5.13-rc5, including fixes from bpf, wireless,	2021-06-04 18:25:39 -07:00
bus	Char/Misc driver fixes for 5.13-rc6	2021-06-12 12:13:55 -07:00
cdrom	cdrom: gdrom: initialize global variable at init time	2021-05-13 18:58:44 +02:00
char	Char/misc driver fixes for 5.13-rc3	2021-05-20 06:31:52 -10:00
clk	clk: Skip clk provider registration when np is NULL	2021-05-11 08:47:25 +02:00
clocksource	clocksource/drivers/hyper-v: Re-enable VDSO_CLOCKMODE_HVCLOCK on X86	2021-05-14 14:55:13 +02:00
comedi	staging: comedi: move out of staging directory	2021-04-15 09:26:25 +02:00
connector
counter
cpufreq	Revert "cpufreq: CPPC: Add support for frequency invariance"	2021-06-14 15:55:02 +02:00
cpuidle	Merge back earlier cpuidle updates for v5.13.	2021-04-08 20:05:49 +02:00
crypto	Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions"	2021-05-13 17:23:05 +02:00
cxl	cxl/mem: Fix memory device capacity probing	2021-04-16 18:21:56 -07:00
dax
dca
devfreq	PM / devfreq: imx8m-ddrc: Remove unneeded of_match_ptr()	2021-04-08 13:14:51 +09:00
dio
dma	dmaengine fixes for v5.13	2021-06-16 09:03:52 -07:00
dma-buf	dma-buf: fix unintended pin/unpin warnings	2021-05-20 14:02:27 +02:00
edac	x86/msr: Rename MSR_K8_SYSCFG to MSR_AMD64_SYSCFG	2021-05-10 07:51:38 +02:00
eisa
extcon	- Core Frameworks	2021-04-28 15:59:13 -07:00
firewire	The usual updates from the irq departement:	2021-04-26 09:43:16 -07:00
firmware	EFI fixes for v5.13-rc	2021-05-23 11:39:02 +02:00
fpga	ARM: SoC drivers for v5.13	2021-04-26 12:11:52 -07:00
fsi
gnss
gpio	gpio: wcd934x: Fix shift-out-of-bounds error	2021-05-27 09:51:35 +02:00
gpu	drm/amdgpu/gfx10: enlarge CP_MEC_DOORBELL_RANGE_UPPER to cover full doorbell.	2021-06-16 16:04:20 -04:00
greybus	greybus: es2: fix kernel-doc warnings	2021-04-16 07:26:50 +02:00
hid	HID: asus: Cleanup Asus T101HA keyboard-dock handling	2021-05-27 15:40:35 +02:00
hsi	HSI: core: fix resource leaks in hsi_add_client_from_dt()	2021-04-16 00:14:49 +02:00
hv	printk changes for 5.13	2021-04-27 18:09:44 -07:00
hwmon	hwmon: (tps23861) correct shunt LSB values	2021-06-10 08:40:09 -07:00
hwspinlock
hwtracing	ARM:	2021-05-01 10:14:08 -07:00
i2c	i2c: qcom-geni: Suspend and resume the bus during SYSTEM_SLEEP_PM ops	2021-06-04 22:32:58 +02:00
i3c	Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"	2021-04-24 22:21:01 +02:00
ide
idle	intel_idle: add Iclelake-D support	2021-04-08 19:18:07 +02:00
iio	iio: adc: ad7793: Add missing error code in ad7793_setup()	2021-05-22 08:32:36 +01:00
infiniband	RDMA/mlx5: Don't access NULL-cleared mpi pointer	2021-06-29 19:57:02 -03:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2021-05-06 23:37:55 -07:00
interconnect	interconnect: qcom: Add missing MODULE_DEVICE_TABLE	2021-05-11 07:26:31 +03:00
iommu	iommu/vt-d: Fix sysfs leak in alloc_iommu()	2021-05-27 16:07:08 +02:00
ipack
irqchip	irqchip fixes for 5.13, take #2	2021-06-17 15:22:31 +02:00
isdn	Networking fixes for 5.13-rc4, including fixes from bpf, netfilter,	2021-05-26 17:44:49 -10:00
leds	leds: lp5523: check return value of lp5xx_read and jump to cleanup code	2021-05-13 17:30:15 +02:00
lightnvm	lightnvm: deprecated OCSSD support and schedule it for removal in Linux 5.15	2021-04-13 09:16:12 -06:00
macintosh	macintosh/via-pmu: Fix build warning	2021-04-16 23:57:51 +10:00
mailbox	- qcom: enable support for SM8350 and SC7280	2021-04-28 16:10:33 -07:00
mcb
md	block-5.13-2021-06-12	2021-06-12 11:59:58 -07:00
media	media: gspca: properly check for errors in po1030_probe()	2021-05-13 18:58:32 +02:00
memory	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
memstick	memstick: r592: ignore kfifo_out() return code again	2021-04-26 11:08:23 +02:00
message	scsi: message: fusion: Remove unused local variable 'vtarget'	2021-04-13 01:39:12 -04:00
mfd	- Core Frameworks	2021-04-28 15:59:13 -07:00
misc	misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG	2021-06-09 19:10:22 +02:00
mmc	mmc: renesas_sdhi: Fix HS400 on R-Car M3-W+	2021-06-08 14:56:54 +02:00
most	Staging/IIO driver updates for 5.13-rc1	2021-04-26 11:14:21 -07:00
mtd	mtd: parsers: ofpart: fix parsing subpartitions	2021-05-10 18:34:30 +02:00
mux
net	Merge branch 'mlx5_realtime_ts' into rdma.git for-next	2021-06-22 15:08:39 -03:00
nfc	NFC: nfcmrvl: fix kernel-doc syntax in file headers	2021-05-23 17:26:38 -07:00
ntb
nubus
nvdimm	include: remove pagemap.h from blkdev.h	2021-05-06 19:24:11 -07:00
nvme	nvmet: fix freeing unallocated p2pmem	2021-06-02 10:10:38 +03:00
nvmem
of	of: overlay: Remove redundant assignment to ret	2021-05-03 13:57:56 -05:00
opp
parisc
parport	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
pci	pci-v5.13-fixes-2	2021-06-18 13:54:11 -07:00
pcmcia
perf	ARM:	2021-05-01 10:14:08 -07:00
phy	phy: Sparx5 Eth SerDes: check return value after calling platform_get_resource()	2021-06-03 11:18:19 +05:30
pinctrl	pinctrl: qcom: Make it possible to select SC8180x TLMM	2021-06-09 13:15:20 +02:00
platform	platform/mellanox: mlxreg-hotplug: Revert "move to use request_irq by IRQF_NO_AUTOEN flag"	2021-06-04 22:03:13 +02:00
pnp
power	power supply and reset changes for the v5.13 series	2021-04-28 15:43:58 -07:00
powercap
pps	TTY/Serial driver updates for 5.13-rc1	2021-04-26 11:20:10 -07:00
ps3
ptp	ptp: improve max_adj check against unreasonable values	2021-06-15 10:59:46 -07:00
pwm	pwm: Changes for v5.13-rc1	2021-05-05 12:53:16 -07:00
rapidio	rapidio: handle create_workqueue() failure	2021-05-13 18:32:19 +02:00
ras	RAS/CEC: Correct ce_add_elem()'s returned values	2021-04-07 11:52:26 +02:00
regulator	regulator: Fixes for v5.14	2021-06-08 09:41:16 -07:00
remoteproc	remoteproc updates for v5.13	2021-05-04 11:13:33 -07:00
reset	pci-v5.13-changes	2021-05-05 13:24:11 -07:00
rpmsg	rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()	2021-04-09 11:08:42 -05:00
rtc	RTC for 5.13	2021-05-03 12:15:21 -07:00
s390	s390/ap: Fix hanging ioctl caused by wrong msg counter	2021-06-16 23:32:02 +02:00
sbus
scsi	SCSI fixes on 20210613	2021-06-13 12:25:33 -07:00
sh	The usual updates from the irq departement:	2021-04-26 09:43:16 -07:00
siox
slimbus
soc	soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe()	2021-05-31 09:26:58 +02:00
soundwire	soundwire: qcom: fix handling of qcom,ports-block-pack-mode	2021-05-13 11:14:13 +05:30
spi	spi: stm32-qspi: Always wait BUSY bit to be cleared in stm32_qspi_wait_cmd()	2021-06-03 13:55:36 +01:00
spmi
ssb
staging	Networking fixes for 5.13-rc7, including fixes from wireless, bpf,	2021-06-18 18:55:29 -07:00
target	scsi: target: core: Fix warning on realtime kernels	2021-05-31 22:59:13 -04:00
tc
tee	OP-TEE use export_uuid() to copy UUID	2021-06-05 15:43:11 -07:00
thermal	- Fix out-of-spec hardware (1st gen Hygon) which does not implement	2021-06-06 12:25:43 -07:00
thunderbolt	thunderbolt: usb4: Fix NVM read buffer bounds and offset issue	2021-05-20 11:52:58 +03:00
tty	serial: 8250_exar: Avoid NULL pointer dereference at ->exit()	2021-06-09 14:40:48 +02:00
uio	uio_hv_generic: Fix another memory leak in error handling paths	2021-05-14 13:26:04 +02:00
usb	usb: core: hub: Disable autosuspend for Cypress CY7C65632	2021-06-17 15:34:21 +02:00
vdpa	{net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table	2021-05-18 23:01:48 -07:00
vfio	vfio/platform: fix module_put call in error flow	2021-05-24 13:40:13 -06:00
vhost	virtio,vhost,vdpa: features, fixes	2021-05-05 13:31:39 -07:00
video	Revert "fb_defio: Remove custom address_space_operations"	2021-06-01 17:38:40 +02:00
virt	nitro_enclaves: Fix stale file descriptors on failed usercopy	2021-04-29 19:06:49 +02:00
virtio	virtio_pci_modern: correct sparse tags for notify	2021-05-04 04:19:59 -04:00
visorbus
vlynq
vme
w1	w1: ds28e17: Use module_w1_family to simplify the code	2021-04-10 10:58:21 +02:00
watchdog	- Core Frameworks	2021-04-28 15:59:13 -07:00
xen	xen-pciback: reconfigure also from backend watch handler	2021-05-21 09:55:16 +02:00
zorro
Kconfig	staging: comedi: move out of staging directory	2021-04-15 09:26:25 +02:00
Makefile	virtio,vhost,vdpa: features, fixes	2021-05-05 13:31:39 -07:00