linux/scripts/mod
Masahiro Yamada 8287687821 modpost: fix undefined behavior of is_arm_mapping_symbol()
[ Upstream commit d6b732666a ]

The return value of is_arm_mapping_symbol() is unpredictable when "$"
is passed in.

strchr(3) says:
  The strchr() and strrchr() functions return a pointer to the matched
  character or NULL if the character is not found. The terminating null
  byte is considered part of the string, so that if c is specified as
  '\0', these functions return a pointer to the terminator.

When str[1] is '\0', strchr("axtd", str[1]) is not NULL, and str[2] is
referenced (i.e. buffer overrun).

Test code
---------

  char str1[] = "abc";
  char str2[] = "ab";

  strcpy(str1, "$");
  strcpy(str2, "$");

  printf("test1: %d\n", is_arm_mapping_symbol(str1));
  printf("test2: %d\n", is_arm_mapping_symbol(str2));

Result
------

  test1: 0
  test2: 1

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-14 18:32:44 +02:00
..
.gitignore .gitignore: add SPDX License Identifier 2020-03-25 11:50:48 +01:00
devicetable-offsets.c soundwire: extend SDW_SLAVE_ENTRY 2020-06-30 21:26:17 +05:30
empty.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
file2alias.c soundwire: extend SDW_SLAVE_ENTRY 2020-06-30 21:26:17 +05:30
Makefile kbuild: introduce hostprogs-always-y and userprogs-always-y 2020-08-10 01:32:59 +09:00
mk_elfconfig.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
modpost.c modpost: fix undefined behavior of is_arm_mapping_symbol() 2022-06-14 18:32:44 +02:00
modpost.h modpost: change elf_info->size to size_t 2020-06-06 23:39:20 +09:00
sumversion.c modpost: use read_text_file() and get_line() for reading text files 2020-06-06 23:38:13 +09:00