Julian Anastasov 57de3c78f0 ipvs: defer hook registration to avoid leaks ... [ Upstream commit cf47a0b882 ] syzkaller reports for memory leak when registering hooks [1] As we moved the nf_unregister_net_hooks() call into __ip_vs_dev_cleanup(), defer the nf_register_net_hooks() call, so that hooks are allocated and freed from same pernet_operations (ipvs_core_dev_ops). [1] BUG: memory leak unreferenced object 0xffff88810acd8a80 (size 96): comm "syz-executor073", pid 7254, jiffies 4294950560 (age 22.250s) hex dump (first 32 bytes): 02 00 00 00 00 00 00 00 50 8b bb 82 ff ff ff ff ........P....... 00 00 00 00 00 00 00 00 00 77 bb 82 ff ff ff ff .........w...... backtrace: [<0000000013db61f1>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<0000000013db61f1>] slab_post_alloc_hook mm/slab.h:439 [inline] [<0000000013db61f1>] slab_alloc_node mm/slab.c:3269 [inline] [<0000000013db61f1>] kmem_cache_alloc_node_trace+0x15b/0x2a0 mm/slab.c:3597 [<000000001a27307d>] __do_kmalloc_node mm/slab.c:3619 [inline] [<000000001a27307d>] __kmalloc_node+0x38/0x50 mm/slab.c:3627 [<0000000025054add>] kmalloc_node include/linux/slab.h:590 [inline] [<0000000025054add>] kvmalloc_node+0x4a/0xd0 mm/util.c:431 [<0000000050d1bc00>] kvmalloc include/linux/mm.h:637 [inline] [<0000000050d1bc00>] kvzalloc include/linux/mm.h:645 [inline] [<0000000050d1bc00>] allocate_hook_entries_size+0x3b/0x60 net/netfilter/core.c:61 [<00000000e8abe142>] nf_hook_entries_grow+0xae/0x270 net/netfilter/core.c:128 [<000000004b94797c>] __nf_register_net_hook+0x9a/0x170 net/netfilter/core.c:337 [<00000000d1545cbc>] nf_register_net_hook+0x34/0xc0 net/netfilter/core.c:464 [<00000000876c9b55>] nf_register_net_hooks+0x53/0xc0 net/netfilter/core.c:480 [<000000002ea868e0>] __ip_vs_init+0xe8/0x170 net/netfilter/ipvs/ip_vs_core.c:2280 [<000000002eb2d451>] ops_init+0x4c/0x140 net/core/net_namespace.c:130 [<000000000284ec48>] setup_net+0xde/0x230 net/core/net_namespace.c:316 [<00000000a70600fa>] copy_net_ns+0xf0/0x1e0 net/core/net_namespace.c:439 [<00000000ff26c15e>] create_new_namespaces+0x141/0x2a0 kernel/nsproxy.c:107 [<00000000b103dc79>] copy_namespaces+0xa1/0xe0 kernel/nsproxy.c:165 [<000000007cc008a2>] copy_process.part.0+0x11fd/0x2150 kernel/fork.c:2035 [<00000000c344af7c>] copy_process kernel/fork.c:1800 [inline] [<00000000c344af7c>] _do_fork+0x121/0x4f0 kernel/fork.c:2369 Reported-by: syzbot+722da59ccb264bc19910@syzkaller.appspotmail.com Fixes: 719c7d563c ("ipvs: Fix use-after-free in ip_vs_in") Signed-off-by: Julian Anastasov <ja@ssi.bg> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-07-26 09:14:10 +02:00
..
6lowpan
9p	net/9p: include trans_common.h to fix missing prototype warning.	2019-07-03 13:14:43 +02:00
802
8021q	vlan: disable SIOCSHWTSTAMP in container	2019-05-16 19:41:30 +02:00
appletalk	appletalk: Fix use-after-free in atalk_proc_exit	2019-04-20 09:16:05 +02:00
atm	net: atm: Fix potential Spectre v1 vulnerabilities	2019-04-27 09:36:30 +02:00
ax25	ax25: fix inconsistent lock state in ax25_destroy_timer	2019-06-22 08:15:13 +02:00
batman-adv	batman-adv: Fix duplicated OGMs on NETDEV_UP	2019-07-26 09:14:03 +02:00
bluetooth	Bluetooth: Fix faulty expression for minimum encryption key size check	2019-07-10 09:53:30 +02:00
bpf	bpf/test_run: support cgroup local storage	2018-08-03 00:47:32 +02:00
bpfilter	net: bpfilter: use get_pid_task instead of pid_task	2018-10-17 22:03:40 -07:00
bridge	bridge: Fix error path for kobject_init_and_add()	2019-05-16 19:41:29 +02:00
caif	Revert "net: simplify sock_poll_wait"	2018-11-04 14:50:51 +01:00
can	can: af_can: Fix error path of can_init()	2019-07-14 08:11:07 +02:00
ceph	libceph: wait for latest osdmap in ceph_monc_blacklist_add()	2019-03-27 14:14:39 +09:00
core	bpf: sockmap, fix use after free from sleep in psock backlog workqueue	2019-07-14 08:11:05 +02:00
dcb	net: dcb: Add priority-to-DSCP map getters	2018-07-27 13:17:50 -07:00
dccp	dccp: do not use ipv6 header for ipv4 flow	2019-04-03 06:26:15 +02:00
decnet	decnet: fix using plain integer as NULL warning	2018-08-09 14:11:24 -07:00
dns_resolver	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
dsa	net: dsa: Fix error cleanup path in dsa_init_module	2019-05-16 19:41:29 +02:00
ethernet
hsr	net/hsr: fix possible crash in add_timer()	2019-03-19 13:12:38 +01:00
ieee802154	ieee802154: lowpan_header_create check must check daddr	2019-01-09 17:38:31 +01:00
ife
ipv4	bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro	2019-07-03 13:14:48 +02:00
ipv6	netfilter: ipv6: nf_defrag: accept duplicate fragments again	2019-07-10 09:53:47 +02:00
iucv	Revert "net: simplify sock_poll_wait"	2018-11-04 14:50:51 +01:00
kcm	kcm: switch order of device registration to fix a crash	2019-04-17 08:38:40 +02:00
key	af_key: fix leaks in key_pol_get_resp and dump_sp.	2019-07-26 09:14:01 +02:00
l2tp	l2tp: use rcu_dereference_sk_user_data() in l2tp_udp_encap_recv()	2019-05-05 14:42:37 +02:00
l3mdev
lapb	lapb: fixed leak of control-blocks.	2019-06-22 08:15:13 +02:00
llc	llc: fix skb leak in llc_build_and_send_ui_pkt()	2019-06-04 08:02:31 +02:00
mac80211	mac80211: do not start any work during reconfigure flow	2019-07-14 08:11:11 +02:00
mac802154	net: mac802154: tx: expand tailroom if necessary	2018-08-06 11:21:37 +02:00
mpls	mpls: Return error for RTA_GATEWAY attribute	2019-03-10 07:17:19 +01:00
ncsi	net/ncsi: Fixup .dumpit message flags and ID check in Netlink handler	2018-08-22 21:39:08 -07:00
netfilter	ipvs: defer hook registration to avoid leaks	2019-07-26 09:14:10 +02:00
netlabel	netlabel: fix out-of-bounds memory accesses	2019-03-10 07:17:18 +01:00
netlink	genetlink: Fix a memory leak on error path	2019-04-03 06:26:15 +02:00
netrom	net: netrom: Fix error cleanup path of nr_proto_init	2019-05-02 09:58:57 +02:00
nfc	nfc: Ensure presence of required attributes in the deactivate_target handler	2019-06-22 08:15:14 +02:00
nsh
openvswitch	net: openvswitch: do not free vport if register_netdevice() is failed.	2019-06-22 08:15:14 +02:00
packet	net/packet: fix memory leak in packet_set_ring()	2019-07-03 13:14:47 +02:00
phonet	phonet: fix building with clang	2019-03-23 20:09:51 +01:00
psample
qrtr
rds	rds: Fix warning.	2019-07-10 09:53:46 +02:00
rfkill	Here are quite a large number of fixes, notably:	2018-09-03 22:12:02 -07:00
rose	net/rose: fix unbound loop in rose_loopback_timer()	2019-05-02 09:59:00 +02:00
rxrpc	rxrpc: Fix net namespace cleanup	2019-05-05 14:42:38 +02:00
sched	net: sched: don't use tc_action->order during action dump	2019-06-04 08:02:32 +02:00
sctp	sctp: change to hold sk after auth shkey is created successfully	2019-07-03 13:14:47 +02:00
smc	net/smc: move unhash before release of clcsock	2019-07-10 09:53:44 +02:00
strparser	net: strparser: partially revert "strparser: Call skb_unclone conditionally"	2019-05-16 19:41:27 +02:00
sunrpc	net :sunrpc :clnt :Fix xps refcount imbalance on the error path	2019-07-14 08:11:15 +02:00
switchdev
tipc	tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb	2019-07-03 13:14:49 +02:00
tls	net/tls: replace the sleeping lock around RX resync with a bit lock	2019-06-11 12:20:49 +02:00
unix	missing barriers in some of unix_sock ->addr and ->path accesses	2019-03-19 13:12:41 +01:00
vmw_vsock	vsock/virtio: set SOCK_DONE on peer shutdown	2019-06-22 08:15:14 +02:00
wimax	wimax: remove blank lines at EOF	2018-07-24 14:10:42 -07:00
wireless	mac80211: fix rate reporting inside cfg80211_calculate_bitrate_he()	2019-07-14 08:11:04 +02:00
x25	net/x25: fix a race in x25_bind()	2019-03-19 13:12:40 +01:00
xdp	xsk: fix umem memory leak on cleanup	2019-05-04 09:20:12 +02:00
xfrm	ipsec: select crypto ciphers for xfrm_algo	2019-07-26 09:14:10 +02:00
compat.c	sock: Make sock->sk_stamp thread-safe	2019-01-09 17:38:33 +01:00
Kconfig	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
Makefile
socket.c	net: socket: set sock->sk to NULL after calling proto_ops::release()	2019-03-10 07:17:18 +01:00
sysctl_net.c