linux/drivers/media
Arnd Bergmann dc6ecba3f6 pvrusb2: reduce stack usage pvr2_eeprom_analyze()
commit 6830733d53 upstream.

The driver uses a relatively large data structure on the stack, which
showed up on my radar as we get a warning with the "latent entropy"
GCC plugin:

drivers/media/usb/pvrusb2/pvrusb2-eeprom.c:153:1: error: the frame size of 1376 bytes is larger than 1152 bytes [-Werror=frame-larger-than=]

The warning is usually hidden as we raise the warning limit to 2048
when the plugin is enabled, but I'd like to lower that again in the
future, and making this function smaller helps to do that without
build regressions.

Further analysis shows that putting an 'i2c_client' structure on
the stack is not really supported, as the embedded 'struct device'
is not initialized here, and we are only saved by the fact that
the function that is called here does not use the pointer at all.

Fixes: d855497edb ("V4L/DVB (4228a): pvrusb2 to kernel 2.6.18")

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-06-26 07:13:09 +02:00
..
common [media] saa7146: use swap() in sort_and_eliminate() 2015-07-06 08:25:49 -03:00
dvb-core media: dvb_ringbuffer: Add memory barriers 2016-08-20 18:09:18 +02:00
dvb-frontends dvb-frontends/cxd2841er: define symbol_rate_min/max in T/C fe-ops 2017-05-25 14:30:14 +02:00
firewire [media] dvb: Get rid of typedev usage for enums 2015-06-09 17:47:35 -03:00
i2c s5k4ecgx: select CRC32 helper 2017-02-01 08:30:53 +01:00
mmc [media] siano: register media controller earlier 2015-02-26 09:10:39 -03:00
pci media: fix dm1105.c build error 2017-03-12 06:37:24 +01:00
platform s5p-mfc: Fix unbalanced call to clock management 2017-05-25 14:30:14 +02:00
radio [media] radio: Drop owner assignment from i2c_driver 2015-08-11 13:01:08 -03:00
rc mceusb: fix NULL-deref at probe 2017-05-25 14:30:12 +02:00
tuners xc2028: Fix use-after-free bug properly 2017-05-25 14:30:15 +02:00
usb pvrusb2: reduce stack usage pvr2_eeprom_analyze() 2017-06-26 07:13:09 +02:00
v4l2-core vb2: Fix an off by one error in 'vb2_plane_vaddr' 2017-06-26 07:13:08 +02:00
Kconfig media updates for v4.2-rc1 2015-06-25 17:55:48 -07:00
Makefile [media] bq/c-qcam, w9966, pms: move to staging in preparation for removal 2014-12-16 23:21:44 -02:00
media-device.c
media-devnode.c
media-entity.c [media] media-entity.c: get rid of var length arrays 2015-10-01 18:10:05 -03:00