Samuel Thibault 3ed1cfb2ce speakup ttyio: Do not schedule() in ttyio_in_nowait ... With the ltlk and spkout drivers, the index read function, i.e. in_nowait, is getting called from the read_all_doc mechanism, from the timer softirq: Call Trace: <IRQ> dump_stack+0x71/0x98 dequeue_task_idle+0x1f/0x28 __schedule+0x167/0x5d6 ? trace_hardirqs_on+0x2e/0x3a ? usleep_range+0x7f/0x7f schedule+0x8a/0xae schedule_timeout+0xb1/0xea ? del_timer_sync+0x31/0x31 do_wait_for_common+0xba/0x12b ? wake_up_q+0x45/0x45 wait_for_common+0x37/0x50 ttyio_in+0x2a/0x6b spk_ttyio_in_nowait+0xc/0x13 spk_get_index_count+0x20/0x93 cursor_done+0x1c6/0x4c6 ? read_all_doc+0xb1/0xb1 call_timer_fn+0x89/0x140 run_timer_softirq+0x164/0x1a5 ? read_all_doc+0xb1/0xb1 ? hrtimer_forward+0x7b/0x87 ? timerqueue_add+0x62/0x68 ? enqueue_hrtimer+0x95/0x9f __do_softirq+0x181/0x31f irq_exit+0x6a/0x86 smp_apic_timer_interrupt+0x15e/0x183 apic_timer_interrupt+0xf/0x20 </IRQ> We thus should not schedule() at all, even with timeout == 0, this crashes the kernel. We can however use try_wait_for_completion() instead of wait_for_completion_timeout(0). Cc: stable@vger.kernel.org Reported-by: John Covici <covici@ccs.covici.com> Tested-by: John Covici <covici@ccs.covici.com> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Link: https://lore.kernel.org/r/20201108131233.tadycr73sxlvodgo@function Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-11-09 18:14:29 +01:00
..
accessibility	speakup ttyio: Do not schedule() in ttyio_in_nowait	2020-11-09 18:14:29 +01:00
acpi	Merge branches 'acpi-button' and 'acpi-dock'	2020-10-30 16:31:20 +01:00
amba
android	task_work: cleanup notification modes	2020-10-17 15:05:30 -06:00
ata	libata-5.10-2020-10-30	2020-10-30 14:51:01 -07:00
atm
auxdisplay
base	device property: Don't clear secondary pointer for shared primary firmware node	2020-10-27 19:20:03 +01:00
bcma
block	xsysace: use platform_get_resource() and platform_get_irq_optional()	2020-10-29 08:22:33 -06:00
bluetooth	Bluetooth: btintel: Replace zero-length array with flexible-array member	2020-10-30 16:57:41 -05:00
bus	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
cdrom
char	virtio: virtio_console: fix DMA memory allocation for rproc serial	2020-11-09 18:03:33 +01:00
clk	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
clocksource	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
connector
counter
cpufreq	cpufreq: Introduce cpufreq_driver_test_flags()	2020-10-29 14:07:30 +01:00
cpuidle	powerpc updates for 5.10	2020-10-16 12:21:15 -07:00
crypto	s390 updates for the 5.10 merge window	2020-10-16 12:36:38 -07:00
dax	fuse update for 5.10	2020-10-19 14:28:30 -07:00
dca
devfreq
dio
dma	misc: mic: remove the MIC drivers	2020-10-28 19:12:03 +01:00
dma-buf	dma-mapping updates for 5.10	2020-10-15 14:43:29 -07:00
edac	EFI changes for v5.10:	2020-10-12 13:26:49 -07:00
eisa
extcon
firewire
firmware	ARM SCMI fixes for v5.10	2020-10-26 12:40:02 +01:00
fpga
fsi
gnss
gpio	- New Drivers	2020-10-14 15:56:58 -07:00
gpu	- Fix max memory region size calculation (Matt)	2020-10-30 11:54:11 +10:00
greybus
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-10-23 16:16:31 -07:00
hsi
hv	Merge branch 'akpm' (patches from Andrew)	2020-10-16 11:31:55 -07:00
hwmon	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
hwspinlock
hwtracing	coresight: cti: Initialize dynamic sysfs attributes	2020-10-29 20:10:25 +01:00
i2c	i2c: core: Restore acpi_walk_dep_device_list() getting called after registering the ACPI i2c devs	2020-10-25 13:33:54 +01:00
i3c	* Fix DAA for the pre-reserved address case	2020-10-17 11:01:01 -07:00
ide	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
idle	intel_idle: Fix max_cstate for processor models without C-state tables	2020-10-27 19:03:53 +01:00
iio	chrome platform changes for 5.10	2020-10-23 10:54:13 -07:00
infiniband	RDMA/qedr: Fix memory leak in iWARP CM	2020-10-28 09:45:25 -03:00
input	Merge branch 'parisc-5.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux	2020-10-25 10:59:34 -07:00
interconnect	interconnect: qcom: use icc_sync state for sm8[12]50	2020-10-27 16:01:22 +02:00
iommu	IOMMU Fix for Linux v5.10:	2020-10-20 09:35:06 -07:00
ipack
irqchip	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
isdn
leds	leds: pwm: Remove platform_data support	2020-10-07 12:02:58 +02:00
lightnvm	lightnvm: fix out-of-bounds write to array devices->info[]	2020-10-16 09:28:45 -06:00
macintosh	powerpc updates for 5.10	2020-10-16 12:21:15 -07:00
mailbox	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
mcb
md	- Improve DM core's bio splitting to use blk_max_size_offset(). Also	2020-10-14 15:05:38 -07:00
media	dma-mapping updates for 5.10	2020-10-15 14:43:29 -07:00
memory	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
memstick
message	scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()	2020-10-26 16:57:18 -04:00
mfd	- New Drivers	2020-10-14 15:56:58 -07:00
misc	habanalabs/gaudi: mask WDT error in QMAN	2020-11-04 08:56:07 +02:00
mmc	MMC host:	2020-10-30 11:04:11 -07:00
most
mtd	This pull request contains fixes for UBI and UBIFS	2020-10-18 09:56:50 -07:00
mux
net	flexible-array member conversion patches for 5.10-rc2	2020-10-31 14:31:28 -07:00
nfc	nfc: remove unneeded break	2020-10-20 10:36:41 -07:00
ntb	Bug fixes for v5.10	2020-10-25 11:12:31 -07:00
nubus
nvdimm	mm/memremap_pages: support multiple ranges per invocation	2020-10-13 18:38:28 -07:00
nvme	block-5.10-2020-10-30	2020-10-30 15:02:49 -07:00
nvmem
of	dma-mapping: fix 32-bit overflow with CONFIG_ARM_LPAE=n	2020-10-29 16:59:34 +01:00
opp	Merge branch 'cpufreq/arm/linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm	2020-10-06 12:26:45 +02:00
oprofile
parisc	dma-mapping: split <linux/dma-mapping.h>	2020-10-06 07:07:03 +02:00
parport
pci	VFIO updates for v5.10-rc1	2020-10-22 13:00:44 -07:00
pcmcia
perf
phy	pci-v5.10-changes	2020-10-22 12:41:00 -07:00
pinctrl	Pin control bulk changes for the v5.10 kernel cycle	2020-10-14 15:25:04 -07:00
platform	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-10-23 16:16:31 -07:00
pnp	PNP: fix kernel-doc markups	2020-10-27 19:23:04 +01:00
power	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
powercap	powercap: Fix typo in Kconfig "Plance" -> "Plane"	2020-10-19 17:40:53 +02:00
pps
ps3
ptp
pwm	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
rapidio	rapidio: fix the missed put_device() for rio_mport_add_riodev	2020-10-16 11:11:22 -07:00
ras
regulator	Merge remote-tracking branch 'regulator/for-5.10' into regulator-next	2020-10-05 16:54:56 +01:00
remoteproc	remoteproc updates for v5.10	2020-10-22 12:56:33 -07:00
reset	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
rpmsg	rpmsg updates for 5.10	2020-10-22 12:58:21 -07:00
rtc	RTC for 5.10	2020-10-21 11:22:08 -07:00
s390	s390/ism: fix incorrect system EID	2020-10-26 16:29:14 -07:00
sbus
scsi	SCSI fixes on 20201030	2020-10-31 12:21:04 -07:00
sfi
sh
siox
slimbus
soc	soc: ti: ti_sci_pm_domains: check for proper args count in xlate	2020-10-29 22:13:38 +01:00
soundwire
spi	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
spmi
ssb
staging	staging: fieldbus: anybuss: jump to correct label in an error path	2020-10-27 13:24:51 +01:00
target	scsi: target: tcmu: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
tc
tee	Reenable kernel login method for kernel TEE client API	2020-10-26 10:55:56 +01:00
thermal	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
thunderbolt
tty	vt_ioctl: fix GIO_UNIMAP regression	2020-10-28 13:41:17 +01:00
uio
usb	4 bug fixes for Cadence 3 driver.	2020-10-30 11:46:49 +01:00
vdpa	vhost,vdpa: fixes	2020-10-31 14:41:48 -07:00
vfio	VFIO updates for v5.10-rc1	2020-10-22 13:00:44 -07:00
vhost	vdpa: handle irq bypass register failure case	2020-10-30 04:02:53 -04:00
video	A couple of x86 fixes which missed rc1 due to my stupidity:	2020-10-27 14:39:29 -07:00
virt	virt: vbox: simplify the return expression of vbg_input_open()	2020-10-02 11:36:13 +02:00
virtio	vhost,vdpa,virtio: cleanups, fixes	2020-10-23 11:00:57 -07:00
visorbus
vlynq
vme
w1	w1: w1_therm: make w1_poll_completion static	2020-10-05 14:49:24 +02:00
watchdog	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
xen	xen: branch for v5.10-rc1c	2020-10-25 10:55:35 -07:00
zorro
Kconfig
Makefile