Amir Goldstein abae88fb37 fsnotify: fix fsnotify hooks in pseudo filesystems ... commit 29044dae2e upstream. Commit 49246466a9 ("fsnotify: move fsnotify_nameremove() hook out of d_delete()") moved the fsnotify delete hook before d_delete() so fsnotify will have access to a positive dentry. This allowed a race where opening the deleted file via cached dentry is now possible after receiving the IN_DELETE event. To fix the regression in pseudo filesystems, convert d_delete() calls to d_drop() (see commit 46c46f8df9 ("devpts_pty_kill(): don't bother with d_delete()") and move the fsnotify hook after d_drop(). Add a missing fsnotify_unlink() hook in nfsdfs that was found during the audit of fsnotify hooks in pseudo filesystems. Note that the fsnotify hooks in simple_recursive_removal() follow d_invalidate(), so they require no change. Link: https://lore.kernel.org/r/20220120215305.282577-2-amir73il@gmail.com Reported-by: Ivan Delalande <colona@arista.com> Link: https://lore.kernel.org/linux-fsdevel/YeNyzoDM5hP5LtGW@visor/ Fixes: 49246466a9 ("fsnotify: move fsnotify_nameremove() hook out of d_delete()") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-01 17:25:39 +01:00
..
configfs_internal.h	configfs: calculate the symlink target only once	2019-09-11 12:46:14 +02:00
dir.c	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:25:39 +01:00
file.c	configfs: fix memleak in configfs_release_bin_file	2021-07-14 16:56:48 +02:00
inode.c	docs: filesystems: convert configfs.txt to ReST	2020-05-05 09:23:25 -06:00
item.c	docs: filesystems: convert configfs.txt to ReST	2020-05-05 09:23:25 -06:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mount.c	configfs: calculate the symlink target only once	2019-09-11 12:46:14 +02:00
symlink.c	configfs: calculate the depth of parent item	2019-11-06 18:36:01 +01:00