Jingbo Xu 39bfcb8138 erofs: fix use-after-free of fsid and domain_id string ... When erofs instance is remounted with fsid or domain_id mount option specified, the original fsid and domain_id string pointer in sbi->opt is directly overridden with the fsid and domain_id string in the new fs_context, without freeing the original fsid and domain_id string. What's worse, when the new fsid and domain_id string is transferred to sbi, they are not reset to NULL in fs_context, and thus they are freed when remount finishes, while sbi is still referring to these strings. Reconfiguration for fsid and domain_id seems unusual. Thus clarify this restriction explicitly and dump a warning when users are attempting to do this. Besides, to fix the use-after-free issue, move fsid and domain_id from erofs_mount_opts to outside. Fixes: c6be2bd0a5 ("erofs: register fscache volume") Fixes: 8b7adf1dff ("erofs: introduce fscache-based domain") Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com> Reviewed-by: Chao Yu <chao@kernel.org> Link: https://lore.kernel.org/r/20221021023153.1330-1-jefflexu@linux.alibaba.com Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>		2022-11-10 09:53:20 +08:00
..
compress.h	erofs: introduce multi-reference pclusters (fully-referenced)	2022-07-22 21:44:27 +08:00
data.c	erofs: get rid of erofs_prepare_dio() helper	2022-07-22 21:46:03 +08:00
decompressor_lzma.c	erofs: introduce partial-referenced pclusters	2022-09-26 23:55:43 +08:00
decompressor.c	erofs: support interlaced uncompressed data for compressed files	2022-09-23 10:55:56 +08:00
dir.c	erofs: update ctx->pos for every emitted dirent	2022-07-31 22:26:29 +08:00
erofs_fs.h	erofs: introduce partial-referenced pclusters	2022-09-26 23:55:43 +08:00
fscache.c	erofs: fix use-after-free of fsid and domain_id string	2022-11-10 09:53:20 +08:00
inode.c	erofs: clean up erofs_iget()	2022-09-27 17:27:45 +08:00
internal.h	erofs: fix use-after-free of fsid and domain_id string	2022-11-10 09:53:20 +08:00
Kconfig	erofs: register fscache volume	2022-05-18 00:11:19 +08:00
Makefile	erofs: register fscache volume	2022-05-18 00:11:19 +08:00
namei.c	erofs: clean up erofs_iget()	2022-09-27 17:27:45 +08:00
pcpubuf.c	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
super.c	erofs: fix use-after-free of fsid and domain_id string	2022-11-10 09:53:20 +08:00
sysfs.c	erofs: fix use-after-free of fsid and domain_id string	2022-11-10 09:53:20 +08:00
tagptr.h	erofs: clean up file headers & footers	2021-06-08 00:41:24 +08:00
utils.c	mm: shrinkers: provide shrinkers with names	2022-07-03 18:08:40 -07:00
xattr.c	erofs: use meta buffers for xattr operations	2022-01-04 23:47:08 +08:00
xattr.h	erofs: clean up unnecessary code and comments	2022-09-27 17:27:25 +08:00
zdata.c	erofs: fix general protection fault when reading fragment	2022-11-08 14:44:13 +08:00
zdata.h	erofs: shouldn't churn the mapping page for duplicated copies	2022-10-17 06:55:49 +08:00
zmap.c	erofs: fix illegal unmapped accesses in z_erofs_fill_inode_lazy()	2022-10-17 06:55:48 +08:00