Jon Maloy 233aba68e8 UPSTREAM: tipc: improve size validations for received domain records ... commit 9aa422ad32 upstream. The function tipc_mon_rcv() allows a node to receive and process domain_record structs from peer nodes to track their views of the network topology. This patch verifies that the number of members in a received domain record does not exceed the limit defined by MAX_MON_DOMAIN, something that may otherwise lead to a stack overflow. tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where we are reading a 32 bit message data length field into a uint16. To avert any risk of bit overflow, we add an extra sanity check for this in that function. We cannot see that happen with the current code, but future designers being unaware of this risk, may introduce it by allowing delivery of very large (> 64k) sk buffers from the bearer layer. This potential problem was identified by Eric Dumazet. This fixes CVE-2022-0435 Reported-by: Samuel Page <samuel.page@appgate.com> Reported-by: Eric Dumazet <edumazet@google.com> Fixes: 35c55c9877 ("tipc: add neighbor monitoring framework") Signed-off-by: Jon Maloy <jmaloy@redhat.com> Reviewed-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Samuel Page <samuel.page@appgate.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 3c7e594355) Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> Change-Id: I5da5bc6880456ec91e6d3f3a283d2c24b6cc269c		2022-02-11 09:20:32 +01:00
..
addr.c
addr.h
bcast.c	net: tipc: fix FB_MTU eat two pages	2021-07-14 16:56:32 +02:00
bcast.h
bearer.c
bearer.h
core.c
core.h
crypto.c	tipc: fix size validations for the MSG_CRYPTO type	2021-11-02 19:48:19 +01:00
crypto.h
diag.c
discover.c
discover.h
eth_media.c
group.c
group.h
ib_media.c
Kconfig
link.c	UPSTREAM: tipc: improve size validations for received domain records	2022-02-11 09:20:32 +01:00
link.h
Makefile
monitor.c	UPSTREAM: tipc: improve size validations for received domain records	2022-02-11 09:20:32 +01:00
monitor.h
msg.c	net: tipc: fix FB_MTU eat two pages	2021-07-14 16:56:32 +02:00
msg.h	net: tipc: fix FB_MTU eat two pages	2021-07-14 16:56:32 +02:00
name_distr.c
name_distr.h
name_table.c	Revert "treewide: Change list_sort to use const pointers"	2021-10-04 11:07:40 +02:00
name_table.h
net.c
net.h
netlink_compat.c
netlink.c
netlink.h
node.c
node.h
socket.c	tipc: increase timeout in tipc_sk_enqueue()	2021-09-22 12:27:57 +02:00
socket.h
subscr.c
subscr.h
sysctl.c
topsrv.c
topsrv.h
trace.c
trace.h
udp_media.c
udp_media.h