mirror of
https://github.com/torvalds/linux.git
synced 2026-06-12 08:43:42 +02:00
8d81d0b465
Eric's suggested fix for the previous commit's mentioned race condition was to simply take the table->lock in wg_index_hashtable_replace(). The table->lock of the hash table is supposed to protect the bucket heads, not the entires, but actually, since all the mutator functions are already taking it, it makes sense to take it too for the test to hlist_unhashed, as a defense in depth measure, so that it no longer races with deletions, regardless of what other locks are protecting individual entries. This is sensible from a performance perspective because, as Eric pointed out, the case of being unhashed is already the unlikely case, so this won't add common contention. And comparing instructions, this basically doesn't make much of a difference other than pushing and popping %r13, used by the new `bool ret`. More generally, I like the idea of locking consistency across table mutator functions, and this might let me rest slightly easier at night. Suggested-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/wireguard/20200908145911.4090480-1-edumazet@google.com/ Fixes: |
||
|---|---|---|
| .. | ||
| selftest | ||
| allowedips.c | ||
| allowedips.h | ||
| cookie.c | ||
| cookie.h | ||
| device.c | ||
| device.h | ||
| main.c | ||
| Makefile | ||
| messages.h | ||
| netlink.c | ||
| netlink.h | ||
| noise.c | ||
| noise.h | ||
| peer.c | ||
| peer.h | ||
| peerlookup.c | ||
| peerlookup.h | ||
| queueing.c | ||
| queueing.h | ||
| ratelimiter.c | ||
| ratelimiter.h | ||
| receive.c | ||
| send.c | ||
| socket.c | ||
| socket.h | ||
| timers.c | ||
| timers.h | ||
| version.h | ||