Vladimir Oltean 33cb0ff30c net: mscc: ocelot: don't let phylink re-enable TX PAUSE on the NPI port ... Since commit b39648079d ("net: mscc: ocelot: disable flow control on NPI interface"), flow control should be disabled on the DSA CPU port when used in NPI mode. However, the commit blamed in the Fixes: tag below broke this, because it allowed felix_phylink_mac_link_up() to overwrite SYS_PAUSE_CFG_PAUSE_ENA for the DSA CPU port. This issue became noticeable since the device tree update from commit 8fcea7be57 ("arm64: dts: ls1028a: mark internal links between Felix and ENETC as capable of flow control"). The solution is to check whether this is the currently configured NPI port from ocelot_phylink_mac_link_up(), and to not modify the statically disabled PAUSE frame transmission if it is. When the port is configured for lossless mode as opposed to tail drop mode, but the link partner (DSA master) doesn't observe the transmitted PAUSE frames, the switch termination throughput is much worse, as can be seen below. Before: root@debian:~# iperf3 -c 192.168.100.2 Connecting to host 192.168.100.2, port 5201 [ 5] local 192.168.100.1 port 37504 connected to 192.168.100.2 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 28.4 MBytes 238 Mbits/sec 357 22.6 KBytes [ 5] 1.00-2.00 sec 33.6 MBytes 282 Mbits/sec 426 19.8 KBytes [ 5] 2.00-3.00 sec 34.0 MBytes 285 Mbits/sec 343 21.2 KBytes [ 5] 3.00-4.00 sec 32.9 MBytes 276 Mbits/sec 354 22.6 KBytes [ 5] 4.00-5.00 sec 32.3 MBytes 271 Mbits/sec 297 18.4 KBytes ^C[ 5] 5.00-5.06 sec 2.05 MBytes 270 Mbits/sec 45 19.8 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-5.06 sec 163 MBytes 271 Mbits/sec 1822 sender [ 5] 0.00-5.06 sec 0.00 Bytes 0.00 bits/sec receiver After: root@debian:~# iperf3 -c 192.168.100.2 Connecting to host 192.168.100.2, port 5201 [ 5] local 192.168.100.1 port 49470 connected to 192.168.100.2 port 5201 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.00 sec 112 MBytes 941 Mbits/sec 259 143 KBytes [ 5] 1.00-2.00 sec 110 MBytes 920 Mbits/sec 329 144 KBytes [ 5] 2.00-3.00 sec 112 MBytes 936 Mbits/sec 255 144 KBytes [ 5] 3.00-4.00 sec 110 MBytes 927 Mbits/sec 355 105 KBytes [ 5] 4.00-5.00 sec 110 MBytes 926 Mbits/sec 350 156 KBytes [ 5] 5.00-6.00 sec 110 MBytes 925 Mbits/sec 305 148 KBytes [ 5] 6.00-7.00 sec 110 MBytes 924 Mbits/sec 320 143 KBytes [ 5] 7.00-8.00 sec 110 MBytes 925 Mbits/sec 273 97.6 KBytes [ 5] 8.00-9.00 sec 109 MBytes 913 Mbits/sec 299 141 KBytes [ 5] 9.00-10.00 sec 110 MBytes 922 Mbits/sec 287 146 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.00 sec 1.08 GBytes 926 Mbits/sec 3032 sender [ 5] 0.00-10.00 sec 1.08 GBytes 925 Mbits/sec receiver Fixes: de274be32c ("net: dsa: felix: set TX flow control according to the phylink_mac_link_up resolution") Reported-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2022-01-13 12:52:15 +00:00
..
appletalk	net: Don't include filter.h from net/sock.h	2021-12-29 08:48:14 -08:00
arcnet
bonding	net: bonding: fix bond_xmit_broadcast return value error bug	2022-01-12 14:46:39 +00:00
caif
can	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-01-09 17:00:17 -08:00
dsa	net: dsa: felix: add port fast age support	2022-01-07 18:58:25 -08:00
ethernet	net: mscc: ocelot: don't let phylink re-enable TX PAUSE on the NPI port	2022-01-13 12:52:15 +00:00
fddi	net:Remove initialization of static variables to 0	2021-12-27 14:53:00 +00:00
fjes	fjes: Check for error irq	2021-12-22 10:22:13 +00:00
hamradio	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
hippi
hyperv	bpf: Let bpf_warn_invalid_xdp_action() report more info	2021-12-13 22:28:27 +01:00
ieee802154	ieee802154: atusb: fix uninit value in atusb_set_extended_addr	2022-01-04 20:10:04 +01:00
ipa	net: ipa: prevent concurrent replenish	2022-01-12 14:39:53 +00:00
ipvlan
mctp
mdio
netdevsim	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-12-16 16:13:19 -08:00
pcs	net: pcs: lynx: use a common naming scheme for all lynx_pcs variables	2022-01-02 18:48:47 +00:00
phy	net: phy: at803x: make array offsets static	2022-01-11 21:09:10 -08:00
plip
ppp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-01-09 17:00:17 -08:00
slip
team
usb	net: qmi_wwan: add ZTE MF286D modem 19d2:1485	2022-01-13 12:34:08 +00:00
vmxnet3	vmxnet3: Remove useless DMA-32 fallback configuration	2022-01-09 16:52:19 -08:00
wan	net: wan/lmc: fix spelling of "its"	2021-12-24 10:23:47 +00:00
wireguard
wireless	iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt_smoothing()	2022-01-09 16:25:53 -08:00
wwan	Revert "net: wwan: iosm: Keep device at D0 for s2idle case"	2022-01-04 18:15:17 -08:00
xen-netback	xen/netback: don't queue unlimited number of packages	2021-12-16 08:43:12 +01:00
amt.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-01-09 17:00:17 -08:00
bareudp.c	bareudp: Add extack support to bareudp_configure()	2021-12-14 12:39:17 +00:00
dummy.c
eql.c
geneve.c
gtp.c
ifb.c
Kconfig	lib/crypto: blake2s: include as built-in	2022-01-07 00:25:25 +01:00
LICENSE.SRC
loopback.c	net: Don't include filter.h from net/sock.h	2021-12-29 08:48:14 -08:00
macsec.c
macvlan.c
macvtap.c
Makefile
mdio.c
mhi_net.c
mii.c
net_failover.c
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tap.c
thunderbolt.c
tun.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
veth.c	veth: Do not record rx queue hint in veth_xmit	2022-01-06 13:49:54 +00:00
virtio_net.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
vrf.c	net: Don't include filter.h from net/sock.h	2021-12-29 08:48:14 -08:00
vsockmon.c
vxlan.c
xen-netfront.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00