mirror of
https://github.com/torvalds/linux.git
synced 2026-09-14 16:10:02 +02:00
4a9ec5ec95
After a recent upstream LLVM change to start generating jump and lookup
tables in switch statements in more instances [1], linking the
compressed x86 boot image when CONFIG_KERNEL_ZSTD is enabled fails with:
ld.lld: error: Unexpected run-time relocations (.rela) detected!
Dumping the relocations in misc.o, which is the only file influenced by
CONFIG_KERNEL_ZSTD in the decompressor, shows dynamic relocations to
some string constants, which correspond to the string literals in the
switch statement in handle_zstd_error():
Relocation section '.rela.data.rel.ro' at offset 0x277b0 contains 31 entries:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000006600000001 R_X86_64_64 0000000000000000 .rodata.str1.1 + 73a
0000000000000008 0000006600000001 R_X86_64_64 0000000000000000 .rodata.str1.1 + 78e
0000000000000010 0000006600000001 R_X86_64_64 0000000000000000 .rodata.str1.1 + 78e
0000000000000018 0000006600000001 R_X86_64_64 0000000000000000 .rodata.str1.1 + 78e
...
This optimization is problematic for the decompressor environment, as it
is built as -fPIE without any explicit absolute references (as described
at the top of misc.c) while not applying any dynamic relocations, hence
the linker assertion. To opt out of this optimization, which is of
little value in this special early boot code, and to mirror the other
x86 startup code in arch/x86/boot/startup, disable jump tables in the
decompressor.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Cc: Bill Wendling <morbo@google.com>
Cc: Justin Stitt <justinstitt@google.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link:
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| acpi.c | ||
| cmdline.c | ||
| cpuflags.c | ||
| early_serial_console.c | ||
| efi.c | ||
| efi.h | ||
| error.c | ||
| error.h | ||
| head_32.S | ||
| head_64.S | ||
| ident_map_64.c | ||
| idt_64.c | ||
| idt_handlers_64.S | ||
| kaslr.c | ||
| kernel_info.S | ||
| Makefile | ||
| mem_encrypt.S | ||
| mem.c | ||
| misc.c | ||
| misc.h | ||
| mkpiggy.c | ||
| pgtable_64.c | ||
| sbat.S | ||
| sev-handle-vc.c | ||
| sev.c | ||
| sev.h | ||
| string.c | ||
| tdcall.S | ||
| tdx-shared.c | ||
| tdx.c | ||
| tdx.h | ||
| vmlinux.lds.S | ||