mirror of
https://github.com/torvalds/linux.git
synced 2026-09-18 16:48:03 +02:00
ea8ea212d4
get_device_state() calls __ethtool_get_link_ksettings() on the trigger's
netdev, which will soon take the dev's ops lock. Three of its callers
already hold that lock and one doesn't, so the function would either
deadlock or run unprotected depending on the path.
Make get_device_state() expect the dev's ops lock held and switch to
netif_get_link_ksettings():
* netdev_trig_notify() NETDEV_UP / NETDEV_CHANGE / NETDEV_CHANGENAME
arrive with the dev's ops lock held (per netdevices.rst).
* set_device_name() does not hold the lock, take it explicitly.
Due to lock ordering we need to reshuffle the code in set_device_name()
a little bit. We need to find the device earlier on, so that we can
lock it before we take trigger_data->lock.
Link: https://patch.msgid.link/20260603012840.2254293-10-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| ledtrig-activity.c | ||
| ledtrig-backlight.c | ||
| ledtrig-camera.c | ||
| ledtrig-cpu.c | ||
| ledtrig-default-on.c | ||
| ledtrig-disk.c | ||
| ledtrig-gpio.c | ||
| ledtrig-heartbeat.c | ||
| ledtrig-input-events.c | ||
| ledtrig-mtd.c | ||
| ledtrig-netdev.c | ||
| ledtrig-oneshot.c | ||
| ledtrig-panic.c | ||
| ledtrig-pattern.c | ||
| ledtrig-timer.c | ||
| ledtrig-transient.c | ||
| ledtrig-tty.c | ||
| Makefile | ||