Eric Dumazet 32a329b731 netfilter: conntrack: annotate data-races around ct->timeout ... commit 802a7dc5cf upstream. (struct nf_conn)->timeout can be read/written locklessly, add READ_ONCE()/WRITE_ONCE() to prevent load/store tearing. BUG: KCSAN: data-race in __nf_conntrack_alloc / __nf_conntrack_find_get write to 0xffff888132e78c08 of 4 bytes by task 6029 on cpu 0: __nf_conntrack_alloc+0x158/0x280 net/netfilter/nf_conntrack_core.c:1563 init_conntrack+0x1da/0xb30 net/netfilter/nf_conntrack_core.c:1635 resolve_normal_ct+0x502/0x610 net/netfilter/nf_conntrack_core.c:1746 nf_conntrack_in+0x1c5/0x88f net/netfilter/nf_conntrack_core.c:1901 ipv6_conntrack_local+0x19/0x20 net/netfilter/nf_conntrack_proto.c:414 nf_hook_entry_hookfn include/linux/netfilter.h:142 [inline] nf_hook_slow+0x72/0x170 net/netfilter/core.c:619 nf_hook include/linux/netfilter.h:262 [inline] NF_HOOK include/linux/netfilter.h:305 [inline] ip6_xmit+0xa3a/0xa60 net/ipv6/ip6_output.c:324 inet6_csk_xmit+0x1a2/0x1e0 net/ipv6/inet6_connection_sock.c:135 __tcp_transmit_skb+0x132a/0x1840 net/ipv4/tcp_output.c:1402 tcp_transmit_skb net/ipv4/tcp_output.c:1420 [inline] tcp_write_xmit+0x1450/0x4460 net/ipv4/tcp_output.c:2680 __tcp_push_pending_frames+0x68/0x1c0 net/ipv4/tcp_output.c:2864 tcp_push_pending_frames include/net/tcp.h:1897 [inline] tcp_data_snd_check+0x62/0x2e0 net/ipv4/tcp_input.c:5452 tcp_rcv_established+0x880/0x10e0 net/ipv4/tcp_input.c:5947 tcp_v6_do_rcv+0x36e/0xa50 net/ipv6/tcp_ipv6.c:1521 sk_backlog_rcv include/net/sock.h:1030 [inline] __release_sock+0xf2/0x270 net/core/sock.c:2768 release_sock+0x40/0x110 net/core/sock.c:3300 sk_stream_wait_memory+0x435/0x700 net/core/stream.c:145 tcp_sendmsg_locked+0xb85/0x25a0 net/ipv4/tcp.c:1402 tcp_sendmsg+0x2c/0x40 net/ipv4/tcp.c:1440 inet6_sendmsg+0x5f/0x80 net/ipv6/af_inet6.c:644 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg net/socket.c:724 [inline] __sys_sendto+0x21e/0x2c0 net/socket.c:2036 __do_sys_sendto net/socket.c:2048 [inline] __se_sys_sendto net/socket.c:2044 [inline] __x64_sys_sendto+0x74/0x90 net/socket.c:2044 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae read to 0xffff888132e78c08 of 4 bytes by task 17446 on cpu 1: nf_ct_is_expired include/net/netfilter/nf_conntrack.h:286 [inline] ____nf_conntrack_find net/netfilter/nf_conntrack_core.c:776 [inline] __nf_conntrack_find_get+0x1c7/0xac0 net/netfilter/nf_conntrack_core.c:807 resolve_normal_ct+0x273/0x610 net/netfilter/nf_conntrack_core.c:1734 nf_conntrack_in+0x1c5/0x88f net/netfilter/nf_conntrack_core.c:1901 ipv6_conntrack_local+0x19/0x20 net/netfilter/nf_conntrack_proto.c:414 nf_hook_entry_hookfn include/linux/netfilter.h:142 [inline] nf_hook_slow+0x72/0x170 net/netfilter/core.c:619 nf_hook include/linux/netfilter.h:262 [inline] NF_HOOK include/linux/netfilter.h:305 [inline] ip6_xmit+0xa3a/0xa60 net/ipv6/ip6_output.c:324 inet6_csk_xmit+0x1a2/0x1e0 net/ipv6/inet6_connection_sock.c:135 __tcp_transmit_skb+0x132a/0x1840 net/ipv4/tcp_output.c:1402 __tcp_send_ack+0x1fd/0x300 net/ipv4/tcp_output.c:3956 tcp_send_ack+0x23/0x30 net/ipv4/tcp_output.c:3962 __tcp_ack_snd_check+0x2d8/0x510 net/ipv4/tcp_input.c:5478 tcp_ack_snd_check net/ipv4/tcp_input.c:5523 [inline] tcp_rcv_established+0x8c2/0x10e0 net/ipv4/tcp_input.c:5948 tcp_v6_do_rcv+0x36e/0xa50 net/ipv6/tcp_ipv6.c:1521 sk_backlog_rcv include/net/sock.h:1030 [inline] __release_sock+0xf2/0x270 net/core/sock.c:2768 release_sock+0x40/0x110 net/core/sock.c:3300 tcp_sendpage+0x94/0xb0 net/ipv4/tcp.c:1114 inet_sendpage+0x7f/0xc0 net/ipv4/af_inet.c:833 rds_tcp_xmit+0x376/0x5f0 net/rds/tcp_send.c:118 rds_send_xmit+0xbed/0x1500 net/rds/send.c:367 rds_send_worker+0x43/0x200 net/rds/threads.c:200 process_one_work+0x3fc/0x980 kernel/workqueue.c:2298 worker_thread+0x616/0xa70 kernel/workqueue.c:2445 kthread+0x2c7/0x2e0 kernel/kthread.c:327 ret_from_fork+0x1f/0x30 value changed: 0x00027cc2 -> 0x00000000 Reported by Kernel Concurrency Sanitizer on: CPU: 1 PID: 17446 Comm: kworker/u4:5 Tainted: G W 5.16.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: krdsd rds_send_worker Note: I chose an arbitrary commit for the Fixes: tag, because I do not think we need to backport this fix to very old kernels. Fixes: e37542ba11 ("netfilter: conntrack: avoid possible false sharing") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-12-14 11:32:37 +01:00
..
9p
bluetooth	Bluetooth: defer cleanup of resources in hci_unregister_dev()	2021-08-12 13:22:08 +02:00
caif	net: caif: add proper error handling	2021-06-10 13:39:24 +02:00
iucv
netfilter	netfilter: conntrack: annotate data-races around ct->timeout	2021-12-14 11:32:37 +01:00
netns	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:03:26 +01:00
nfc	NFC: add NCI_UNREG flag to eliminate the race	2021-11-26 10:39:18 +01:00
phonet
sctp	sctp: move 198 addresses from unusable to private scope	2021-07-31 08:16:11 +02:00
tc_act	net/sched: act_vlan: Fix modify to allow 0	2021-07-14 16:56:19 +02:00
6lowpan.h
act_api.h	net: sched: fix err handler in tcf_action_init()	2021-04-14 08:42:05 +02:00
addrconf.h	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-05-14 09:50:44 +02:00
af_ieee802154.h
af_rxrpc.h
af_unix.h
af_vsock.h
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h
bareudp.h
bond_3ad.h
bond_alb.h	bonding: make tx_rebalance_counter an atomic	2021-12-14 11:32:36 +01:00
bond_options.h
bonding.h	bonding: Add struct bond_ipesc to manage SA	2021-07-28 14:35:33 +02:00
bpf_sk_storage.h
busy_poll.h	net: annotate data race around sk_ll_usec	2021-07-31 08:16:11 +02:00
calipso.h
cfg80211-wext.h
cfg80211.h	cfg80211: fix management registrations locking	2021-11-02 19:48:20 +01:00
cfg802154.h
checksum.h
cipso_ipv4.h
cls_cgroup.h
codel_impl.h
codel_qdisc.h
codel.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
dsa.h
dsfield.h
dst_cache.h	wireguard: device: reset peer src endpoint when netns exits	2021-12-08 09:03:22 +01:00
dst_metadata.h	net: validate lwtstate->data before returning from skb_tunnel_info()	2021-07-25 14:36:20 +02:00
dst_ops.h
dst.h	net: Consolidate common blackhole dst ops	2021-03-30 14:32:05 +02:00
erspan.h
esp.h
espintcp.h
ethoc.h
failover.h
fib_notifier.h
fib_rules.h	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:03:21 +01:00
firewire.h
flow_dissector.h
flow_offload.h	net: Fix offloading indirect devices dependency on qdisc order creation	2021-09-18 13:40:30 +02:00
flow.h
fou.h
fq_impl.h
fq.h
garp.h
gen_stats.h
genetlink.h
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h
hwbm.h
icmp.h	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 11:38:46 +01:00
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h
ife.h
ila.h
inet_common.h
inet_connection_sock.h	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 14:04:08 +01:00
inet_ecn.h
inet_frag.h
inet_hashtables.h
inet_sock.h
inet_timewait_sock.h
inet6_connection_sock.h
inet6_hashtables.h
inetpeer.h
ip_fib.h	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:03:26 +01:00
ip_tunnels.h
ip_vs.h
ip.h	net: lwtunnel: handle MTU calculation in forwading	2021-07-14 16:56:32 +02:00
ip6_checksum.h
ip6_fib.h	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:19:05 +01:00
ip6_route.h	net: ipv6: fix returned variable type in ip6_skb_dst_mtu	2021-08-12 13:22:07 +02:00
ip6_tunnel.h
ipcomp.h
ipconfig.h
ipv6_frag.h
ipv6_stubs.h	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:19:05 +01:00
ipv6.h
ipx.h
iw_handler.h
kcm.h
l3mdev.h
lag.h
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h	net: llc: fix skb_over_panic	2021-08-04 12:46:43 +02:00
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h	llc: fix out-of-bound array index in llc_sk_dev_hash()	2021-11-18 14:04:27 +01:00
lwtunnel.h
mac80211.h	mac80211: Fix NULL ptr deref for injected rate info	2021-06-23 14:42:52 +02:00
mac802154.h
macsec.h	net: macsec: fix the length used to copy the key for offloading	2021-07-14 16:56:28 +02:00
mip6.h
mld.h
mpls_iptunnel.h
mpls.h
mptcp.h
mrp.h
ncsi.h
ndisc.h
neighbour.h	net, neigh: Enable state migration between NUD_PERMANENT and NTF_USE	2021-11-18 14:04:29 +01:00
net_failover.h
net_namespace.h	net: make get_net_ns return error if NET_NS is disabled	2021-06-23 14:42:44 +02:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h
netprio_cgroup.h
netrom.h
nexthop.h	net: ipv4: Fix rtnexthop len when RTA_FLOW is present	2021-10-06 15:55:53 +02:00
nl802154.h	net: ieee802154: handle iftypes as u32	2021-12-01 09:19:03 +01:00
nsh.h
p8022.h
page_pool.h	mm: fix struct page layout on 32-bit systems	2021-05-19 10:13:17 +02:00
pie.h
ping.h
pkt_cls.h	net: zero-initialize tc skb extension on allocation	2021-06-03 09:00:51 +02:00
pkt_sched.h	net: prevent user from passing illegal stab size	2021-10-17 10:43:33 +02:00
pptp.h
protocol.h
psample.h	psample: Add a fwd declaration for skbuff	2021-08-18 08:59:11 +02:00
psnap.h
raw.h
rawv6.h
red.h	sch_red: fix off-by-one checks in red_check_params()	2021-04-14 08:42:07 +02:00
regulatory.h
request_sock.h
rose.h
route.h
rpl.h
rsi_91x.h
rtnetlink.h	can: dev: Move device back to init netns on owning netns delete	2021-03-30 14:32:08 +02:00
rtnh.h
sch_generic.h	net: sched: update default qdisc visibility after Tx queue cnt changes	2021-11-18 14:03:53 +01:00
scm.h
secure_seq.h
seg6_hmac.h
seg6_local.h
seg6.h
slhc_vj.h
smc.h
snmp.h
sock_reuseport.h
sock.h	tcp: fix page frag corruption on page fault	2021-12-08 09:03:23 +01:00
Space.h
stp.h
strparser.h	bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding	2021-11-18 14:04:27 +01:00
switchdev.h	switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT	2021-02-17 11:02:29 +01:00
tcp_states.h
tcp.h	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 14:04:08 +01:00
timewait_sock.h
tipc.h
tls_toe.h
tls.h	net/tls: Fix flipped sign in tls_err_abort() calls	2021-11-02 19:48:19 +01:00
transp_v6.h
tso.h
tun_proto.h
udp_tunnel.h
udp.h	net: multicast: calculate csum of looped-back and forwarded packets	2021-11-18 14:03:43 +01:00
udplite.h
vsock_addr.h
vxlan.h
wext.h
wimax.h
x25.h
x25device.h
xdp_priv.h
xdp_sock_drv.h
xdp_sock.h
xdp.h
xfrm.h	xfrm: xfrm_state_mtu should return at least 1280 for ipv6	2021-07-14 16:56:14 +02:00
xsk_buff_pool.h	xsk: Fix missing validation for skb and unaligned mode	2021-07-14 16:56:23 +02:00