Juerg Haefliger a1eda21a2c staging: bcm2835-audio: Replace unsafe strcpy() with strscpy() ... [ Upstream commit 4964a43006 ] Replace strcpy() with strscpy() in bcm2835-audio/bcm2835.c to prevent the following when loading snd-bcm2835: [ 58.480634] ------------[ cut here ]------------ [ 58.485321] kernel BUG at lib/string.c:1149! [ 58.489650] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP [ 58.495214] Modules linked in: snd_bcm2835(COE+) snd_pcm snd_timer snd dm_multipath scsi_dh_rdac scsi_dh_emc scsi_dh_alua btsdio bluetooth ecdh_generic ecc bcm2835_v4l2(CE) bcm2835_codec(CE) brcmfmac bcm2835_isp(CE) bcm2835_mmal_vchiq(CE) brcmutil cfg80211 v4l2_mem2mem videobuf2_vmalloc videobuf2_dma_contig videobuf2_memops raspberrypi_hwmon videobuf2_v4l2 videobuf2_common videodev bcm2835_gpiomem mc vc_sm_cma(CE) rpivid_mem uio_pdrv_genirq uio sch_fq_codel drm ip_tables x_tables autofs4 btrfs blake2b_generic raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor xor_neon raid6_pq libcrc32c raid1 raid0 multipath linear dwc2 roles spidev udc_core crct10dif_ce xhci_pci xhci_pci_renesas phy_generic aes_neon_bs aes_neon_blk crypto_simd cryptd [ 58.563787] CPU: 3 PID: 1959 Comm: insmod Tainted: G C OE 5.11.0-1001-raspi #1 [ 58.572172] Hardware name: Raspberry Pi 4 Model B Rev 1.2 (DT) [ 58.578086] pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=--) [ 58.584178] pc : fortify_panic+0x20/0x24 [ 58.588161] lr : fortify_panic+0x20/0x24 [ 58.592136] sp : ffff800010a83990 [ 58.595491] x29: ffff800010a83990 x28: 0000000000000002 [ 58.600879] x27: ffffb0b07cb72928 x26: 0000000000000000 [ 58.606268] x25: ffff39e884973838 x24: ffffb0b07cb74190 [ 58.611655] x23: ffffb0b07cb72030 x22: 0000000000000000 [ 58.617042] x21: ffff39e884973014 x20: ffff39e88b793010 [ 58.622428] x19: ffffb0b07cb72670 x18: 0000000000000030 [ 58.627814] x17: 0000000000000000 x16: ffffb0b092ce2c1c [ 58.633200] x15: ffff39e88b901500 x14: 0720072007200720 [ 58.638588] x13: 0720072007200720 x12: 0720072007200720 [ 58.643979] x11: ffffb0b0936cbdf0 x10: 00000000fffff000 [ 58.649366] x9 : ffffb0b09220cfa8 x8 : 0000000000000000 [ 58.654752] x7 : ffffb0b093673df0 x6 : ffffb0b09364e000 [ 58.660140] x5 : 0000000000000000 x4 : ffff39e93b7db948 [ 58.665526] x3 : ffff39e93b7ebcf0 x2 : 0000000000000000 [ 58.670913] x1 : 0000000000000000 x0 : 0000000000000022 [ 58.676299] Call trace: [ 58.678775] fortify_panic+0x20/0x24 [ 58.682402] snd_bcm2835_alsa_probe+0x5b8/0x7d8 [snd_bcm2835] [ 58.688247] platform_probe+0x74/0xe4 [ 58.691963] really_probe+0xf0/0x510 [ 58.695585] driver_probe_device+0xe0/0x100 [ 58.699826] device_driver_attach+0xcc/0xd4 [ 58.704068] __driver_attach+0xb0/0x17c [ 58.707956] bus_for_each_dev+0x7c/0xd4 [ 58.711843] driver_attach+0x30/0x40 [ 58.715467] bus_add_driver+0x154/0x250 [ 58.719354] driver_register+0x84/0x140 [ 58.723242] __platform_driver_register+0x34/0x40 [ 58.728013] bcm2835_alsa_driver_init+0x30/0x1000 [snd_bcm2835] [ 58.734024] do_one_initcall+0x54/0x300 [ 58.737914] do_init_module+0x60/0x280 [ 58.741719] load_module+0x680/0x770 [ 58.745344] __do_sys_finit_module+0xbc/0x130 [ 58.749761] __arm64_sys_finit_module+0x2c/0x40 [ 58.754356] el0_svc_common.constprop.0+0x88/0x220 [ 58.759216] do_el0_svc+0x30/0xa0 [ 58.762575] el0_svc+0x28/0x70 [ 58.765669] el0_sync_handler+0x1a4/0x1b0 [ 58.769732] el0_sync+0x178/0x180 [ 58.773095] Code: aa0003e1 91366040 910003fd 97ffee21 (d4210000) [ 58.779275] ---[ end trace 29be5b17497bd898 ]--- [ 58.783955] note: insmod[1959] exited with preempt_count 1 [ 58.791921] ------------[ cut here ]------------ For the sake of it, replace all the other occurences of strcpy() under bcm2835-audio/ as well. Signed-off-by: Juerg Haefliger <juergh@canonical.com> Link: https://lore.kernel.org/r/20210205072502.10907-1-juergh@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-03-07 12:34:10 +01:00
..
android
axis-fifo
board
clocking-wizard
comedi	Staging: comedi: Return -EFAULT if copy_to_user() fails	2021-01-12 20:18:17 +01:00
emxx_udc	staging/emxx_udc: fix indenting issue on a couple of statements	2020-09-22 09:49:32 +02:00
fbtft
fieldbus	staging: fieldbus: anybuss: jump to correct label in an error path	2020-10-27 13:24:51 +01:00
fsl-dpaa2	staging: dpaa2-switch: add a dpaa2_switch prefix to all functions in ethsw.c	2020-10-10 12:33:41 +02:00
fwserial	staging: fwserial: Fix error handling in fwserial_create	2021-03-07 12:34:08 +01:00
gasket	staging: gasket: interrupt: fix the missed eventfd_ctx_put() in gasket_interrupt.c	2020-12-30 11:53:10 +01:00
gdm724x	staging: gdm724x: Fix DMA from stack	2021-03-04 11:38:33 +01:00
goldfish
greybus	staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls	2020-12-30 11:53:39 +01:00
gs_fpgaboot
hikey9xx	staging: spmi: hisi-spmi-controller: Fix some error handling paths	2021-01-19 18:27:25 +01:00
iio	staging:iio:documentation: Drop most generic docs	2020-09-16 19:12:00 +01:00
kpc2000
ks7010	staging: ks7010: convert tasklets to use new tasklet_setup() API	2020-09-16 13:12:59 +02:00
media	media: atomisp: Fix a buffer overflow in debug code	2021-03-04 11:37:43 +01:00
most	staging: most: sound: add sanity check for function argument	2021-03-07 12:34:10 +01:00
mt7621-dma	staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c	2021-03-04 11:38:33 +01:00
mt7621-dts
mt7621-pci	staging: mt7621-pci: avoid to request pci bus resources	2020-11-06 11:11:28 +01:00
mt7621-pci-phy
mt7621-pinctrl
netlogic
nvec	Staging: nvec: Removes repeated word typo in comment	2020-10-01 10:55:17 +02:00
octeon	staging: octeon: Drop on uncorrectable alignment or FCS error	2020-10-27 13:18:50 +01:00
octeon-usb
olpc_dcon
pi433
qlge	Staging / IIO driver updates for 5.10-rc1	2020-10-15 09:46:23 -07:00
ralink-gdma	staging: ralink-gdma: fix kconfig dependency bug for DMA_RALINK	2020-11-06 11:12:49 +01:00
rtl8188eu	staging: rtl8188eu: Add Edimax EW-7811UN V2 to device table	2021-03-04 11:38:33 +01:00
rtl8192e	mm: remove kzfree() compatibility definition	2020-10-25 11:39:02 -07:00
rtl8192u	mm: remove kzfree() compatibility definition	2020-10-25 11:39:02 -07:00
rtl8712	staging: rtl8712: Fix enqueue_reorder_recvframe()	2020-10-01 10:55:17 +02:00
rtl8723bs	staging: rtl8723bs: wifi_regd.c: Fix incorrect number of regulatory rules	2021-03-04 11:37:26 +01:00
rts5208
sm750fb
unisys
vc04_services	staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()	2021-03-07 12:34:10 +01:00
vme
vt6655
vt6656
wfx	staging: wfx: fix possible panic with re-queued frames	2021-03-04 11:37:28 +01:00
wlan-ng	staging: wlan-ng: convert tasklets to use new tasklet_setup() API	2020-09-16 13:13:00 +02:00
Kconfig
Makefile