linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00

Linux kernel source tree

Go to file

Tung Nguyen 2de76d37d4 tipc: fix kernel panic when enabling bearer [ Upstream commit `be4977b847` ] When enabling a bearer on a node, a kernel panic is observed: [ 4.498085] RIP: 0010:tipc_mon_prep+0x4e/0x130 [tipc] ... [ 4.520030] Call Trace: [ 4.520689] <IRQ> [ 4.521236] tipc_link_build_proto_msg+0x375/0x750 [tipc] [ 4.522654] tipc_link_build_state_msg+0x48/0xc0 [tipc] [ 4.524034] __tipc_node_link_up+0xd7/0x290 [tipc] [ 4.525292] tipc_rcv+0x5da/0x730 [tipc] [ 4.526346] ? __netif_receive_skb_core+0xb7/0xfc0 [ 4.527601] tipc_l2_rcv_msg+0x5e/0x90 [tipc] [ 4.528737] __netif_receive_skb_list_core+0x20b/0x260 [ 4.530068] netif_receive_skb_list_internal+0x1bf/0x2e0 [ 4.531450] ? dev_gro_receive+0x4c2/0x680 [ 4.532512] napi_complete_done+0x6f/0x180 [ 4.533570] virtnet_poll+0x29c/0x42e [virtio_net] ... The node in question is receiving activate messages in another thread after changing bearer status to allow message sending/ receiving in current thread: thread 1 \| thread 2 -------- \| -------- \| tipc_enable_bearer() \| test_and_set_bit_lock() \| tipc_bearer_xmit_skb() \| \| tipc_l2_rcv_msg() \| tipc_rcv() \| __tipc_node_link_up() \| tipc_link_build_state_msg() \| tipc_link_build_proto_msg() \| tipc_mon_prep() \| { \| ... \| // null-pointer dereference \| u16 gen = mon->dom_gen; \| ... \| } // Not being executed yet \| tipc_mon_create() \| { \| ... \| // allocate \| mon = kzalloc(); \| ... \| } \| Monitoring pointer in thread 2 is dereferenced before monitoring data is allocated in thread 1. This causes kernel panic. This commit fixes it by allocating the monitoring data before enabling the bearer to receive messages. Fixes: `35c55c9877` ("tipc: add neighbor monitoring framework") Reported-by: Shuang Li <shuali@redhat.com> Acked-by: Jon Maloy <jmaloy@redhat.com> Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-16 14:15:56 +01:00
arch	arm64: dts: armada-3720-turris-mox: Add missing ethernet0 alias	2022-03-16 14:15:56 +01:00
block	block/wbt: fix negative inflight counter when remove scsi device	2022-02-23 12:01:04 +01:00
certs	certs: Trigger creation of RSA module signing key if it's not an RSA key	2021-09-15 09:50:29 +02:00
crypto	crypto: api - Move cryptomgr soft dependency into algapi	2022-02-11 09:09:03 +01:00
Documentation	arm64: cpufeature: add HWCAP for FEAT_RPRES	2022-03-11 12:11:51 +01:00
drivers	HID: vivaldi: fix sysfs attributes leak	2022-03-16 14:15:56 +01:00
fs	btrfs: add missing run of delayed items after unlink during log replay	2022-03-08 19:09:38 +01:00
include	xen/gnttab: fix gnttab_end_foreign_access() without page specified	2022-03-11 12:11:54 +01:00
init	bpf: Add kconfig knob for disabling unpriv bpf by default	2022-01-05 12:40:34 +01:00
ipc	shm: extend forced shm destroy to support objects from several IPC nses	2021-12-01 09:19:10 +01:00
kernel	x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting	2022-03-11 12:11:49 +01:00
lib	lib/iov_iter: initialize "flags" in new pipe_buffer	2022-02-23 12:01:06 +01:00
LICENSES	LICENSES/deprecated: add Zlib license text	2020-09-16 14:33:49 +02:00
mm	memfd: fix F_SEAL_WRITE after shmem huge page allocated	2022-03-08 19:09:36 +01:00
net	tipc: fix kernel panic when enabling bearer	2022-03-16 14:15:56 +01:00
samples	ftrace/samples: Add missing prototypes direct functions	2022-01-11 15:25:00 +01:00
scripts	kconfig: fix failing to generate auto.conf	2022-02-23 12:01:07 +01:00
security	ima: Do not print policy rule with inactive LSM labels	2022-02-16 12:54:16 +01:00
sound	ASoC: cs4265: Fix the duplicated control name	2022-03-08 19:09:35 +01:00
tools	x86/speculation: Rename RETPOLINE_AMD to RETPOLINE_LFENCE	2022-03-11 12:11:49 +01:00
usr	usr/include/Makefile: add linux/nfc.h to the compile-test coverage	2022-02-01 17:25:48 +01:00
virt	KVM: eventfd: Fix false positive RCU usage warning	2022-02-16 12:54:20 +01:00
.clang-format	RDMA 5.10 pull request	2020-10-17 11:18:18 -07:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore	kbuild: generate Module.symvers only when vmlinux exists	2021-05-19 10:12:59 +02:00
.mailmap	mailmap: add two more addresses of Uwe Kleine-König	2020-12-06 10:19:07 -08:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Jason Cooper to CREDITS	2020-11-30 10:20:34 +01:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: adjust GCC PLUGINS after gcc-plugin.sh removal	2021-12-14 11:32:46 +01:00
Makefile	Linux 5.10.105	2022-03-11 12:11:55 +01:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.