zhenwei pi 5df14bba00 crypto: public_key: fix overflow during implicit conversion ... commit f985911b7b upstream. Hit kernel warning like this, it can be reproduced by verifying 256 bytes datafile by keyctl command, run script: RAWDATA=rawdata SIGDATA=sigdata modprobe pkcs8_key_parser rm -rf *.der *.pem *.pfx rm -rf $RAWDATA dd if=/dev/random of=$RAWDATA bs=256 count=1 openssl req -nodes -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem \ -subj "/C=CN/ST=GD/L=SZ/O=vihoo/OU=dev/CN=xx.com/emailAddress=yy@xx.com" KEY_ID=`openssl pkcs8 -in key.pem -topk8 -nocrypt -outform DER | keyctl \ padd asymmetric 123 @s` keyctl pkey_sign $KEY_ID 0 $RAWDATA enc=pkcs1 hash=sha1 > $SIGDATA keyctl pkey_verify $KEY_ID 0 $RAWDATA $SIGDATA enc=pkcs1 hash=sha1 Then the kernel reports: WARNING: CPU: 5 PID: 344556 at crypto/rsa-pkcs1pad.c:540 pkcs1pad_verify+0x160/0x190 ... Call Trace: public_key_verify_signature+0x282/0x380 ? software_key_query+0x12d/0x180 ? keyctl_pkey_params_get+0xd6/0x130 asymmetric_key_verify_signature+0x66/0x80 keyctl_pkey_verify+0xa5/0x100 do_syscall_64+0x35/0xb0 entry_SYSCALL_64_after_hwframe+0x44/0xae The reason of this issue, in function 'asymmetric_key_verify_signature': '.digest_size(u8) = params->in_len(u32)' leads overflow of an u8 value, so use u32 instead of u8 for digest_size field. And reorder struct public_key_signature, it saves 8 bytes on a 64-bit machine. Cc: stable@vger.kernel.org Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-09-18 13:40:08 +02:00
..
internal	crypto: shash - avoid comparing pointers to exported functions under CFI	2021-07-14 16:55:54 +02:00
acompress.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
aead.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
aes.h
akcipher.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
algapi.h	crypto: algapi - Remove skbuff.h inclusion	2020-08-20 14:04:28 +10:00
arc4.h
asym_tpm_subtype.h
authenc.h
b128ops.h
blake2s.h
blowfish.h
cast_common.h
cast5.h
cast6.h
chacha.h	random: initialize ChaCha20 constants with correct endianness	2021-05-11 14:47:19 +02:00
chacha20poly1305.h	crypto: lib/chacha20poly1305 - Add missing function declaration	2020-07-16 21:49:04 +10:00
cryptd.h
ctr.h
curve25519.h
des.h
dh.h
drbg.h	crypto: drbg - always seeded with SP800-90B compliant noise source	2020-04-24 17:42:17 +10:00
ecdh.h
engine.h	crypto: engine - support for batch requests	2020-05-08 15:30:40 +10:00
gcm.h
gf128mul.h	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
ghash.h
hash_info.h
hash.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
hmac.h
if_alg.h	crypto: af_alg - add extra parameters for DRBG interface	2020-09-25 17:48:52 +10:00
kpp.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
md5.h
nhpoly1305.h
null.h
padlock.h
pcrypt.h
pkcs7.h
poly1305.h	crypto: poly1305 - fix poly1305_core_setkey() declaration	2021-05-14 09:50:13 +02:00
public_key.h	crypto: public_key: fix overflow during implicit conversion	2021-09-18 13:40:08 +02:00
rng.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
scatterwalk.h
serpent.h
sha.h	crypto: lib/sha256 - add sha256() function	2020-07-16 21:49:05 +10:00
sha1_base.h
sha3.h
sha256_base.h	crypto: lib/sha256 - return void	2020-05-08 15:32:12 +10:00
sha512_base.h
skcipher.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:47:16 +02:00
sm2.h	crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm	2020-09-25 17:48:54 +10:00
sm3_base.h
sm3.h	crypto: sm3 - export crypto_sm3_final function	2020-09-25 17:48:53 +10:00
sm4.h
streebog.h
twofish.h
xts.h