Sergio Correia 23a336b342 drm: set is_master to 0 upon drm_new_set_master() failure ... When drm_new_set_master() fails, set is_master to 0, to prevent a possible NULL pointer deref. Here is a problematic flow: we check is_master in drm_is_current_master(), then proceed to call drm_lease_owner() passing master. If we do not restore is_master status when drm_new_set_master() fails, we may have a situation in which is_master will be 1 and master itself, NULL, leading to the deref of a NULL pointer in drm_lease_owner(). This fixes the following OOPS, observed on an ArchLinux running a 4.19.2 kernel: [ 97.804282] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 [ 97.807224] PGD 0 P4D 0 [ 97.807224] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 97.807224] CPU: 0 PID: 1348 Comm: xfwm4 Tainted: P OE 4.19.2-arch1-1-ARCH #1 [ 97.807224] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./AB350 Pro4, BIOS P5.10 10/16/2018 [ 97.807224] RIP: 0010:drm_lease_owner+0xd/0x20 [drm] [ 97.807224] Code: 83 c4 18 5b 5d c3 b8 ea ff ff ff eb e2 b8 ed ff ff ff eb db e8 b4 ca 68 fb 0f 1f 40 00 0f 1f 44 00 00 48 89 f8 eb 03 48 89 d0 <48> 8b 90 80 00 00 00 48 85 d2 75 f1 c3 66 0f 1f 44 00 00 0f 1f 44 [ 97.807224] RSP: 0018:ffffb8cf08e07bb0 EFLAGS: 00010202 [ 97.807224] RAX: 0000000000000000 RBX: ffff9cf0f2586c00 RCX: ffff9cf0f2586c88 [ 97.807224] RDX: ffff9cf0ddbd8000 RSI: 0000000000000000 RDI: 0000000000000000 [ 97.807224] RBP: ffff9cf1040e9800 R08: 0000000000000000 R09: 0000000000000000 [ 97.807224] R10: ffffdeb30fd5d680 R11: ffffdeb30f5d6808 R12: ffff9cf1040e9888 [ 97.807224] R13: 0000000000000000 R14: dead000000000200 R15: ffff9cf0f2586cc8 [ 97.807224] FS: 00007f4145513180(0000) GS:ffff9cf10ea00000(0000) knlGS:0000000000000000 [ 97.807224] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 97.807224] CR2: 0000000000000080 CR3: 00000003d7548000 CR4: 00000000003406f0 [ 97.807224] Call Trace: [ 97.807224] drm_is_current_master+0x1a/0x30 [drm] [ 97.807224] drm_master_release+0x3e/0x130 [drm] [ 97.807224] drm_file_free.part.0+0x2be/0x2d0 [drm] [ 97.807224] drm_open+0x1ba/0x1e0 [drm] [ 97.807224] drm_stub_open+0xaf/0xe0 [drm] [ 97.807224] chrdev_open+0xa3/0x1b0 [ 97.807224] ? cdev_put.part.0+0x20/0x20 [ 97.807224] do_dentry_open+0x132/0x340 [ 97.807224] path_openat+0x2d1/0x14e0 [ 97.807224] ? mem_cgroup_commit_charge+0x7a/0x520 [ 97.807224] do_filp_open+0x93/0x100 [ 97.807224] ? __check_object_size+0x102/0x189 [ 97.807224] ? _raw_spin_unlock+0x16/0x30 [ 97.807224] do_sys_open+0x186/0x210 [ 97.807224] do_syscall_64+0x5b/0x170 [ 97.807224] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 97.807224] RIP: 0033:0x7f4147b07976 [ 97.807224] Code: 89 54 24 08 e8 7b f4 ff ff 8b 74 24 0c 48 8b 3c 24 41 89 c0 44 8b 54 24 08 b8 01 01 00 00 89 f2 48 89 fe bf 9c ff ff ff 0f 05 <48> 3d 00 f0 ff ff 77 30 44 89 c7 89 44 24 08 e8 a6 f4 ff ff 8b 44 [ 97.807224] RSP: 002b:00007ffcced96ca0 EFLAGS: 00000293 ORIG_RAX: 0000000000000101 [ 97.807224] RAX: ffffffffffffffda RBX: 00005619d5037f80 RCX: 00007f4147b07976 [ 97.807224] RDX: 0000000000000002 RSI: 00005619d46b969c RDI: 00000000ffffff9c [ 98.040039] RBP: 0000000000000024 R08: 0000000000000000 R09: 0000000000000000 [ 98.040039] R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000024 [ 98.040039] R13: 0000000000000012 R14: 00005619d5035950 R15: 0000000000000012 [ 98.040039] Modules linked in: nct6775 hwmon_vid algif_skcipher af_alg nls_iso8859_1 nls_cp437 vfat fat uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common arc4 videodev media snd_usb_audio snd_hda_codec_hdmi snd_usbmidi_lib snd_rawmidi snd_seq_device mousedev input_leds iwlmvm mac80211 snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec edac_mce_amd kvm_amd snd_hda_core kvm iwlwifi snd_hwdep r8169 wmi_bmof cfg80211 snd_pcm irqbypass snd_timer snd libphy soundcore pinctrl_amd rfkill pcspkr sp5100_tco evdev gpio_amdpt k10temp mac_hid i2c_piix4 wmi pcc_cpufreq acpi_cpufreq vboxnetflt(OE) vboxnetadp(OE) vboxpci(OE) vboxdrv(OE) msr sg crypto_user ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2 fscrypto uas usb_storage dm_crypt hid_generic usbhid hid [ 98.040039] dm_mod raid1 md_mod sd_mod crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel pcbc ahci libahci aesni_intel aes_x86_64 libata crypto_simd cryptd glue_helper ccp xhci_pci rng_core scsi_mod xhci_hcd nvidia_drm(POE) drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm agpgart nvidia_uvm(POE) nvidia_modeset(POE) nvidia(POE) ipmi_devintf ipmi_msghandler [ 98.040039] CR2: 0000000000000080 [ 98.040039] ---[ end trace 3b65093b6fe62b2f ]--- [ 98.040039] RIP: 0010:drm_lease_owner+0xd/0x20 [drm] [ 98.040039] Code: 83 c4 18 5b 5d c3 b8 ea ff ff ff eb e2 b8 ed ff ff ff eb db e8 b4 ca 68 fb 0f 1f 40 00 0f 1f 44 00 00 48 89 f8 eb 03 48 89 d0 <48> 8b 90 80 00 00 00 48 85 d2 75 f1 c3 66 0f 1f 44 00 00 0f 1f 44 [ 98.040039] RSP: 0018:ffffb8cf08e07bb0 EFLAGS: 00010202 [ 98.040039] RAX: 0000000000000000 RBX: ffff9cf0f2586c00 RCX: ffff9cf0f2586c88 [ 98.040039] RDX: ffff9cf0ddbd8000 RSI: 0000000000000000 RDI: 0000000000000000 [ 98.040039] RBP: ffff9cf1040e9800 R08: 0000000000000000 R09: 0000000000000000 [ 98.040039] R10: ffffdeb30fd5d680 R11: ffffdeb30f5d6808 R12: ffff9cf1040e9888 [ 98.040039] R13: 0000000000000000 R14: dead000000000200 R15: ffff9cf0f2586cc8 [ 98.040039] FS: 00007f4145513180(0000) GS:ffff9cf10ea00000(0000) knlGS:0000000000000000 [ 98.040039] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 98.040039] CR2: 0000000000000080 CR3: 00000003d7548000 CR4: 00000000003406f0 Signed-off-by: Sergio Correia <sergio@correia.cc> Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181122053329.2692-1-sergio@correia.cc Signed-off-by: Sean Paul <seanpaul@chromium.org>		2018-11-26 16:14:27 -05:00
..
accessibility
acpi	ACPI / platform: Add SMB0001 HID to forbidden_id_list	2018-11-21 13:30:13 +01:00
amba
android
ata	libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD	2018-11-12 12:44:19 -07:00
atm	atm: zatm: Fix empty body Clang warnings	2018-10-18 15:39:10 -07:00
auxdisplay	The Compiler Attributes series	2018-11-01 18:34:46 -07:00
base	mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock	2018-10-31 08:54:17 -07:00
bcma
block	for-linus-20181115	2018-11-16 09:31:59 -06:00
bluetooth	Merge branch 'work.tty-ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-10-24 14:43:41 +01:00
bus	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
cdrom	gdrom: fix mistake in assignment of error	2018-10-25 11:17:40 -06:00
char	RTC for 4.20	2018-10-27 09:24:24 -07:00
clk	clk: qcom: gcc: Fix board clock node name	2018-11-09 14:13:55 -08:00
clocksource	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-11 16:41:50 -06:00
connector
cpufreq	cpufreq: ti-cpufreq: Only register platform_device when supported	2018-11-19 11:26:06 +01:00
cpuidle	ARM: cpuidle: Convert to use cpuidle_register|unregister()	2018-11-08 18:53:00 +01:00
crypto	crypto: hisilicon - Fix reference after free of memories on error path	2018-11-09 17:35:43 +08:00
dax
dca
devfreq
dio
dma	pci-v4.20-changes	2018-10-25 06:50:48 -07:00
dma-buf	udmabuf: set read/write flag when exporting	2018-11-16 08:50:53 +01:00
edac	* skx_edac: Address translation for NVDIMMs (Tony Luck and Qiuxu Zhuo)	2018-11-02 11:17:22 -07:00
eisa
extcon
firewire
firmware	efi: Permit calling efi_mem_reserve_persistent() from atomic context	2018-11-15 10:04:47 +01:00
fmc
fpga	fpga: add devm_fpga_region_create	2018-10-16 11:13:50 +02:00
fsi	iov_iter: Separate type from direction and use accessor functions	2018-10-24 00:41:07 +01:00
gnss	gnss: sirf: fix synchronous write timeout	2018-11-14 20:37:41 +01:00
gpio	gpio: mockup: fix indicated direction	2018-11-16 23:06:29 +01:00
gpu	drm: set is_master to 0 upon drm_new_set_master() failure	2018-11-26 16:14:27 -05:00
hid	Revert "HID: input: Create a utility class for counting scroll events"	2018-11-22 08:57:38 +01:00
hsi
hv	Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up	2018-11-11 09:00:20 -08:00
hwmon	hwmon: (ibmpowernv) Remove bogus __init annotations	2018-11-04 15:55:12 -08:00
hwspinlock
hwtracing	stm class: Use memcat_p()	2018-10-11 12:12:55 +02:00
i2c	i2c: nvidia-gpu: make pm_ops static	2018-11-09 17:56:44 +01:00
ide
idle	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
iio	Staging/IIO patches for 4.20-rc1	2018-10-29 10:38:10 -07:00
infiniband	Revert "mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks"	2018-10-26 16:25:19 -07:00
input	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
iommu	iommu/vt-d: Use memunmap to free memremap	2018-11-22 17:02:21 +01:00
ipack
irqchip	irqchip/irq-mvebu-sei: Fix a NULL vs IS_ERR() bug in probe function	2018-11-01 12:38:48 +01:00
isdn	Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-11-01 19:58:52 -07:00
leds	LED fixes for 4.20-rc2	2018-11-08 17:49:04 -06:00
lightnvm	lightnvm: pblk: guarantee that backpointer is respected on writer stall	2018-10-09 08:25:08 -06:00
macintosh	memblock: stop using implicit alignment to SMP_CACHE_BYTES	2018-10-31 08:54:16 -07:00
mailbox	- Convert print users to use the %pOFn format specifier	2018-10-29 10:30:44 -07:00
mcb
md	for-linus-20181102	2018-11-02 11:25:48 -07:00
media	media: ipu3-cio2: Use cio2_queues_exit	2018-11-06 07:11:59 -05:00
memory
memstick
message
mfd	chrome-platform for v4.20	2018-10-31 16:47:55 -07:00
misc	misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data	2018-11-11 09:13:19 -08:00
mmc	mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value	2018-11-19 14:11:07 +01:00
mtd	mtd: spi-nor: fix selection of uniform erase type in flexible conf	2018-11-20 14:26:59 +01:00
mux	This is the bulk of GPIO changes for the v4.20 series:	2018-10-23 08:45:05 +01:00
net	net: gemini: Fix copy/paste error	2018-11-23 22:35:38 -08:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-10-23 13:28:53 -05:00
ntb	ntb: idt: Alter the driver info comments	2018-11-01 10:33:12 -04:00
nubus
nvdimm	libnvdimm for 4.20	2018-10-25 06:31:56 -07:00
nvme	nvme-fc: resolve io failures during connect	2018-11-15 11:37:55 +01:00
nvmem	nvmem: core: fix regression in of_nvmem_cell_get()	2018-11-11 09:15:29 -08:00
of	Devicetree fixes for 4.20-rc:	2018-11-09 16:41:58 -06:00
opp	opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call	2018-11-13 09:40:29 +05:30
oprofile
parisc	parisc: Add alternative coding infrastructure	2018-10-17 17:22:26 +02:00
parport
pci	Revert "ACPI/PCI: Pay attention to device-specific _PXM node values"	2018-11-13 08:38:17 -06:00
pcmcia	powerpc updates for 4.20	2018-10-26 14:36:21 -07:00
perf	arm64 updates for 4.20:	2018-10-22 17:30:06 +01:00
phy	USB/PHY patches for 4.20-rc1	2018-10-26 08:14:13 -07:00
pinctrl	pinctrl: meson: fix meson8b ao pull register bits	2018-11-05 09:33:22 +01:00
platform	platform-drivers-x86 for v4.20-1	2018-11-01 08:42:21 -07:00
pnp
power	Devicetree updates for 4.20:	2018-10-26 12:09:58 -07:00
powercap	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
pps
ps3
ptp	ptp: drop redundant kasprintf() to create worker name	2018-10-28 19:20:06 -07:00
pwm	pwm: lpss: Only set update bit if we are actually changing the settings	2018-10-16 13:16:15 +02:00
rapidio
ras
regulator	regulator: Regulator updates for next release	2018-10-23 01:54:44 +01:00
remoteproc	remoteproc: qcom: q6v5-mss: Register segments/dumpfn for coredump	2018-10-19 12:54:03 -07:00
reset	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
rpmsg
rtc	rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write	2018-11-07 17:13:56 +01:00
s390	s390/ism: clear dmbe_mask bit before SMC IRQ handling	2018-11-14 14:21:20 -08:00
sbus
scsi	SCSI fixes on 20181121	2018-11-22 08:31:46 -08:00
sfi	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
sh
siox
slimbus	slimbus: ngd: remove unnecessary check	2018-11-07 14:59:28 +01:00
sn
soc	soc: ti: QMSS: Fix usage of irq_set_affinity_hint	2018-11-02 11:22:09 -07:00
soundwire
spi	- New Drivers	2018-10-25 06:19:15 -07:00
spmi
ssb
staging	media: dm365_ipipeif: better annotate a fall though	2018-11-06 06:58:07 -05:00
target	scsi: target/core: Avoid that a kernel oops is triggered when COMPARE AND WRITE fails	2018-11-05 22:16:00 -05:00
tc	TC: Set DMA masks for devices	2018-10-11 09:16:44 -07:00
tee
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2018-10-31 11:28:12 -07:00
thunderbolt
tty	TTY/Serial fixes for 4.20-rc2	2018-11-10 13:32:14 -06:00
uio	uio: Fix an Oops on load	2018-11-11 09:21:46 -08:00
usb	USB fixes for 4.20-rc4	2018-11-22 08:39:29 -08:00
uwb
vfio	VFIO updates for v4.20	2018-10-31 11:01:38 -07:00
vhost	virtio, vhost: fixes, tweaks	2018-11-01 14:42:49 -07:00
video	fbdev changes for v4.20:	2018-10-31 11:41:37 -07:00
virt
virtio	virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON	2018-10-24 20:57:55 -04:00
visorbus
vlynq
vme
w1	w1: IAD Register is yet readable trough iad sys file. Fix snprintf (%u for unsigned, count for max size).	2018-10-15 20:50:32 +02:00
watchdog	watchdog: ts4800: release syscon device node in ts4800_wdt_probe()	2018-10-22 10:16:28 +02:00
xen	xen: fixes for 4.20-rc2	2018-11-10 08:58:48 -06:00
zorro
Kconfig
Makefile