Filipe Manana 212a58fda9 btrfs: fix warning when freeing leaf after subvolume creation failure ... When creating a subvolume, at ioctl.c:create_subvol(), if we fail to insert the root item for the new subvolume into the root tree, we can trigger the following warning: [78961.741046] WARNING: CPU: 0 PID: 4079814 at fs/btrfs/extent-tree.c:3357 btrfs_free_tree_block+0x2af/0x310 [btrfs] [78961.743344] Modules linked in: [78961.749440] dm_snapshot dm_thin_pool (...) [78961.773648] CPU: 0 PID: 4079814 Comm: fsstress Not tainted 5.16.0-rc4-btrfs-next-108 #1 [78961.775198] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 [78961.777266] RIP: 0010:btrfs_free_tree_block+0x2af/0x310 [btrfs] [78961.778398] Code: 17 00 48 85 (...) [78961.781067] RSP: 0018:ffffaa4001657b28 EFLAGS: 00010202 [78961.781877] RAX: 0000000000000213 RBX: ffff897f8a796910 RCX: 0000000000000000 [78961.782780] RDX: 0000000000000000 RSI: 0000000011004000 RDI: 00000000ffffffff [78961.783764] RBP: ffff8981f490e800 R08: 0000000000000001 R09: 0000000000000000 [78961.784740] R10: 0000000000000000 R11: 0000000000000001 R12: ffff897fc963fcc8 [78961.785665] R13: 0000000000000001 R14: ffff898063548000 R15: ffff898063548000 [78961.786620] FS: 00007f31283c6b80(0000) GS:ffff8982ace00000(0000) knlGS:0000000000000000 [78961.787717] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [78961.788598] CR2: 00007f31285c3000 CR3: 000000023fcc8003 CR4: 0000000000370ef0 [78961.789568] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [78961.790585] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [78961.791684] Call Trace: [78961.792082] <TASK> [78961.792359] create_subvol+0x5d1/0x9a0 [btrfs] [78961.793054] btrfs_mksubvol+0x447/0x4c0 [btrfs] [78961.794009] ? preempt_count_add+0x49/0xa0 [78961.794705] __btrfs_ioctl_snap_create+0x123/0x190 [btrfs] [78961.795712] ? _copy_from_user+0x66/0xa0 [78961.796382] btrfs_ioctl_snap_create_v2+0xbb/0x140 [btrfs] [78961.797392] btrfs_ioctl+0xd1e/0x35c0 [btrfs] [78961.798172] ? __slab_free+0x10a/0x360 [78961.798820] ? rcu_read_lock_sched_held+0x12/0x60 [78961.799664] ? lock_release+0x223/0x4a0 [78961.800321] ? lock_acquired+0x19f/0x420 [78961.800992] ? rcu_read_lock_sched_held+0x12/0x60 [78961.801796] ? trace_hardirqs_on+0x1b/0xe0 [78961.802495] ? _raw_spin_unlock_irqrestore+0x3e/0x60 [78961.803358] ? kmem_cache_free+0x321/0x3c0 [78961.804071] ? __x64_sys_ioctl+0x83/0xb0 [78961.804711] __x64_sys_ioctl+0x83/0xb0 [78961.805348] do_syscall_64+0x3b/0xc0 [78961.805969] entry_SYSCALL_64_after_hwframe+0x44/0xae [78961.806830] RIP: 0033:0x7f31284bc957 [78961.807517] Code: 3c 1c 48 f7 d8 (...) This is because we are calling btrfs_free_tree_block() on an extent buffer that is dirty. Fix that by cleaning the extent buffer, with btrfs_clean_tree_block(), before freeing it. This was triggered by test case generic/475 from fstests. Fixes: 67addf2900 ("btrfs: fix metadata extent leak after failure to create subvolume") CC: stable@vger.kernel.org # 4.4+ Reviewed-by: Nikolay Borisov <nborisov@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2021-12-15 17:07:33 +01:00
..
tests	btrfs: subpage: avoid potential deadlock with compression and delalloc	2021-10-26 19:08:05 +02:00
acl.c	overlayfs update for 5.15	2021-09-02 09:21:27 -07:00
async-thread.c	btrfs: fix memory ordering between normal and ordered work functions	2021-11-16 16:50:23 +01:00
async-thread.h	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
backref.c	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
backref.h	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
block-group.c	btrfs: update comments for chunk allocation -ENOSPC cases	2021-10-26 19:08:07 +02:00
block-group.h	btrfs: fix deadlock between chunk allocation and chunk btree modifications	2021-10-26 19:08:07 +02:00
block-rsv.c	btrfs: introduce mount option rescue=ignorebadroots	2020-12-08 15:53:41 +01:00
block-rsv.h	btrfs: Remove __ prefix from btrfs_block_rsv_release	2020-03-23 17:01:55 +01:00
btrfs_inode.h	btrfs: rename btrfs_dio_private::logical_offset to file_offset	2021-10-26 19:08:06 +02:00
check-integrity.c	btrfs: check-integrity: stop storing the block device name in btrfsic_dev_state	2021-10-26 19:08:07 +02:00
check-integrity.h	btrfs: remove btrfsic_submit_bh()	2020-03-23 17:01:39 +01:00
compression.c	btrfs: subpage: make end_compressed_bio_writeback() compatible	2021-10-26 19:08:04 +02:00
compression.h	btrfs: determine stripe boundary at bio allocation time in btrfs_submit_compressed_write	2021-10-26 19:08:04 +02:00
ctree.c	btrfs: fix invalid delayed ref after subvolume creation failure	2021-12-15 17:07:33 +01:00
ctree.h	btrfs: fix invalid delayed ref after subvolume creation failure	2021-12-15 17:07:33 +01:00
delalloc-space.c	btrfs: free exchange changeset on failures	2021-12-08 15:42:32 +01:00
delalloc-space.h	btrfs: make btrfs_delalloc_reserve_space take btrfs_inode	2020-07-27 12:55:36 +02:00
delayed-inode.c	btrfs: loop only once over data sizes array when inserting an item batch	2021-10-26 19:08:03 +02:00
delayed-inode.h	btrfs: make btrfs_delayed_update_inode take btrfs_inode	2020-12-08 15:54:10 +01:00
delayed-ref.c	btrfs: pull up qgroup checks from delayed-ref core to init time	2021-10-26 19:08:06 +02:00
delayed-ref.h	btrfs: make btrfs_ref::real_root optional	2021-10-26 19:08:06 +02:00
dev-replace.c	btrfs: handle device lookup with btrfs_dev_lookup_args	2021-10-26 19:08:07 +02:00
dev-replace.h	btrfs: zoned: mark block groups to copy for device-replace	2021-02-09 02:46:07 +01:00
dir-item.c	btrfs: unify lookup return value when dir entry is missing	2021-10-07 22:06:32 +02:00
discard.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
discard.h	btrfs: cleanup btrfs_discard_update_discardable usage	2020-12-08 15:54:02 +01:00
disk-io.c	btrfs: fix double free of anon_dev after failure to create subvolume	2021-12-14 15:52:04 +01:00
disk-io.h	btrfs: make btrfs_super_block size match BTRFS_SUPER_INFO_SIZE	2021-10-26 19:08:07 +02:00
export.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
export.h	btrfs: export helpers for subvolume name/id resolution	2020-03-23 17:01:42 +01:00
extent_io.c	btrfs: check WRITE_ERR when trying to read an extent buffer	2021-12-15 17:07:31 +01:00
extent_io.h	btrfs: cleanup for extent_write_locked_range()	2021-10-26 19:08:04 +02:00
extent_map.c	btrfs: rename btrfs_bio to btrfs_io_context	2021-10-26 19:08:02 +02:00
extent_map.h
extent-io-tree.h	btrfs: use fixed width int type for extent_state::state	2020-12-08 15:54:13 +01:00
extent-tree.c	btrfs: fix invalid delayed ref after subvolume creation failure	2021-12-15 17:07:33 +01:00
file-item.c	btrfs: use bvec_kmap_local in btrfs_csum_one_bio	2021-10-26 19:08:06 +02:00
file.c	btrfs: add additional parameters to btrfs_init_tree_ref/btrfs_init_data_ref	2021-10-26 19:08:06 +02:00
free-space-cache.c	btrfs: subpage: add bitmap for PageChecked flag	2021-10-26 19:08:03 +02:00
free-space-cache.h	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
free-space-tree.c	btrfs: fix invalid delayed ref after subvolume creation failure	2021-12-15 17:07:33 +01:00
free-space-tree.h
inode-item.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
inode.c	btrfs: remove root argument from btrfs_unlink_inode()	2021-10-29 12:39:13 +02:00
ioctl.c	btrfs: fix warning when freeing leaf after subvolume creation failure	2021-12-15 17:07:33 +01:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-06-22 14:11:57 +02:00
locking.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
locking.h	btrfs: assert that extent buffers are write locked instead of only locked	2021-10-26 19:08:02 +02:00
lzo.c	btrfs: fix the memory leak caused in lzo_compress_pages()	2021-11-26 16:10:05 +01:00
Makefile	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
misc.h	btrfs: use correct header for div_u64 in misc.h	2021-09-07 14:29:50 +02:00
ordered-data.c	btrfs: zoned: fix double counting of split ordered extent	2021-09-07 14:30:41 +02:00
ordered-data.h	btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending	2021-08-23 13:19:02 +02:00
orphan.c
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
props.c	btrfs: props: change how empty value is interpreted	2021-06-22 14:11:58 +02:00
props.h
qgroup.c	btrfs: fix invalid delayed ref after subvolume creation failure	2021-12-15 17:07:33 +01:00
qgroup.h	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
raid56.c	btrfs: remove btrfs_raid_bio::fs_info member	2021-10-26 19:08:03 +02:00
raid56.h	btrfs: remove btrfs_raid_bio::fs_info member	2021-10-26 19:08:03 +02:00
rcu-string.h	btrfs: rcu-string: Replace zero-length array with flexible-array member	2020-03-23 17:01:53 +01:00
reada.c	btrfs: rename btrfs_bio to btrfs_io_context	2021-10-26 19:08:02 +02:00
ref-verify.c	btrfs: rename root fields in delayed refs structs	2021-10-26 19:08:06 +02:00
ref-verify.h
reflink.c	btrfs: subpage: add bitmap for PageChecked flag	2021-10-26 19:08:03 +02:00
reflink.h	Btrfs: move all reflink implementation code into its own file	2020-03-23 17:01:54 +01:00
relocation.c	btrfs: fix deadlock between chunk allocation and chunk btree modifications	2021-10-26 19:08:07 +02:00
root-tree.c	btrfs: replace the BUG_ON in btrfs_del_root_ref with proper error handling	2021-12-08 15:45:27 +01:00
scrub.c	btrfs: make 1-bit bit-fields of scrub_page unsigned int	2021-11-16 16:51:11 +01:00
send.c	btrfs: send: prepare for v2 protocol	2021-10-29 12:38:43 +02:00
send.h	btrfs: send: prepare for v2 protocol	2021-10-29 12:38:43 +02:00
space-info.c	btrfs: do not infinite loop in data reclaim if we aborted	2021-10-26 19:08:05 +02:00
space-info.h	btrfs: rip out btrfs_space_info::total_bytes_pinned	2021-06-22 14:55:25 +02:00
struct-funcs.c	btrfs: add special case to setget helpers for 64k pages	2021-08-23 13:18:58 +02:00
subpage.c	btrfs: handle page locking in btrfs_page_end_writer_lock with no writers	2021-10-26 19:08:05 +02:00
subpage.h	btrfs: rework page locking in __extent_writepage()	2021-10-26 19:08:05 +02:00
super.c	btrfs: add a BTRFS_FS_ERROR helper	2021-10-26 19:08:05 +02:00
sysfs.c	btrfs: sysfs: convert scnprintf and snprintf to sysfs_emit	2021-10-26 19:08:07 +02:00
sysfs.h	btrfs: split and refactor btrfs_sysfs_remove_devices_dir	2020-10-07 12:12:21 +02:00
transaction.c	btrfs: add a BTRFS_FS_ERROR helper	2021-10-26 19:08:05 +02:00
transaction.h	btrfs: rework chunk allocation to avoid exhaustion of the system chunk array	2021-07-07 17:42:41 +02:00
tree-checker.c	btrfs: add ro compat flags to inodes	2021-08-23 13:19:09 +02:00
tree-checker.h
tree-defrag.c	btrfs: locking: remove all the blocking helpers	2020-12-08 15:54:01 +01:00
tree-log.c	btrfs: fix missing last dir item offset update when logging directory	2021-12-14 15:52:10 +01:00
tree-log.h	btrfs: change error handling for btrfs_delete_*_in_log	2021-10-26 19:08:05 +02:00
tree-mod-log.c	btrfs: fix race when picking most recent mod log operation for an old root	2021-04-20 19:27:17 +02:00
tree-mod-log.h	btrfs: add and use helper to get lowest sequence number for the tree mod log	2021-04-19 17:25:17 +02:00
ulist.c
ulist.h
uuid-tree.c	btrfs: remove unnecessary casts in printk	2020-12-08 15:53:52 +01:00
verity.c	btrfs: fix transaction handle leak after verity rollback failure	2021-09-17 19:29:41 +02:00
volumes.c	btrfs: silence lockdep when reading chunk tree during mount	2021-11-16 16:50:47 +01:00
volumes.h	btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls	2021-10-26 19:08:07 +02:00
xattr.c	btrfs: assert that extent buffers are write locked instead of only locked	2021-10-26 19:08:02 +02:00
xattr.h
zlib.c	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00
zoned.c	btrfs: zoned: clear data relocation bg on zone finish	2021-12-08 15:42:32 +01:00
zoned.h	btrfs: zoned: add a dedicated data relocation block group	2021-10-26 19:08:01 +02:00
zstd.c	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00