linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-08 22:52:35 +02:00

Linux kernel source tree

Go to file

csonsino 202de90df2 Bluetooth: validate BLE connection interval updates [ Upstream commit `c49a8682fc` ] Problem: The Linux Bluetooth stack yields complete control over the BLE connection interval to the remote device. The Linux Bluetooth stack provides access to the BLE connection interval min and max values through /sys/kernel/debug/bluetooth/hci0/ conn_min_interval and /sys/kernel/debug/bluetooth/hci0/conn_max_interval. These values are used for initial BLE connections, but the remote device has the ability to request a connection parameter update. In the event that the remote side requests to change the connection interval, the Linux kernel currently only validates that the desired value is within the acceptable range in the Bluetooth specification (6 - 3200, corresponding to 7.5ms - 4000ms). There is currently no validation that the desired value requested by the remote device is within the min/max limits specified in the conn_min_interval/conn_max_interval configurations. This essentially leads to Linux yielding complete control over the connection interval to the remote device. The proposed patch adds a verification step to the connection parameter update mechanism, ensuring that the desired value is within the min/max bounds of the current connection. If the desired value is outside of the current connection min/max values, then the connection parameter update request is rejected and the negative response is returned to the remote device. Recall that the initial connection is established using the local conn_min_interval/conn_max_interval values, so this allows the Linux administrator to retain control over the BLE connection interval. The one downside that I see is that the current default Linux values for conn_min_interval and conn_max_interval typically correspond to 30ms and 50ms respectively. If this change were accepted, then it is feasible that some devices would no longer be able to negotiate to their desired connection interval values. This might be remedied by setting the default Linux conn_min_interval and conn_max_interval values to the widest supported range (6 - 3200 / 7.5ms - 4000ms). This could lead to the same behavior as the current implementation, where the remote device could request to change the connection interval value to any value that is permitted by the Bluetooth specification, and Linux would accept the desired value. Signed-off-by: Carey Sonsino <csonsino@gmail.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-07-26 09:14:17 +02:00
arch	x86/build: Add 'set -e' to mkcapflags.sh to delete broken capflags.c	2019-07-26 09:14:11 +02:00
block	blk-iolatency: only account submitted bios	2019-07-26 09:14:09 +02:00
certs	export.h: remove VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR()	2018-08-22 23:21:44 +09:00
crypto	crypto: asymmetric_keys - select CRYPTO_HASH where needed	2019-07-26 09:14:13 +02:00
Documentation	x86/atomic: Fix smp_mb__{before,after}_atomic()	2019-07-26 09:14:08 +02:00
drivers	gtp: add missing gtp_encap_disable_sock() in gtp_encap_enable()	2019-07-26 09:14:17 +02:00
firmware	kbuild: remove all dummy assignments to obj-	2017-11-18 11:46:06 +09:00
fs	blkcg, writeback: dead memcgs shouldn't contribute to writeback ownership arbitration	2019-07-26 09:14:08 +02:00
include	rxrpc: Fix oops in tracepoint	2019-07-26 09:14:15 +02:00
init	initramfs: free initrd memory if opening /initrd.image fails	2019-06-15 11:54:01 +02:00
ipc	ipc: prevent lockup on alloc_msg and free_msg	2019-06-15 11:54:00 +02:00
kernel	timer_list: Guard procfs specific code	2019-07-26 09:14:10 +02:00
lib	rslib: Fix handling of of caller provided syndrome	2019-07-26 09:14:12 +02:00
LICENSES	LICENSES: Remove CC-BY-SA-4.0 license text	2018-10-18 11:28:50 +02:00
mm	mm/vmscan.c: prevent useless kswapd loops	2019-07-10 09:53:44 +02:00
net	Bluetooth: validate BLE connection interval updates	2019-07-26 09:14:17 +02:00
samples	samples, bpf: suppress compiler warning	2019-07-14 08:11:04 +02:00
scripts	scripts/decode_stacktrace.sh: prefix addr2line with $CROSS_COMPILE	2019-07-10 09:53:39 +02:00
security	selinux: fix empty write to keycreate file	2019-07-26 09:14:07 +02:00
sound	ASoC: Intel: hdac_hdmi: Set ops to NULL on remove	2019-07-26 09:14:12 +02:00
tools	perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64	2019-07-26 09:14:16 +02:00
usr	initramfs: move gen_initramfs_list.sh from scripts/ to usr/	2018-08-22 23:21:44 +09:00
virt	KVM: arm/arm64: vgic: Fix kvm_device leak in vgic_its_destroy	2019-07-14 08:11:10 +02:00
.clang-format	clang-format: Set IndentWrappedFunctionNames false	2018-08-01 18:38:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes	.gitattributes: set git diff driver for C source code files	2016-10-07 18:46:30 -07:00
.gitignore	Kbuild updates for v4.17 (2nd)	2018-04-15 17:21:30 -07:00
.mailmap	libnvdimm-for-4.19_misc	2018-08-25 18:13:10 -07:00
COPYING	COPYING: use the new text with points to the license files	2018-03-23 12:41:45 -06:00
CREDITS	9p: remove Ron Minnich from MAINTAINERS	2018-08-17 16:20:26 -07:00
Kbuild	Kbuild updates for v4.15	2017-11-17 17:45:29 -08:00
Kconfig	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
MAINTAINERS	platform/x86: Add Intel AtomISP2 dummy / power-management driver	2019-04-20 09:16:02 +02:00
Makefile	Linux 4.19.60	2019-07-21 09:03:18 +02:00
README	Docs: Added a pointer to the formatted docs to README	2018-03-21 09:02:53 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.