linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00

Linux kernel source tree

Go to file

Yufen Yu 1d2310d95f block: only update parent bi_status when bio fail [ Upstream commit `3edf5346e4` ] For multiple split bios, if one of the bio is fail, the whole should return error to application. But we found there is a race between bio_integrity_verify_fn and bio complete, which return io success to application after one of the bio fail. The race as following: split bio(READ) kworker nvme_complete_rq blk_update_request //split error=0 bio_endio bio_integrity_endio queue_work(kintegrityd_wq, &bip->bip_work); bio_integrity_verify_fn bio_endio //split bio __bio_chain_endio if (!parent->bi_status) <interrupt entry> nvme_irq blk_update_request //parent error=7 req_bio_endio bio->bi_status = 7 //parent bio <interrupt exit> parent->bi_status = 0 parent->bi_end_io() // return bi_status=0 The bio has been split as two: split and parent. When split bio completed, it depends on kworker to do endio, while bio_integrity_verify_fn have been interrupted by parent bio complete irq handler. Then, parent bio->bi_status which have been set in irq handler will overwrite by kworker. In fact, even without the above race, we also need to conside the concurrency beteen mulitple split bio complete and update the same parent bi_status. Normally, multiple split bios will be issued to the same hctx and complete from the same irq vector. But if we have updated queue map between multiple split bios, these bios may complete on different hw queue and different irq vector. Then the concurrency update parent bi_status may cause the final status error. Suggested-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Yufen Yu <yuyufen@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/20210331115359.1125679-1-yuyufen@huawei.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-04-16 11:43:21 +02:00
arch	KVM: arm64: Disable guest access to trace filter controls	2021-04-16 11:43:19 +02:00
block	block: only update parent bi_status when bio fail	2021-04-16 11:43:21 +02:00
certs	certs: Fix blacklist flag type confusion	2021-03-04 11:37:59 +01:00
crypto	crypto: mips/poly1305 - enable for all MIPS processors	2021-03-17 17:06:10 +01:00
Documentation	dt-bindings: net: ethernet-controller: fix typo in NVMEM	2021-04-14 08:42:12 +02:00
drivers	gpu: host1x: Use different lock classes for each client	2021-04-16 11:43:20 +02:00
fs	gfs2: report "already frozen/thawed" errors	2021-04-16 11:43:20 +02:00
include	gpu: host1x: Use different lock classes for each client	2021-04-16 11:43:20 +02:00
init	init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM	2021-04-10 13:36:11 +02:00
ipc	ipc: adjust proc_ipc_sem_dointvec definition to match prototype	2020-09-05 12:14:29 -07:00
kernel	ftrace: Check if pages were allocated before calling free_pages()	2021-04-16 11:43:20 +02:00
lib	XArray: Fix splitting to non-zero orders	2021-04-16 11:43:21 +02:00
LICENSES	LICENSES/deprecated: add Zlib license text	2020-09-16 14:33:49 +02:00
mm	percpu: make pcpu_nr_empty_pop_pages per chunk type	2021-04-14 08:42:03 +02:00
net	Revert "net: sched: bump refcount for new action in ACT replace mode"	2021-04-14 08:42:14 +02:00
samples	samples, bpf: Add missing munmap in xdpsock	2021-03-17 17:06:12 +01:00
scripts	kbuild: dummy-tools: fix inverted tests for gcc	2021-03-30 14:31:50 +02:00
security	selinux: fix race between old and new sidtab	2021-04-14 08:41:57 +02:00
sound	ASoC: sunxi: sun4i-codec: fill ASoC card owner	2021-04-14 08:42:08 +02:00
tools	tools/kvm_stat: Add restart delay	2021-04-16 11:43:20 +02:00
usr	Merge branch 'work.fdpic' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-08-07 13:29:39 -07:00
virt	KVM: Use kvm_pfn_t for local PFN variable in hva_to_pfn_remapped()	2021-02-26 10:13:01 +01:00
.clang-format	RDMA 5.10 pull request	2020-10-17 11:18:18 -07:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore	Opt out of scripts/get_maintainer.pl	2019-05-16 10:53:40 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for dts files	2019-12-04 19:44:11 -08:00
.gitignore	.gitignore: docs: ignore sphinx_*/ directories	2020-09-10 10:44:31 -06:00
.mailmap	mailmap: add two more addresses of Uwe Kleine-König	2020-12-06 10:19:07 -08:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Jason Cooper to CREDITS	2020-11-30 10:20:34 +01:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: move the staging subsystem to lists.linux.dev	2021-03-25 09:04:18 +01:00
Makefile	Linux 5.10.30	2021-04-14 08:42:14 +02:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.