Ming Lei 39f603a262 lib/group_cpus.c: avoid acquiring cpu hotplug lock in group_cpus_evenly ... commit 0263f92fad upstream. group_cpus_evenly() could be part of storage driver's error handler, such as nvme driver, when may happen during CPU hotplug, in which storage queue has to drain its pending IOs because all CPUs associated with the queue are offline and the queue is becoming inactive. And handling IO needs error handler to provide forward progress. Then deadlock is caused: 1) inside CPU hotplug handler, CPU hotplug lock is held, and blk-mq's handler is waiting for inflight IO 2) error handler is waiting for CPU hotplug lock 3) inflight IO can't be completed in blk-mq's CPU hotplug handler because error handling can't provide forward progress. Solve the deadlock by not holding CPU hotplug lock in group_cpus_evenly(), in which two stage spreads are taken: 1) the 1st stage is over all present CPUs; 2) the end stage is over all other CPUs. Turns out the two stage spread just needs consistent 'cpu_present_mask', and remove the CPU hotplug lock by storing it into one local cache. This way doesn't change correctness, because all CPUs are still covered. Link: https://lkml.kernel.org/r/20231120083559.285174-1-ming.lei@redhat.com Signed-off-by: Ming Lei <ming.lei@redhat.com> Reported-by: Yi Zhang <yi.zhang@redhat.com> Reported-by: Guangwu Zhang <guazhang@redhat.com> Tested-by: Guangwu Zhang <guazhang@redhat.com> Reviewed-by: Chengming Zhou <zhouchengming@bytedance.com> Reviewed-by: Jens Axboe <axboe@kernel.dk> Cc: Keith Busch <kbusch@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-12-13 18:45:22 +01:00
..
842
crypto	crypto: lib/mpi - avoid null pointer deref in mpi_cmp_ui()	2023-08-11 19:19:52 +08:00
dim	linux/dim: Do nothing if no time delta between samples	2023-05-09 11:06:45 +02:00
fonts
kunit	kunit: test: Fix the possible memory leak in executor_test	2023-11-20 11:59:15 +01:00
livepatch
lz4
lzo
math	lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX identifier	2023-07-09 22:47:50 +01:00
pldmfw
raid6	raid6: Add LoongArch SIMD recovery implementation	2023-09-06 22:53:55 +08:00
reed_solomon
test_fortify
vdso
xz
zlib_deflate
zlib_dfltcc
zlib_inflate
zstd	zstd: Fix array-index-out-of-bounds UBSAN warning	2023-12-13 18:44:58 +01:00
.gitignore
argv_split.c	argv_split: fix kernel-doc warnings	2023-09-19 13:21:33 -07:00
ashldi3.c
ashrdi3.c
asn1_decoder.c
asn1_encoder.c
assoc_array.c
atomic64_test.c
atomic64.c
audit.c
base64.c
bcd.c
bch.c	lib/bch.c: use bitrev instead of internal logic	2023-08-18 10:18:58 -07:00
bitfield_kunit.c
bitmap.c	lib/bitmap: drop optimization of bitmap_{from,to}_arr64	2023-06-22 13:57:41 -07:00
bitrev.c
bootconfig-data.S
bootconfig.c
bsearch.c
btree.c
bucket_locks.c
bug.c
build_OID_registry
buildid.c
bust_spinlocks.c
check_signature.c
checksum_kunit.c	kunit: Fix checksum tests on big endian CPUs	2023-08-25 10:14:34 +01:00
checksum.c
clz_ctz.c	lib/clz_ctz.c: Fix __clzdi2() and __ctzdi2() for 32-bit kernels	2023-08-25 13:22:10 -07:00
clz_tab.c
cmdline_kunit.c
cmdline.c
cmpdi2.c
compat_audit.c
cpu_rmap.c	lib: cpu_rmap: Fix potential use-after-free in irq_cpu_rmap_release()	2023-06-07 21:25:00 -07:00
cpumask_kunit.c
cpumask.c	cpumask: eliminate kernel-doc warnings	2023-07-17 15:47:21 -07:00
crc-ccitt.c
crc-itu-t.c
crc-t10dif.c
crc4.c
crc7.c
crc8.c
crc16.c
crc32.c
crc32defs.h
crc32test.c
crc64-rocksoft.c
crc64.c
ctype.c
debug_info.c
debug_locks.c
debugobjects.c	debugobjects: Recheck debug_objects_enabled before reporting	2023-06-07 14:16:12 +02:00
dec_and_lock.c
decompress_bunzip2.c
decompress_inflate.c	decompressor: provide missing prototypes	2023-06-09 17:44:17 -07:00
decompress_unlz4.c
decompress_unlzma.c
decompress_unlzo.c
decompress_unxz.c	decompressor: provide missing prototypes	2023-06-09 17:44:17 -07:00
decompress_unzstd.c	decompressor: provide missing prototypes	2023-06-09 17:44:17 -07:00
decompress.c
devmem_is_allowed.c	lib: devmem_is_allowed: include linux/io.h	2023-06-09 17:44:15 -07:00
devres.c	devres: show which resource was invalid in __devm_ioremap_resource()	2023-06-23 17:04:04 -07:00
dhry_1.c	lib: dhry: fix sleeping allocations inside non-preemptable section	2023-07-08 09:29:32 -07:00
dhry_2.c
dhry_run.c
dhry.h
digsig.c
dump_stack.c
dynamic_debug.c	dyndbg: add source filename to prefix	2023-08-04 15:28:41 +02:00
dynamic_queue_limits.c
earlycpio.c
errname.c	parisc: Drop the HP-UX ENOSYM and EREMOTERELEASE error codes	2023-12-08 08:52:20 +01:00
error-inject.c	lib: error-inject: remove error checking for debugfs_create_dir()	2023-08-18 10:18:55 -07:00
errseq.c
extable.c
fault-inject-usercopy.c
fault-inject.c
fdt_addresses.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
fdt.c
find_bit_benchmark.c
find_bit.c
flex_proportions.c
fortify_kunit.c	Revert "fortify: Allow KUnit test to build without FORTIFY"	2023-07-03 12:50:26 -07:00
gen_crc32table.c
gen_crc64table.c
genalloc.c	Devicetree include cleanups for v6.6:	2023-08-30 17:04:28 -07:00
generic-radix-tree.c	lib/generic-radix-tree.c: Don't overflow in peek()	2023-11-28 17:19:35 +00:00
glob.c
globtest.c
group_cpus.c	lib/group_cpus.c: avoid acquiring cpu hotplug lock in group_cpus_evenly	2023-12-13 18:45:22 +01:00
hashtable_test.c
hexdump.c
hweight.c
idr.c	idr: fix param name in idr_alloc_cyclic() doc	2023-09-05 19:01:38 -04:00
inflate.c
interval_tree_test.c
interval_tree.c
iomap_copy.c
iomap.c
iommu-helper.c
iov_iter.c	iov_iter: Fix iov_iter_extract_pages() with zero-sized entries	2023-09-09 15:11:49 -07:00
irq_poll.c
irq_regs.c
is_signed_type_kunit.c
is_single_threaded.c
kasprintf.c
Kconfig	lib/bch.c: use bitrev instead of internal logic	2023-08-18 10:18:58 -07:00
Kconfig.debug	iov_iter: Kunit tests for copying to/from an iterator	2023-09-09 15:11:49 -07:00
Kconfig.kasan
Kconfig.kcsan
Kconfig.kfence
Kconfig.kgdb
Kconfig.kmsan
Kconfig.ubsan	ubsan: Clarify Kconfig text for CONFIG_UBSAN_TRAP	2023-07-17 16:05:19 -07:00
kfifo.c
klist.c
kobject_uevent.c
kobject.c	kobject: Remove redundant checks for whether ktype is NULL	2023-08-19 19:37:53 +02:00
kstrtox.c	kstrtox: consistently use _tolower()	2023-08-21 13:46:25 -07:00
kstrtox.h
kunit_iov_iter.c	iov_iter: Kunit tests for page extraction	2023-09-09 15:11:49 -07:00
libcrc32c.c
linear_ranges.c
list_debug.c	list: Introduce CONFIG_LIST_HARDENED	2023-08-15 14:57:25 -07:00
list_sort.c
list-test.c
llist.c
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-rtmutex.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c	lockdep/selftests: Use SBRM APIs for wait context tests	2023-07-26 12:29:13 +02:00
lockref.c
logic_iomem.c
logic_pio.c	minmax: add in_range() macro	2023-08-24 16:20:18 -07:00
lru_cache.c
lshrdi3.c
Makefile	iov_iter: Kunit tests for copying to/from an iterator	2023-09-09 15:11:49 -07:00
maple_tree.c	maple_tree: add GFP_KERNEL to allocations in mas_expected_entries()	2023-10-18 12:12:41 -07:00
memcat_p.c
memcpy_kunit.c	kunit: memcpy: Mark tests as slow using test attributes	2023-07-26 13:29:28 -06:00
memory-notifier-error-inject.c
memregion.c
memweight.c
muldi3.c
net_utils.c	mac_pton: Clean up the header inclusions	2023-06-06 13:18:32 +02:00
netdev-notifier-error-inject.c
nlattr.c	netlink: allow be16 and be32 types in all uint policy checks	2023-07-27 13:45:51 +02:00
nmi_backtrace.c	nmi_backtrace: allow excluding an arbitrary CPU	2023-08-18 10:19:00 -07:00
notifier-error-inject.c	lib: remove error checking for debugfs_create_dir()	2023-08-18 10:18:55 -07:00
notifier-error-inject.h
objagg.c
of-reconfig-notifier-error-inject.c
oid_registry.c
once.c
overflow_kunit.c	overflow: Add struct_size_t() helper	2023-05-26 13:52:19 -07:00
packing.c
parman.c
parser.c
pci_iomap.c
percpu_counter.c	pcpcntr: add group allocation/free	2023-08-25 08:06:53 -07:00
percpu_test.c
percpu-refcount.c
plist.c
pm-notifier-error-inject.c
polynomial.c
radix-tree.c	radix tree: remove unused variable	2023-08-21 13:07:22 -07:00
radix-tree.h	radix-tree: move declarations to header	2023-06-12 11:31:50 -07:00
random32.c
ratelimit.c
rbtree_test.c
rbtree.c
rcuref.c
ref_tracker.c	lib/ref_tracker: remove warnings in case of allocation failure	2023-06-05 15:28:42 -07:00
refcount.c
rhashtable.c
sbitmap.c	sbitmap: fix batching wakeup	2023-07-21 11:40:20 -06:00
scatterlist.c	scatterlist: add missing function params to kernel-doc	2023-09-19 13:21:33 -07:00
seq_buf.c
sg_pool.c
sg_split.c
siphash_kunit.c
siphash.c
slub_kunit.c
smp_processor_id.c
sort.c
stackdepot.c
stackinit_kunit.c
stmp_device.c
strcat_kunit.c	string: Add Kunit tests for strcat() family	2023-05-16 14:08:02 -07:00
string_helpers.c	lib/string_helpers: Add kstrdup_and_replace() helper	2023-08-04 18:21:50 -07:00
string.c	string: use __builtin_memcpy() in strlcpy/strlcat	2023-06-01 11:24:50 -07:00
strncpy_from_user.c
strnlen_user.c
strscpy_kunit.c
syscall.c
test_bitmap.c	lib/bitmap: workaround const_eval test build failure	2023-07-18 13:25:37 -07:00
test_bitops.c
test_bits.c
test_blackhole_dev.c
test_bpf.c	bpf/tests: Enhance output on error and fix typos	2023-08-18 17:08:42 +02:00
test_debug_virtual.c
test_dynamic_debug.c
test_firmware.c	test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation	2023-06-15 13:42:18 +02:00
test_fprobe.c	fprobe: Pass return address to the handlers	2023-06-06 21:39:55 +09:00
test_fpu.c
test_free_pages.c
test_hash.c
test_hexdump.c
test_hmm_uapi.h
test_hmm.c	lib: replace kmap() with kmap_local_page()	2023-08-18 10:18:50 -07:00
test_ida.c
test_kmod.c
test_kprobes.c
test_linear_ranges.c
test_list_sort.c
test_lockup.c
test_maple_tree.c	maple_tree: add GFP_KERNEL to allocations in mas_expected_entries()	2023-10-18 12:12:41 -07:00
test_memcat_p.c
test_meminit.c	lib/test_meminit: allocate pages up to order MAX_ORDER	2023-08-18 10:12:32 -07:00
test_min_heap.c
test_module.c
test_objagg.c
test_parman.c
test_printf.c	lib/vsprintf: declare no_hash_pointers in sprintf.h	2023-08-21 13:46:24 -07:00
test_ref_tracker.c	lib/ref_tracker: improve printing stats	2023-06-05 15:28:42 -07:00
test_rhashtable.c
test_scanf.c	lib: test_scanf: Add explicit type cast to result initialization in test_number_prefix()	2023-08-16 11:47:29 +02:00
test_sort.c
test_static_key_base.c
test_static_keys.c
test_string.c
test_sysctl.c	test_sysclt: Test for registering a mount point	2023-06-18 02:32:54 -07:00
test_ubsan.c
test_user_copy.c
test_uuid.c
test_vmalloc.c	lib/test_vmalloc.c: avoid garbage in page array	2023-06-12 11:31:51 -07:00
test_xarray.c
test-kstrtox.c
test-string_helpers.c
textsearch.c
timerqueue.c
trace_readwrite.c
ts_bm.c	lib/ts_bm: add helper to reduce indentation and improve readability	2023-07-27 13:45:51 +02:00
ts_fsm.c
ts_kmp.c
ubsan.c	ubsan: add prototypes for internal functions	2023-05-30 16:42:01 -07:00
ubsan.h	ubsan: add prototypes for internal functions	2023-05-30 16:42:01 -07:00
ucmpdi2.c
ucs2_string.c
usercopy.c
uuid.c
vsprintf.c	lib/vsprintf: split out sprintf() and friends	2023-08-21 13:46:24 -07:00
win_minmax.c
xarray.c	xarray: Document necessary flag in alloc functions	2023-09-05 19:01:38 -04:00
xxhash.c