Nicholas Bellinger 6af0acc0b6 target: Fix multi-session dynamic se_node_acl double free OOPs ... commit 01d4d67355 upstream. This patch addresses a long-standing bug with multi-session (eg: iscsi-target + iser-target) se_node_acl dynamic free withini transport_deregister_session(). This bug is caused when a storage endpoint is configured with demo-mode (generate_node_acls = 1 + cache_dynamic_acls = 1) initiators, and initiator login creates a new dynamic node acl and attaches two sessions to it. After that, demo-mode for the storage instance is disabled via configfs (generate_node_acls = 0 + cache_dynamic_acls = 0) and the existing dynamic acl is never converted to an explicit ACL. The end result is dynamic acl resources are released twice when the sessions are shutdown in transport_deregister_session(). If the storage instance is not changed to disable demo-mode, or the dynamic acl is converted to an explict ACL, or there is only a single session associated with the dynamic ACL, the bug is not triggered. To address this big, move the release of dynamic se_node_acl memory into target_complete_nacl() so it's only freed once when se_node_acl->acl_kref reaches zero. (Drop unnecessary list_del_init usage - HCH) Reported-by: Rob Millner <rlm@daterainc.com> Tested-by: Rob Millner <rlm@daterainc.com> Cc: Rob Millner <rlm@daterainc.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-03-12 06:37:27 +01:00
..
acpi	Merge branch 'acpi-pci'	2015-11-07 01:30:10 +01:00
asm-generic	asm-generic: make copy_from_user() zero the destination properly	2016-09-24 10:07:45 +02:00
clocksource
crypto	crypto: ghash-generic - move common definitions to a new header file	2016-10-22 12:26:56 +02:00
drm	drm/prime: Pass the right module owner through to dma_buf_export()	2016-10-31 04:13:57 -06:00
dt-bindings	ARM: DT updates for v4.4	2015-11-10 15:06:26 -08:00
keys
kvm	KVM: arm/arm64: arch_timer: Preserve physical dist. active state on LR.active	2015-11-24 18:07:40 +01:00
linux	iommu/vt-d: Fix some macros that are incorrectly specified in intel-iommu	2017-03-12 06:37:25 +01:00
math-emu
media	videobuf2-core: Check user space planes array in dqbuf	2016-05-04 14:48:50 -07:00
memory
misc
net	netlabel: out of bound access in cipso_v4_validate()	2017-02-18 16:39:26 +01:00
pcmcia
ras
rdma	IB/cma: Fix a race condition in iboe_addr_get_sgid()	2017-01-09 08:07:51 +01:00
rxrpc
scsi	scsi: use 'scsi_device_from_queue()' for scsi_dh	2017-03-12 06:37:26 +01:00
soc	ARM: at91: define LPDDR types	2017-03-12 06:37:24 +01:00
sound	ALSA: rawmidi: Make snd_rawmidi_transmit() race-free	2016-02-17 12:30:58 -08:00
target	target: Fix multi-session dynamic se_node_acl double free OOPs	2017-03-12 06:37:27 +01:00
trace	SUNRPC: Don't allocate a full sockaddr_storage for tracing	2016-08-20 18:09:26 +02:00
uapi	can: raw: raw_setsockopt: limit number of can_filter that can be set	2016-12-15 08:49:22 -08:00
video	drm/imx: Match imx-ipuv3-crtc components using device node in platform data	2016-06-07 18:14:37 -07:00
xen	xen: Fix page <-> pfn conversion on 32 bit systems	2016-05-11 11:21:14 +02:00
Kbuild