Guillaume Nault 18dfc66755 selftests: pmtu.sh: Kill tcpdump processes launched by subshell. ... The cleanup() function takes care of killing processes launched by the test functions. It relies on variables like ${tcpdump_pids} to get the relevant PIDs. But tests are run in their own subshell, so updated *_pids values are invisible to other shells. Therefore cleanup() never sees any process to kill: $ ./tools/testing/selftests/net/pmtu.sh -t pmtu_ipv4_exception TEST: ipv4: PMTU exceptions [ OK ] TEST: ipv4: PMTU exceptions - nexthop objects [ OK ] $ pgrep -af tcpdump 6084 tcpdump -s 0 -i veth_A-R1 -w pmtu_ipv4_exception_veth_A-R1.pcap 6085 tcpdump -s 0 -i veth_R1-A -w pmtu_ipv4_exception_veth_R1-A.pcap 6086 tcpdump -s 0 -i veth_R1-B -w pmtu_ipv4_exception_veth_R1-B.pcap 6087 tcpdump -s 0 -i veth_B-R1 -w pmtu_ipv4_exception_veth_B-R1.pcap 6088 tcpdump -s 0 -i veth_A-R2 -w pmtu_ipv4_exception_veth_A-R2.pcap 6089 tcpdump -s 0 -i veth_R2-A -w pmtu_ipv4_exception_veth_R2-A.pcap 6090 tcpdump -s 0 -i veth_R2-B -w pmtu_ipv4_exception_veth_R2-B.pcap 6091 tcpdump -s 0 -i veth_B-R2 -w pmtu_ipv4_exception_veth_B-R2.pcap 6228 tcpdump -s 0 -i veth_A-R1 -w pmtu_ipv4_exception_veth_A-R1.pcap 6229 tcpdump -s 0 -i veth_R1-A -w pmtu_ipv4_exception_veth_R1-A.pcap 6230 tcpdump -s 0 -i veth_R1-B -w pmtu_ipv4_exception_veth_R1-B.pcap 6231 tcpdump -s 0 -i veth_B-R1 -w pmtu_ipv4_exception_veth_B-R1.pcap 6232 tcpdump -s 0 -i veth_A-R2 -w pmtu_ipv4_exception_veth_A-R2.pcap 6233 tcpdump -s 0 -i veth_R2-A -w pmtu_ipv4_exception_veth_R2-A.pcap 6234 tcpdump -s 0 -i veth_R2-B -w pmtu_ipv4_exception_veth_R2-B.pcap 6235 tcpdump -s 0 -i veth_B-R2 -w pmtu_ipv4_exception_veth_B-R2.pcap Fix this by running cleanup() in the context of the test subshell. Now that each test cleans the environment after completion, there's no need for calling cleanup() again when the next test starts. So let's drop it from the setup() function. This is okay because cleanup() is also called when pmtu.sh starts, so even the first test starts in a clean environment. Also, use tcpdump's immediate mode. Otherwise it might not have time to process buffered packets, resulting in missing packets or even empty pcap files for short tests. Note: PAUSE_ON_FAIL is still evaluated before cleanup(), so one can still inspect the test environment upon failure when using -p. Fixes: a92a0a7b8e ("selftests: pmtu: Simplify cleanup and namespace names") Signed-off-by: Guillaume Nault <gnault@redhat.com> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-03-09 20:23:15 -08:00
..
accounting	delayacct: track delays from memory compact	2022-01-20 08:52:55 +02:00
arch	tools arch x86: Sync the msr-index.h copy with the kernel sources	2022-02-22 17:43:05 -03:00
bootconfig
bpf	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-02-03 13:42:38 -08:00
build	Merge remote-tracking branch 'torvalds/master' into perf/core	2022-01-13 10:20:59 -03:00
cgroup	tools/cgroup/slabinfo: update to work with struct slab	2022-02-21 11:34:49 +01:00
counter
debugging
edid
firewire
firmware
gpio
hv
iio	iio: event_monitor: Flush output on event	2021-12-16 12:20:35 +00:00
include	x86 host:	2022-02-24 14:05:49 -08:00
io_uring
kvm/kvm_stat
laptop
leds
lib	libsubcmd: Fix use-after-free for realloc(..., 0)	2022-02-16 13:49:25 -03:00
memory-model	tools/memory-model: litmus: Add two tests for unlock(A)+lock(B) ordering	2021-11-30 17:47:08 -08:00
objtool	objtool: Fix truncated string warning	2022-01-24 10:09:06 -08:00
pci
pcmcia
perf	perf script: Fix error when printing 'weight' field	2022-02-22 21:17:55 -03:00
power	More ACPI updates for 5.17-rc1	2022-01-18 08:51:51 +02:00
rcu
scripts	tools: Ignore errors from `which' when searching a GCC toolchain	2022-02-01 23:04:12 +01:00
spi
testing	selftests: pmtu.sh: Kill tcpdump processes launched by subshell.	2022-03-09 20:23:15 -08:00
thermal/tmon	thermal: tools: tmon: remove unneeded local variable	2021-11-24 17:26:13 +01:00
time
tracing	rtla/osnoise: Fix error message when failing to enable trace instance	2022-02-25 21:05:30 -05:00
usb
virtio
vm
wmi
Makefile