mirror of
https://github.com/torvalds/linux.git
synced 2026-09-19 00:58:02 +02:00
06cb687a51
The v4l2 helper v4l2_async_register_subdev_sensor() calls
v4l2_async_register_subdev(), which is a macro that expands to
__v4l2_async_register_subdev(sd,THIS_MODULE). Since the macro is expanded
inside v4l2-fwnode.c, THIS_MODULE resolves to the v4l2-fwnode module
rather than the sensor driver module that originally set sd->owner. When
v4l2-fwnode is built-in, THIS_MODULE evaluates to NULL, which then
overwrites the sensor driver's owner with NULL.
This causes the problem that the sensor module's reference count is never
incremented during async registration, so the module can be removed while
the subdevice is still in use by a notifier (e.g., a CSI-2 receiver
bridge driver).
Fix this by renaming v4l2_async_register_subdev_sensor() to
__v4l2_async_register_subdev_sensor() with an added explicit module
argument and introducing a wrapper macro:
#define v4l2_async_register_subdev_sensor(sd) \
__v4l2_async_register_subdev_sensor(sd, THIS_MODULE)
This ensures the sensor driver module is properly referenced even when
the sensor driver does not init the owner field before calling
v4l2_async_register_subdev_sensor() and prevents premature module removal.
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| tuner-core.c | ||
| v4l2-async.c | ||
| v4l2-cci.c | ||
| v4l2-common.c | ||
| v4l2-compat-ioctl32.c | ||
| v4l2-ctrls-api.c | ||
| v4l2-ctrls-core.c | ||
| v4l2-ctrls-defs.c | ||
| v4l2-ctrls-priv.h | ||
| v4l2-ctrls-request.c | ||
| v4l2-dev.c | ||
| v4l2-device.c | ||
| v4l2-dv-timings.c | ||
| v4l2-event.c | ||
| v4l2-fh.c | ||
| v4l2-flash-led-class.c | ||
| v4l2-fwnode.c | ||
| v4l2-h264.c | ||
| v4l2-i2c.c | ||
| v4l2-ioctl.c | ||
| v4l2-isp.c | ||
| v4l2-jpeg.c | ||
| v4l2-mc.c | ||
| v4l2-mem2mem.c | ||
| v4l2-spi.c | ||
| v4l2-subdev-priv.h | ||
| v4l2-subdev.c | ||
| v4l2-trace.c | ||
| v4l2-vp9.c | ||