linux/drivers/usb
Jack Pham 25ad17d692 usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup
commit bd6742249b upstream.

OUT endpoint requests may somtimes have this flag set when
preparing to be submitted to HW indicating that there is an
additional TRB chained to the request for alignment purposes.
If that request is removed before the controller can execute the
transfer (e.g. ep_dequeue/ep_disable), the request will not go
through the dwc3_gadget_ep_cleanup_completed_request() handler
and will not have its needs_extra_trb flag cleared when
dwc3_gadget_giveback() is called.  This same request could be
later requeued for a new transfer that does not require an
extra TRB and if it is successfully completed, the cleanup
and TRB reclamation will incorrectly process the additional TRB
which belongs to the next request, and incorrectly advances the
TRB dequeue pointer, thereby messing up calculation of the next
requeust's actual/remaining count when it completes.

The right thing to do here is to ensure that the flag is cleared
before it is given back to the function driver.  A good place
to do that is in dwc3_gadget_del_and_unmap_request().

Fixes: c6267a5163 ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: stable@vger.kernel.org
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
[jackp: backport to <= 4.20: replaced 'needs_extra_trb' with 'unaligned'
        and 'zero' members in patch and reworded commit text]
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-01-31 08:14:42 +01:00
..
atm
c67x00
chipidea usb: chipidea: Prevent unbalanced IRQ disable 2018-11-13 11:08:36 -08:00
class usb: cdc-acm: send ZLP for Telit 3G Intel based modems 2019-01-16 22:04:31 +01:00
common usb: roles: Add a description for the class to Kconfig 2019-01-09 17:38:40 +01:00
core USB: leds: fix regression in usbport led trigger 2019-01-31 08:14:34 +01:00
dwc2 usb: dwc2: disable power_down on Amlogic devices 2019-01-09 17:38:39 +01:00
dwc3 usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup 2019-01-31 08:14:42 +01:00
early
gadget usb: gadget: udc: renesas_usb3: add a safety connection way for forced_b_device 2019-01-26 09:32:36 +01:00
host usb: r8a66597: Fix a possible concurrency use-after-free bug in r8a66597_endpoint_disable() 2019-01-09 17:38:39 +01:00
image
isp1760 usb: isp1760: remove redundant variable 'selector' 2018-07-13 15:41:56 +02:00
misc usb: appledisplay: Add 27" Apple Cinema Display 2018-12-13 09:16:15 +01:00
mon USB: mon: use ktime_get_real_ts64 instead of getnstimeofday64 2018-06-25 21:58:26 +08:00
mtu3 usb: mtu3: fix error of xhci port id when enable U3 dual role 2018-09-05 13:27:07 +02:00
musb usb: musb: dsps: do not disable CPPI41 irq in driver teardown 2018-09-20 12:40:14 +02:00
phy usb/phy: fix PPC64 build errors in phy-fsl-usb.c 2018-07-21 08:15:12 +02:00
renesas_usbhs usb: renesas_usbhs: Kconfig: convert to SPDX identifiers 2018-07-30 15:27:14 +02:00
roles usb: roles: Add a description for the class to Kconfig 2019-01-09 17:38:40 +01:00
serial USB: serial: pl2303: add new PID to support PL2303TB 2019-01-31 08:14:34 +01:00
storage USB: storage: add quirk for SMI SM3350 2019-01-16 22:04:32 +01:00
typec usb: typec: tcpm: Do not disconnect link for self powered devices 2019-01-26 09:32:34 +01:00
usbip usbip:vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten 2018-11-13 11:08:41 -08:00
wusbcore usb: wusbcore: security: cast sizeof to int for comparison 2018-07-02 18:08:19 +02:00
Kconfig usb: roles: Add a description for the class to Kconfig 2019-01-09 17:38:40 +01:00
Makefile usb: roles: Add Intel xHCI USB role switch driver 2018-03-22 13:49:27 +01:00
README
usb-skeleton.c usb: usb-skeleton: use irqsave() in USB's complete callback 2018-06-28 19:36:06 +09:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.