Tejun Heo 0967830e72 iocost: don't reset the inuse weight of under-weighted debtors ... commit 8c936f9ea1 upstream. When an iocg is in debt, its inuse weight is owned by debt handling and should stay at 1. This invariant was broken when determining the amount of surpluses at the beginning of donation calculation - when an iocg's hierarchical weight is too low, the iocg is excluded from donation calculation and its inuse is reset to its active regardless of its indebtedness, triggering warnings like the following: WARNING: CPU: 5 PID: 0 at block/blk-iocost.c:1416 iocg_kick_waitq+0x392/0x3a0 ... RIP: 0010:iocg_kick_waitq+0x392/0x3a0 Code: 00 00 be ff ff ff ff 48 89 4d a8 e8 98 b2 70 00 48 8b 4d a8 85 c0 0f 85 4a fe ff ff 0f 0b e9 43 fe ff ff 0f 0b e9 4d fe ff ff <0f> 0b e9 50 fe ff ff e8 a2 ae 70 00 66 90 0f 1f 44 00 00 55 48 89 RSP: 0018:ffffc90000200d08 EFLAGS: 00010016 ... <IRQ> ioc_timer_fn+0x2e0/0x1470 call_timer_fn+0xa1/0x2c0 ... As this happens only when an iocg's hierarchical weight is negligible, its impact likely is limited to triggering the warnings. Fix it by skipping resetting inuse of under-weighted debtors. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Rik van Riel <riel@surriel.com> Fixes: c421a3eb2e ("blk-iocost: revamp debt handling") Cc: stable@vger.kernel.org # v5.10+ Link: https://lore.kernel.org/r/YmjODd4aif9BzFuO@slm.duckdns.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-05-09 09:05:00 +02:00
..
partitions
badblocks.c
bfq-cgroup.c	block, bfq: don't move oom_bfqq	2022-04-08 14:40:30 +02:00
bfq-iosched.c	Revert "Revert "block, bfq: honor already-setup queue merges""	2022-04-08 14:40:32 +02:00
bfq-iosched.h
bfq-wf2q.c
bio-integrity.c	block: bio-integrity: Advance seed correctly for larger interval sizes	2022-02-08 18:30:35 +01:00
bio.c	block: Fix wrong offset in bio_truncate()	2022-02-01 17:25:48 +01:00
blk-cgroup-rwstat.c
blk-cgroup-rwstat.h
blk-cgroup.c
blk-core.c
blk-crypto-fallback.c
blk-crypto-internal.h
blk-crypto.c
blk-exec.c
blk-flush.c	block: Fix fsync always failed if once failed	2022-01-27 10:54:30 +01:00
blk-integrity.c
blk-ioc.c
blk-iocost.c	iocost: don't reset the inuse weight of under-weighted debtors	2022-05-09 09:05:00 +02:00
blk-iolatency.c
blk-lib.c
blk-map.c
blk-merge.c	block: don't merge across cgroup boundaries if blkcg is enabled	2022-04-08 14:39:55 +02:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	block: limit request dispatch loop duration	2022-04-08 14:39:55 +02:00
blk-mq-sched.h
blk-mq-sysfs.c
blk-mq-tag.c
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c
blk-mq.h
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2022-01-27 10:54:08 +01:00
blk-pm.h
blk-rq-qos.c
blk-rq-qos.h
blk-settings.c
blk-stat.c
blk-stat.h
blk-sysfs.c	block: don't delete queue kobject before its children	2022-04-08 14:40:00 +02:00
blk-throttle.c
blk-timeout.c
blk-wbt.c
blk-wbt.h
blk-zoned.c
blk.h
bounce.c
bsg-lib.c
bsg.c
cmdline-parser.c
elevator.c	block/wbt: fix negative inflight counter when remove scsi device	2022-02-23 12:01:04 +01:00
genhd.c
ioctl.c	block/compat_ioctl: fix range check in BLKGETSIZE	2022-04-27 13:53:57 +02:00
ioprio.c
Kconfig
Kconfig.iosched
keyslot-manager.c
kyber-iosched.c
Makefile
mq-deadline.c
opal_proto.h
scsi_ioctl.c
sed-opal.c
t10-pi.c