Changbin Du 9e2dbc31e3 riscv: fix oops caused by irqsoff latency tracer ... commit 22e2100b1b upstream. The trace_hardirqs_{on,off}() require the caller to setup frame pointer properly. This because these two functions use macro 'CALLER_ADDR1' (aka. __builtin_return_address(1)) to acquire caller info. If the $fp is used for other purpose, the code generated this macro (as below) could trigger memory access fault. 0xffffffff8011510e <+80>: ld a1,-16(s0) 0xffffffff80115112 <+84>: ld s2,-8(a1) # <-- paging fault here The oops message during booting if compiled with 'irqoff' tracer enabled: [ 0.039615][ T0] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000f8 [ 0.041925][ T0] Oops [#1] [ 0.042063][ T0] Modules linked in: [ 0.042864][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.0-rc1-00233-g9a20c48d1ed2 #29 [ 0.043568][ T0] Hardware name: riscv-virtio,qemu (DT) [ 0.044343][ T0] epc : trace_hardirqs_on+0x56/0xe2 [ 0.044601][ T0] ra : restore_all+0x12/0x6e [ 0.044721][ T0] epc : ffffffff80126a5c ra : ffffffff80003b94 sp : ffffffff81403db0 [ 0.044801][ T0] gp : ffffffff8163acd8 tp : ffffffff81414880 t0 : 0000000000000020 [ 0.044882][ T0] t1 : 0098968000000000 t2 : 0000000000000000 s0 : ffffffff81403de0 [ 0.044967][ T0] s1 : 0000000000000000 a0 : 0000000000000001 a1 : 0000000000000100 [ 0.045046][ T0] a2 : 0000000000000000 a3 : 0000000000000000 a4 : 0000000000000000 [ 0.045124][ T0] a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000054494d45 [ 0.045210][ T0] s2 : ffffffff80003b94 s3 : ffffffff81a8f1b0 s4 : ffffffff80e27b50 [ 0.045289][ T0] s5 : ffffffff81414880 s6 : ffffffff8160fa00 s7 : 00000000800120e8 [ 0.045389][ T0] s8 : 0000000080013100 s9 : 000000000000007f s10: 0000000000000000 [ 0.045474][ T0] s11: 0000000000000000 t3 : 7fffffffffffffff t4 : 0000000000000000 [ 0.045548][ T0] t5 : 0000000000000000 t6 : ffffffff814aa368 [ 0.045620][ T0] status: 0000000200000100 badaddr: 00000000000000f8 cause: 000000000000000d [ 0.046402][ T0] [<ffffffff80003b94>] restore_all+0x12/0x6e This because the $fp(aka. $s0) register is not used as frame pointer in the assembly entry code. resume_kernel: REG_L s0, TASK_TI_PREEMPT_COUNT(tp) bnez s0, restore_all REG_L s0, TASK_TI_FLAGS(tp) andi s0, s0, _TIF_NEED_RESCHED beqz s0, restore_all call preempt_schedule_irq j restore_all To fix above issue, here we add one extra level wrapper for function trace_hardirqs_{on,off}() so they can be safely called by low level entry code. Signed-off-by: Changbin Du <changbin.du@gmail.com> Fixes: 3c46979829 ("riscv: Enable LOCKDEP_SUPPORT & fixup TRACE_IRQFLAGS_SUPPORT") Cc: stable@vger.kernel.org Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-03-02 11:42:56 +01:00
..
alpha	alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile	2021-09-30 10:11:07 +02:00
arc	ARC: export clear_user_page() for modules	2021-09-22 12:28:04 +02:00
arm	ARM: OMAP2+: adjust the location of put_device() call in omapdss_init_of	2022-02-23 12:01:05 +01:00
arm64	arm64: dts: meson-g12: drop BL32 region from SEI510/SEI610	2022-02-23 12:01:05 +01:00
c6x
csky	perf: Protect perf_guest_cbs with RCU	2022-01-20 09:17:50 +01:00
h8300
hexagon	hexagon: clean up timer-regs.h	2021-11-26 10:39:19 +01:00
ia64	ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK	2021-11-18 14:03:55 +01:00
m68k	m68k: set a default value for MEMORY_RESERVE	2021-11-18 14:04:24 +01:00
microblaze
mips	MIPS: Octeon: Fix build errors using clang	2022-01-27 10:54:23 +01:00
nds32	perf: Protect perf_guest_cbs with RCU	2022-01-20 09:17:50 +01:00
nios2	nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST	2021-11-02 19:48:23 +01:00
openrisc	openrisc: Add clone3 ABI wrapper	2022-01-27 10:54:06 +01:00
parisc	parisc/unaligned: Fix ldw() and stw() unalignment handlers	2022-03-02 11:42:46 +01:00
powerpc	powerpc/lib/sstep: fix 'ptesync' build error	2022-02-23 12:01:03 +01:00
riscv	riscv: fix oops caused by irqsoff latency tracer	2022-03-02 11:42:56 +01:00
s390	KVM: s390: Return error on SIDA memop on normal guest	2022-02-11 09:09:03 +01:00
sh	sh: define __BIG_ENDIAN for math-emu	2021-11-26 10:39:12 +01:00
sparc	sparc64: fix pci_iounmap() when CONFIG_PCI is not set	2021-10-09 14:40:56 +02:00
um	um: registers: Rename function names to avoid conflicts and build problems	2022-01-27 10:54:18 +01:00
x86	x86/fpu: Correct pkru/xstate inconsistency	2022-03-02 11:42:47 +01:00
xtensa	xtensa: xtfpga: Try software restart before simulating CPU reset	2021-10-27 09:56:47 +02:00
.gitignore
Kconfig	arch/cc: Introduce a function to check for confidential computing features	2021-11-18 14:04:32 +01:00