Mauro Carvalho Chehab 0dfc2fb61c media: m88ds3103: don't call a non-initalized function ... commit b9c97c67fd upstream. If m88d3103 chip ID is not recognized, the device is not initialized. However, it returns from probe without any error, causing this OOPS: [ 7.689289] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 7.689297] pgd = 7b0bd7a7 [ 7.689302] [00000000] *pgd=00000000 [ 7.689318] Internal error: Oops: 80000005 [#1] SMP ARM [ 7.689322] Modules linked in: dvb_usb_dvbsky(+) m88ds3103 dvb_usb_v2 dvb_core videobuf2_vmalloc videobuf2_memops videobuf2_core crc32_arm_ce videodev media [ 7.689358] CPU: 3 PID: 197 Comm: systemd-udevd Not tainted 4.15.0-mcc+ #23 [ 7.689361] Hardware name: BCM2835 [ 7.689367] PC is at 0x0 [ 7.689382] LR is at m88ds3103_attach+0x194/0x1d0 [m88ds3103] [ 7.689386] pc : [<00000000>] lr : [<bf0ae1ec>] psr: 60000013 [ 7.689391] sp : ed8e5c20 ip : ed8c1e00 fp : ed8945c0 [ 7.689395] r10: ed894000 r9 : ed894378 r8 : eda736c0 [ 7.689400] r7 : ed894070 r6 : ed8e5c44 r5 : bf0bb040 r4 : eda77600 [ 7.689405] r3 : 00000000 r2 : 00000000 r1 : 00000000 r0 : eda77600 [ 7.689412] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 7.689417] Control: 10c5383d Table: 2d8e806a DAC: 00000051 [ 7.689423] Process systemd-udevd (pid: 197, stack limit = 0xe9dbfb63) [ 7.689428] Stack: (0xed8e5c20 to 0xed8e6000) [ 7.689439] 5c20: ed853a80 eda73640 ed894000 ed8942c0 ed853a80 bf0b9e98 ed894070 bf0b9f10 [ 7.689449] 5c40: 00000000 00000000 bf08c17c c08dfc50 00000000 00000000 00000000 00000000 [ 7.689459] 5c60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 7.689468] 5c80: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 7.689479] 5ca0: 00000000 00000000 ed8945c0 ed8942c0 ed894000 ed894830 bf0b9e98 00000000 [ 7.689490] 5cc0: ed894378 bf0a3cb4 bf0bc3b0 0000533b ed920540 00000000 00000034 bf0a6434 [ 7.689500] 5ce0: ee952070 ed826600 bf0a7038 bf0a2dd8 00000001 bf0a6768 bf0a2f90 ed8943c0 [ 7.689511] 5d00: 00000000 c08eca68 ed826620 ed826620 00000000 ee952070 bf0bc034 ee952000 [ 7.689521] 5d20: ed826600 bf0bb080 ffffffed c0aa9e9c c0aa9dac ed826620 c16edf6c c168c2c8 [ 7.689531] 5d40: c16edf70 00000000 bf0bc034 0000000d 00000000 c08e268c bf0bb080 ed826600 [ 7.689541] 5d60: bf0bc034 ed826654 ed826620 bf0bc034 c164c8bc 00000000 00000001 00000000 [ 7.689553] 5d80: 00000028 c08e2948 00000000 bf0bc034 c08e2848 c08e0778 ee9f0a58 ed88bab4 [ 7.689563] 5da0: bf0bc034 ed90ba80 c168c1f0 c08e1934 bf0bb3bc c17045ac bf0bc034 c164c8bc [ 7.689574] 5dc0: bf0bc034 bf0bb3bc ed91f564 c08e34ec bf0bc000 c164c8bc bf0bc034 c0aa8dc4 [ 7.689584] 5de0: ffffe000 00000000 bf0bf000 ed91f600 ed91f564 c03021e4 00000001 00000000 [ 7.689595] 5e00: c166e040 8040003f ed853a80 bf0bc448 00000000 c1678174 ed853a80 f0f22000 [ 7.689605] 5e20: f0f21fff 8040003f 014000c0 ed91e700 ed91e700 c16d8e68 00000001 ed91e6c0 [ 7.689615] 5e40: bf0bc400 00000001 bf0bc400 ed91f564 00000001 00000000 00000028 c03c9a24 [ 7.689625] 5e60: 00000001 c03c8c94 ed8e5f50 ed8e5f50 00000001 bf0bc400 ed91f540 c03c8cb0 [ 7.689637] 5e80: bf0bc40c 00007fff bf0bc400 c03c60b0 00000000 bf0bc448 00000028 c0e09684 [ 7.689647] 5ea0: 00000002 bf0bc530 c1234bf8 bf0bc5dc bf0bc514 c10ebbe8 ffffe000 bf000000 [ 7.689657] 5ec0: 00011538 00000000 ed8e5f48 00000000 00000000 00000000 00000000 00000000 [ 7.689666] 5ee0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 7.689676] 5f00: 00000000 00000000 7fffffff 00000000 00000013 b6e55a18 0000017b c0309104 [ 7.689686] 5f20: ed8e4000 00000000 00510af0 c03c9430 7fffffff 00000000 00000003 00000000 [ 7.689697] 5f40: 00000000 f0f0f000 00011538 00000000 f0f107b0 f0f0f000 00011538 f0f1fdb8 [ 7.689707] 5f60: f0f1fbe8 f0f1b974 00004000 000041e0 bf0bc3d0 00000001 00000000 000024c4 [ 7.689717] 5f80: 0000002d 0000002e 00000019 00000000 00000010 00000000 16894000 00000000 [ 7.689727] 5fa0: 00000000 c0308f20 16894000 00000000 00000013 b6e55a18 00000000 b6e5652c [ 7.689737] 5fc0: 16894000 00000000 00000000 0000017b 00020000 00508110 00000000 00510af0 [ 7.689748] 5fe0: bef68948 bef68938 b6e4d3d0 b6d32590 60000010 00000013 00000000 00000000 [ 7.689790] [<bf0ae1ec>] (m88ds3103_attach [m88ds3103]) from [<bf0b9f10>] (dvbsky_s960c_attach+0x78/0x280 [dvb_usb_dvbsky]) [ 7.689821] [<bf0b9f10>] (dvbsky_s960c_attach [dvb_usb_dvbsky]) from [<bf0a3cb4>] (dvb_usbv2_probe+0xa3c/0x1024 [dvb_usb_v2]) [ 7.689849] [<bf0a3cb4>] (dvb_usbv2_probe [dvb_usb_v2]) from [<c0aa9e9c>] (usb_probe_interface+0xf0/0x2a8) [ 7.689869] [<c0aa9e9c>] (usb_probe_interface) from [<c08e268c>] (driver_probe_device+0x2f8/0x4b4) [ 7.689881] [<c08e268c>] (driver_probe_device) from [<c08e2948>] (__driver_attach+0x100/0x11c) [ 7.689895] [<c08e2948>] (__driver_attach) from [<c08e0778>] (bus_for_each_dev+0x4c/0x9c) [ 7.689909] [<c08e0778>] (bus_for_each_dev) from [<c08e1934>] (bus_add_driver+0x1c0/0x264) [ 7.689919] [<c08e1934>] (bus_add_driver) from [<c08e34ec>] (driver_register+0x78/0xf4) [ 7.689931] [<c08e34ec>] (driver_register) from [<c0aa8dc4>] (usb_register_driver+0x70/0x134) [ 7.689946] [<c0aa8dc4>] (usb_register_driver) from [<c03021e4>] (do_one_initcall+0x44/0x168) [ 7.689963] [<c03021e4>] (do_one_initcall) from [<c03c9a24>] (do_init_module+0x64/0x1f4) [ 7.689979] [<c03c9a24>] (do_init_module) from [<c03c8cb0>] (load_module+0x20a0/0x25c8) [ 7.689993] [<c03c8cb0>] (load_module) from [<c03c9430>] (SyS_finit_module+0xb4/0xec) [ 7.690007] [<c03c9430>] (SyS_finit_module) from [<c0308f20>] (ret_fast_syscall+0x0/0x54) [ 7.690018] Code: bad PC value This may happen on normal circumstances, if, for some reason, the demod hangs and start returning an invalid chip ID: [ 10.394395] m88ds3103 3-0068: Unknown device. Chip_id=00 So, change the logic to cause probe to fail with -ENODEV, preventing the OOPS. Detected while testing DVB MMAP patches on Raspberry Pi 3 with DVBSky S960CI. Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-03-11 16:19:44 +01:00
..
accessibility
acpi	ACPI: sbshc: remove raw pointer from printk() message	2018-02-16 20:09:47 +01:00
amba
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	ahci: Add Intel Cannon Lake PCH-H PCI ID	2018-02-16 20:09:42 +01:00
atm	atm: horizon: Fix irq release error	2017-12-16 10:33:55 +01:00
auxdisplay
base	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:06:08 +01:00
bcma	bcma: use (get|put)_device when probing/removing device driver	2017-03-12 06:37:30 +01:00
block	pktcdvd: Fix pkt_setup_dev() error path	2018-02-16 20:09:47 +01:00
bluetooth	Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version	2018-02-16 20:09:46 +01:00
bus	sunxi-rsb: Include OF based modalias in device uevent	2018-01-10 09:27:09 +01:00
cdrom
char	tpm_i2c_nuvoton: fix potential buffer overruns caused by bit glitches on the bus	2018-03-11 16:19:44 +01:00
clk	clk: tegra: Fix cclk_lp divisor register	2017-12-20 10:04:59 +01:00
clocksource	clockevents/drivers/cs5535: Improve resilience to spurious interrupts	2017-10-27 10:23:17 +02:00
connector
cpufreq	cpufreq: s3c24xx: Fix broken s3c_cpufreq_init()	2018-03-11 16:19:44 +01:00
cpuidle	cpuidle: fix broadcast control when broadcast can not be entered	2017-12-25 14:22:15 +01:00
crypto	crypto: s5p-sss - Fix kernel Oops in AES-ECB mode	2018-02-25 11:03:55 +01:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: zx: fix build warning	2018-02-25 11:03:50 +01:00
dma-buf
edac	EDAC, octeon: Fix an uninitialized variable warning	2018-02-16 20:09:47 +01:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire	firewire: net: fix fragmented datagram_size off-by-one	2016-11-10 16:36:35 +01:00
firmware	efi/esrt: Cleanup bad memory map log messages	2017-12-20 10:04:56 +01:00
fmc
fpga
gpio	gpio: xgene: mark PM functions as __maybe_unused	2018-02-25 11:03:50 +01:00
gpu	drm/ttm: check the return value of kzalloc	2018-03-03 10:19:44 +01:00
hid	usb: ldusb: add PIDs for new CASSY devices supported by this driver	2018-02-28 10:17:23 +01:00
hsi
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	hwmon: (pmbus) Use 64bit math for DIRECT format values	2018-02-03 17:04:28 +01:00
hwspinlock
hwtracing	intel_th: pci: Add Gemini Lake support	2017-12-20 10:04:54 +01:00
i2c	i2c: remove __init from i2c_register_board_info()	2018-02-25 11:03:48 +01:00
ide
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio: adis_lib: Initialize trigger before requesting interrupt	2018-02-28 10:17:22 +01:00
infiniband	IB/ipoib: Fix race condition in neigh creation	2018-03-03 10:19:43 +01:00
input	Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-uninitialized warning	2018-02-25 11:03:49 +01:00
iommu	iommu/arm-smmu-v3: Don't free page table ops twice	2018-01-17 09:35:25 +01:00
ipack
irqchip	irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq()	2018-02-28 10:17:22 +01:00
isdn	isdn: sc: work around type mismatch warning	2018-02-25 11:03:51 +01:00
leds	led: core: Fix brightness setting when setting delay_off=0	2018-03-03 10:19:43 +01:00
lguest
lightnvm
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	md: avoid warning for 32-bit sector_t	2018-02-25 11:03:44 +01:00
media	media: m88ds3103: don't call a non-initalized function	2018-03-11 16:19:44 +01:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick	memstick: rtsx_usb_ms: Manage runtime PM when accessing the device	2016-10-28 03:01:35 -04:00
message	mptfusion: hide unused seq_mpt_print_ioc_summary function	2018-02-25 11:03:45 +01:00
mfd	mfd: twl6040: Fix child-node lookup	2018-01-02 20:33:20 +01:00
misc	cxl: Check if vphb exists before iterating over AFU devices	2017-12-25 14:22:08 +01:00
mmc	mmc: sdhci-of-esdhc: add/remove some quirks according to vendor version	2018-01-31 12:06:09 +01:00
mtd	mtd: nand: gpmi: Fix failure when a erased page has a bitflip at BBM	2018-03-03 10:19:41 +01:00
net	net: gianfar_ptp: move set_fipers() to spinlock protecting area	2018-03-03 10:19:45 +01:00
nfc	nfc: fdp: fix NULL pointer dereference	2017-08-06 19:19:40 -07:00
ntb	ntb_transport: fix bug calculating num_qps_mw	2017-08-30 10:19:29 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme: Fix managing degraded controllers	2018-02-16 20:09:47 +01:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: device: Export of_device_{get_modalias, uvent_modalias} to modules	2017-07-27 15:06:09 -07:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parisc, parport_gsc: Fixes for printk continuation lines	2017-06-17 06:39:37 +02:00
pci	PCI: keystone: Fix interrupt-controller-node lookup	2018-02-28 10:17:21 +01:00
pcmcia
perf	drivers/perf: arm_pmu: Fix leak in error path	2016-10-07 15:23:41 +02:00
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: sunxi: Fix A80 interrupt pin bank	2018-02-25 11:03:39 +01:00
platform	dell-wmi, dell-laptop: depends DMI	2018-02-25 11:03:51 +01:00
pnp
power	power: bq27xxx_battery: mark some symbols __maybe_unused	2018-02-25 11:03:50 +01:00
powercap
pps
ps3
ptp
pwm	pwm: pca9685: Fix period change with same duty cycle	2017-03-15 09:57:14 +08:00
rapidio
ras
regulator	regulator: fan53555: fix I2C device ids	2017-11-02 09:40:50 +01:00
remoteproc
reset
rpmsg
rtc	rtc-opal: Fix handling of firmware error codes, prevent busy loops	2018-02-22 15:44:59 +01:00
s390	s390/dasd: fix wrongly assigned configuration data	2018-03-03 10:19:43 +01:00
sbus
scsi	scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error	2018-03-03 10:19:42 +01:00
sfi
sh
sn
soc	soc: qcom/spm: shut up uninitialized variable warning	2016-09-24 10:07:42 +02:00
spi	spi: atmel: fixed spin_lock usage inside atmel_spi_remove	2018-03-03 10:19:42 +01:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: unisys: visorinput depends on INPUT	2018-02-25 11:03:48 +01:00
target	target/user: Fix cast from pointer to phys_addr_t	2018-02-25 11:03:46 +01:00
tc
thermal	thermal: spear: use __maybe_unused for PM functions	2018-02-25 11:03:44 +01:00
thunderbolt
tty	serial: 8250_mid: fix broken DMA dependency	2018-02-25 11:03:49 +01:00
uio	uio: fix dmem_region_start computation	2016-10-31 04:13:59 -06:00
usb	usb: renesas_usbhs: missed the "running" flag in usb_dmac with rx path	2018-02-28 10:17:23 +01:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio-pci: Handle error from pci_iomap	2017-08-06 19:19:46 -07:00
vhost	vhost_net: stop device during reset owner	2018-02-16 20:09:38 +01:00
video	fbdev: sm712fb: avoid unused function warnings	2018-02-25 11:03:47 +01:00
virt
virtio	virtio_balloon: prevent uninitialized variable use	2018-02-25 11:03:42 +01:00
vlynq
vme	vme: Fix wrong pointer utilization in ca91cx42_slave_get	2017-01-19 20:17:21 +01:00
w1	w1: ds2490: USB transfer buffers need to be DMAable	2017-03-12 06:37:29 +01:00
watchdog	watchdog: imx2_wdt: restore previous timeout after suspend+resume	2018-02-16 20:09:45 +01:00
xen	xen/gntdev: Fix partial gntdev_mmap() cleanup	2018-03-03 10:19:45 +01:00
zorro
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00