linux/drivers
Jonas Eymann 0dedb763d0 crypto: talitos - fix crash in talitos_cra_init()
commit 89d124cb61 upstream.

Conversion of talitos driver to the new AEAD interface
hasn't been properly tested.

AEAD algorithms crash in talitos_cra_init as follows:

[...]
[    1.141095] talitos ffe30000.crypto: hwrng
[    1.145381] Unable to handle kernel paging request for data at address 0x00000058
[    1.152913] Faulting instruction address: 0xc02accc0
[    1.157910] Oops: Kernel access of bad area, sig: 11 [#1]
[    1.163315] SMP NR_CPUS=2 P1020 RDB
[    1.166810] Modules linked in:
[    1.169875] CPU: 0 PID: 1007 Comm: cryptomgr_test Not tainted 4.4.6 #1
[    1.176415] task: db5ec200 ti: db4d6000 task.ti: db4d6000
[    1.181821] NIP: c02accc0 LR: c02acd18 CTR: c02acd04
[    1.186793] REGS: db4d7d30 TRAP: 0300   Not tainted  (4.4.6)
[    1.192457] MSR: 00029000 <CE,EE,ME>  CR: 95009359  XER: e0000000
[    1.198585] DEAR: 00000058 ESR: 00000000
GPR00: c017bdc0 db4d7de0 db5ec200 df424b48 00000000 00000000 df424bfc db75a600
GPR08: df424b48 00000000 db75a628 db4d6000 00000149 00000000 c0044cac db5acda0
GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000400 df424940
GPR24: df424900 00003083 00000400 c0180000 db75a640 c03e9f84 df424b40 df424b48
[    1.230978] NIP [c02accc0] talitos_cra_init+0x28/0x6c
[    1.236039] LR [c02acd18] talitos_cra_init_aead+0x14/0x28
[    1.241443] Call Trace:
[    1.243894] [db4d7de0] [c03e9f84] 0xc03e9f84 (unreliable)
[    1.249322] [db4d7df0] [c017bdc0] crypto_create_tfm+0x5c/0xf0
[    1.255083] [db4d7e10] [c017beec] crypto_alloc_tfm+0x98/0xf8
[    1.260769] [db4d7e40] [c0186a20] alg_test_aead+0x28/0xc8
[    1.266181] [db4d7e60] [c0186718] alg_test+0x260/0x2e0
[    1.271333] [db4d7ee0] [c0183860] cryptomgr_test+0x30/0x54
[    1.276843] [db4d7ef0] [c0044d80] kthread+0xd4/0xd8
[    1.281741] [db4d7f40] [c000e4a4] ret_from_kernel_thread+0x5c/0x64
[    1.287930] Instruction dump:
[    1.290902] 38600000 4e800020 81230028 7c681b78 81490010 38e9ffc0 3929ffe8 554a073e
[    1.298691] 2b8a000a 7d474f9e 812a0008 91230030 <80e90058> 39270060 7c0004ac 7cc04828

Fixes: aeb4c132f3 ("crypto: talitos - Convert to new AEAD interface")
Signed-off-by: Jonas Eymann <J.Eymann@gmx.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix typo - replaced parameter of __crypto_ahash_alg(): s/tfm/alg
Remove checkpatch warnings.
Add commit message.

Signed-off-by: Horia Geant? <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2016-05-04 14:48:44 -07:00
..
accessibility
acpi Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()" 2016-04-20 15:42:16 +09:00
amba
android drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE 2016-03-03 15:07:10 -08:00
ata pata-rb532-cf: get rid of the irq_to_gpio() call 2016-03-09 15:34:53 -08:00
atm
auxdisplay
base base/platform: Fix platform drivers with no probe callback 2016-02-17 12:30:55 -08:00
bcma
block block: loop: fix filesystem corruption in case of aio/dio 2016-05-04 14:48:39 -07:00
bluetooth Bluetooth: Add new AR3012 ID 0489:e095 2016-04-12 09:08:54 -07:00
bus bus: sunxi-rsb: Fix peripheral IC mapping runtime address 2015-12-22 11:42:30 -08:00
cdrom
char tpm: fix the cleanup of struct tpm_chip 2016-04-12 09:08:47 -07:00
clk clk: bcm2835: Fix setting of PLL divider clock rates 2016-04-12 09:09:02 -07:00
clocksource clockevents/tcb_clksrc: Prevent disabling an already disabled clock 2016-03-03 15:07:15 -08:00
connector connector: bump skb->users before callback invocation 2016-01-04 21:46:45 -05:00
cpufreq cpufreq: intel_pstate: Fix processing for turbo activation ratio 2016-05-04 14:48:44 -07:00
cpuidle
crypto crypto: talitos - fix crash in talitos_cra_init() 2016-05-04 14:48:44 -07:00
dca
devfreq
dio
dma dmaengine: pxa_dma: fix the maximum requestor line 2016-05-04 14:48:42 -07:00
dma-buf
edac x86 EDAC, sb_edac.c: Repair damage introduced when "fixing" channel address 2016-05-04 14:48:42 -07:00
eisa
extcon
firewire
firmware efi: Add pstore variables to the deletion whitelist 2016-03-03 15:07:09 -08:00
fmc
fpga
gpio gpio: revert get() to non-errorprogating behaviour 2015-12-17 15:48:29 +01:00
gpu Revert "drm/amdgpu: disable runtime pm on PX laptops without dGPU power control" 2016-05-04 14:48:43 -07:00
hid HID: usbhid: fix inconsistent reset/resume/reset-resume behavior 2016-04-20 15:42:16 +09:00
hsi
hv Drivers: hv: vmbus: Fix a Host signaling bug 2016-03-03 15:07:16 -08:00
hwmon hwmon: (max1111) Return -ENODEV from max1111_read_channel if not instantiated 2016-04-20 15:41:52 +09:00
hwspinlock drivers/hwspinlock: fix race between radix tree insertion and lookup 2016-02-25 12:01:23 -08:00
hwtracing coresight: checking for NULL string in coresight_name_match() 2016-03-03 15:07:14 -08:00
i2c i2c: brcmstb: allocate correct amount of memory for regmap 2016-03-09 15:34:56 -08:00
ide
idle intel_idle: prevent SKL-H boot failure when C8+C9+C10 enabled 2016-04-12 09:09:05 -07:00
iio iio: gyro: bmg160: fix endianness when reading axes 2016-04-20 15:42:12 +09:00
infiniband iser-target: Rework connection termination 2016-04-12 09:09:03 -07:00
input Input: ati_remote2 - fix crashes on detecting device with invalid descriptor 2016-04-12 09:09:04 -07:00
iommu iommu: Don't overwrite domain pointer when there is no default_domain 2016-04-20 15:42:13 +09:00
ipack
irqchip irqchip/gic-v3-its: Fix double ICC_EOIR write for LPI in EOImode==1 2016-03-03 15:07:14 -08:00
isdn ser_gigaset: remove unnecessary kfree() calls from release method 2015-12-15 13:24:21 -05:00
leds
lguest
lightnvm lightnvm: wrong offset in bad blk lun calculation 2015-12-29 08:28:32 -07:00
macintosh
mailbox
mcb
md dm cache metadata: fix cmd_read_lock() acquiring write lock 2016-05-04 14:48:41 -07:00
media usbvision: fix crash on detecting device with invalid configuration 2016-04-20 15:42:17 +09:00
memory fsl-ifc: add missing include on ARM64 2015-12-16 00:16:58 +01:00
memstick
message
mfd
misc mei: bus: check if the device is enabled before data transfer 2016-04-12 09:08:46 -07:00
mmc mmc: sdhci-pci: Add support and PCI IDs for more Broxton host controllers 2016-04-20 15:42:14 +09:00
mtd mtd: onenand: fix deadlock in onenand_block_markbad 2016-04-12 09:09:05 -07:00
net iwlwifi: mvm: fix memory leak in paging 2016-05-04 14:48:44 -07:00
nfc
ntb
nubus
nvdimm libnvdimm, pfn: fix uuid validation 2016-04-20 15:41:54 +09:00
nvme NVMe: IO ending fixes on surprise removal 2015-12-22 10:12:04 -07:00
nvmem
of of: alloc anywhere from memblock if range not specified 2016-04-12 09:08:55 -07:00
oprofile
parisc parisc iommu: fix panic due to trying to allocate too large region 2015-12-12 16:07:25 +01:00
parport
pci PCI: Disable IO/MEM decoding for devices with non-compliant BARs 2016-04-12 09:08:37 -07:00
pcmcia pcmcia: db1xxx_ss: fix last irq_to_gpio user 2016-04-20 15:42:09 +09:00
perf
phy phy: core: fix wrong err handle for phy_power_on 2016-03-03 15:07:28 -08:00
pinctrl pinctrl: freescale: imx: fix bogus check of of_iomap() return value 2016-04-20 15:42:08 +09:00
platform ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list 2016-04-12 09:09:01 -07:00
pnp
power
powercap powercap / RAPL: fix BIOS lock check 2015-12-12 02:31:11 +01:00
pps
ps3
ptp
pwm
rapidio
ras
regulator regulator: core: Fix nested locking of supplies 2016-04-12 09:08:31 -07:00
remoteproc
reset
rpmsg
rtc rtc: da9063: fix access ordering error during RTC interrupt at system power on 2015-12-20 13:39:29 +01:00
s390 s390/dasd: fix diag 0x250 inline assembly 2016-03-16 08:42:58 -07:00
sbus
scsi sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes 2016-04-20 15:42:12 +09:00
sfi
sh drivers: sh: Restore legacy clock domain on SuperH platforms 2016-03-09 15:34:49 -08:00
sn
soc
spi spi: atmel: fix gpio chip-select in case of non-DT platform 2016-03-03 15:07:27 -08:00
spmi
ssb
staging staging: android: ion: Set the length of the DMA sg entries in buffer 2016-04-20 15:42:16 +09:00
target target: Fix target_release_cmd_kref shutdown comp leak 2016-04-12 09:09:02 -07:00
tc
thermal Thermal: Ignore invalid trip points 2016-04-12 09:08:35 -07:00
thunderbolt
tty 8250: use callbacks to access UART_DLL/UART_DLM 2016-04-12 09:08:49 -07:00
uio
usb usb: gadget: f_fs: Fix use-after-free 2016-05-04 14:48:41 -07:00
uwb
vfio vfio: fix ioctl error handling 2016-03-09 15:34:50 -08:00
vhost
video fbcon: set a default value to blink interval 2016-03-09 15:34:50 -08:00
virt
virtio virtio: virtio 1.0 cs04 spec compliance for reset 2016-04-20 15:42:10 +09:00
vlynq
vme
w1
watchdog watchdog: rc32434_wdt: fix ioctl error handling 2016-04-12 09:08:54 -07:00
xen xen/events: Mask a moving irq 2016-04-20 15:41:56 +09:00
zorro
Kconfig
Makefile