Sasha Neftin fc7116a79a igc: Fix BUG: scheduling while atomic ... [ Upstream commit c80a29f0fe ] Replace usleep_range() method with udelay() method to allow atomic contexts in low-level MDIO access functions. The following issue can be seen by doing the following: $ modprobe -r bonding $ modprobe -v bonding max_bonds=1 mode=1 miimon=100 use_carrier=0 $ ip link set bond0 up $ ifenslave bond0 eth0 eth1 [ 982.357308] BUG: scheduling while atomic: kworker/u64:0/9/0x00000002 [ 982.364431] INFO: lockdep is turned off. [ 982.368824] Modules linked in: bonding sctp ip6_udp_tunnel udp_tunnel mlx4_ib ib_uverbs ib_core mlx4_en mlx4_core nfp tls sunrpc intel_rapl_msr iTCO_wdt iTCO_vendor_support mxm_wmi dcdbas intel_rapl_common sb_edac x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel rapl intel_cstate intel_uncore pcspkr lpc_ich mei_me ipmi_ssif mei ipmi_si ipmi_devintf ipmi_msghandler wmi acpi_power_meter xfs libcrc32c sr_mod cdrom sd_mod t10_pi sg mgag200 drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm ahci libahci crc32c_intel libata i2c_algo_bit tg3 megaraid_sas igc dm_mirror dm_region_hash dm_log dm_mod [last unloaded: bonding] [ 982.437941] CPU: 25 PID: 9 Comm: kworker/u64:0 Kdump: loaded Tainted: G W --------- - - 4.18.0-348.el8.x86_64+debug #1 [ 982.451333] Hardware name: Dell Inc. PowerEdge R730/0H21J3, BIOS 2.7.0 12/005/2017 [ 982.459791] Workqueue: bond0 bond_mii_monitor [bonding] [ 982.465622] Call Trace: [ 982.468355] dump_stack+0x8e/0xd0 [ 982.472056] __schedule_bug.cold.60+0x3a/0x60 [ 982.476919] __schedule+0x147b/0x1bc0 [ 982.481007] ? firmware_map_remove+0x16b/0x16b [ 982.485967] ? hrtimer_fixup_init+0x40/0x40 [ 982.490625] schedule+0xd9/0x250 [ 982.494227] schedule_hrtimeout_range_clock+0x10d/0x2c0 [ 982.500058] ? hrtimer_nanosleep_restart+0x130/0x130 [ 982.505598] ? hrtimer_init_sleeper_on_stack+0x90/0x90 [ 982.511332] ? usleep_range+0x88/0x130 [ 982.515514] ? recalibrate_cpu_khz+0x10/0x10 [ 982.520279] ? ktime_get+0xab/0x1c0 [ 982.524175] ? usleep_range+0x88/0x130 [ 982.528355] usleep_range+0xdd/0x130 [ 982.532344] ? console_conditional_schedule+0x30/0x30 [ 982.537987] ? igc_put_hw_semaphore+0x17/0x60 [igc] [ 982.543432] igc_read_phy_reg_gpy+0x111/0x2b0 [igc] [ 982.548887] igc_phy_has_link+0xfa/0x260 [igc] [ 982.553847] ? igc_get_phy_id+0x210/0x210 [igc] [ 982.558894] ? lock_acquire+0x34d/0x890 [ 982.563187] ? lock_downgrade+0x710/0x710 [ 982.567659] ? rcu_read_unlock+0x50/0x50 [ 982.572039] igc_check_for_copper_link+0x106/0x210 [igc] [ 982.577970] ? igc_config_fc_after_link_up+0x840/0x840 [igc] [ 982.584286] ? rcu_read_unlock+0x50/0x50 [ 982.588661] ? lock_release+0x591/0xb80 [ 982.592939] ? lock_release+0x591/0xb80 [ 982.597220] igc_has_link+0x113/0x330 [igc] [ 982.601887] ? lock_downgrade+0x710/0x710 [ 982.606362] igc_ethtool_get_link+0x6d/0x90 [igc] [ 982.611614] bond_check_dev_link+0x131/0x2c0 [bonding] [ 982.617350] ? bond_time_in_interval+0xd0/0xd0 [bonding] [ 982.623277] ? rcu_read_lock_held+0x62/0xc0 [ 982.627944] ? rcu_read_lock_sched_held+0xe0/0xe0 [ 982.633198] bond_mii_monitor+0x314/0x2500 [bonding] [ 982.638738] ? lock_contended+0x880/0x880 [ 982.643214] ? bond_miimon_link_change+0xa0/0xa0 [bonding] [ 982.649336] ? lock_acquire+0x34d/0x890 [ 982.653615] ? lock_downgrade+0x710/0x710 [ 982.658089] ? debug_object_deactivate+0x221/0x340 [ 982.663436] ? rcu_read_unlock+0x50/0x50 [ 982.667811] ? debug_print_object+0x2b0/0x2b0 [ 982.672672] ? __switch_to_asm+0x41/0x70 [ 982.677049] ? __switch_to_asm+0x35/0x70 [ 982.681426] ? _raw_spin_unlock_irq+0x24/0x40 [ 982.686288] ? trace_hardirqs_on+0x20/0x195 [ 982.690956] ? _raw_spin_unlock_irq+0x24/0x40 [ 982.695818] process_one_work+0x8f0/0x1770 [ 982.700390] ? pwq_dec_nr_in_flight+0x320/0x320 [ 982.705443] ? debug_show_held_locks+0x50/0x50 [ 982.710403] worker_thread+0x87/0xb40 [ 982.714489] ? process_one_work+0x1770/0x1770 [ 982.719349] kthread+0x344/0x410 [ 982.722950] ? kthread_insert_work_sanity_check+0xd0/0xd0 [ 982.728975] ret_from_fork+0x3a/0x50 Fixes: 5586838fe9 ("igc: Add code for PHY support") Reported-by: Corinna Vinschen <vinschen@redhat.com> Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> Tested-by: Corinna Vinschen <vinschen@redhat.com> Tested-by: Naama Meir <naamax.meir@linux.intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-27 13:53:49 +02:00
..
accessibility	speakup-dectlk: Restore pitch setting	2022-02-16 12:54:30 +01:00
acpi	ACPI: processor idle: Check for architectural support for LPI	2022-04-20 09:23:09 +02:00
amba	amba: Make the remove callback return void	2022-04-08 14:40:02 +02:00
android	binder: fix handling of error during copy	2022-01-27 10:54:06 +01:00
ata	ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs	2022-04-20 09:23:22 +02:00
atm	atm: eni: Add check for dma_map_single	2022-03-23 09:13:27 +01:00
auxdisplay	auxdisplay: ht16k33: Fix frame buffer device blanking	2021-11-18 14:04:24 +01:00
base	PM: core: keep irq flags in device_pm_check_callbacks()	2022-04-08 14:40:32 +02:00
bcma
block	drbd: Fix five use after free bugs in get_initial_state	2022-04-13 21:01:06 +02:00
bluetooth	Bluetooth: btmtksdio: Fix kernel oops in btmtksdio_interrupt	2022-04-08 14:40:22 +02:00
bus	mips: cdmm: Fix refcount leak in mips_cdmm_phys_base	2022-04-08 14:40:20 +02:00
cdrom
char	virtio_console: eliminate anonymous module_init & module_exit	2022-04-13 21:01:02 +02:00
clk	clk: Enforce that disjoints limits are invalid	2022-04-13 21:01:02 +02:00
clocksource	clocksource: acpi_pm: fix return value of __setup handler	2022-04-08 14:40:03 +02:00
connector
counter	counter: stm32-lptimer-cnt: remove iio counter abi	2022-01-27 10:54:08 +01:00
cpufreq	cpufreq: qcom-cpufreq-nvmem: fix reading of PVS Valid fuse	2022-04-08 14:40:24 +02:00
cpuidle	cpuidle: Fix kobject memory leaks in error paths	2021-11-18 14:04:05 +01:00
crypto	crypto: ccree - Fix use after free in cc_cipher_exit()	2022-04-08 14:40:02 +02:00
dax	dax: make sure inodes are flushed before destroy cache	2022-04-08 14:40:16 +02:00
dca
devfreq
dio
dma	dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources	2022-04-27 13:53:48 +02:00
dma-buf	udmabuf: validate ubuf->pagecount	2022-04-08 14:40:12 +02:00
edac	EDAC: Fix calculation of returned address and next offset in edac_align_ptr()	2022-02-23 12:01:07 +01:00
eisa
extcon
firewire
firmware	firmware: arm_scmi: Fix sorting of retrieved clock rates	2022-04-20 09:23:10 +02:00
fpga	fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()	2021-09-30 10:11:04 +02:00
fsi	fsi: Aspeed: Fix a potential double free	2022-04-08 14:40:23 +02:00
gnss
gpio	gpiolib: acpi: use correct format characters	2022-04-20 09:23:11 +02:00
gpu	drm/amdgpu: Enable gfxoff quirk on MacBook Pro	2022-04-20 09:23:28 +02:00
greybus	greybus: svc: fix an error handling bug in gb_svc_hello()	2022-04-08 14:39:50 +02:00
hid	HID: i2c-hid: fix GET/SET_REPORT for unnumbered reports	2022-04-08 14:40:15 +02:00
hsi	HSI: core: Fix return freed object in hsi_new_client	2022-01-27 10:54:12 +01:00
hv	Drivers: hv: vmbus: Prevent load re-ordering when reading ring buffer	2022-04-20 09:23:20 +02:00
hwmon	hwmon: (pmbus) Add Vin unit off handling	2022-04-08 14:40:02 +02:00
hwspinlock
hwtracing	amba: Make the remove callback return void	2022-04-08 14:40:02 +02:00
i2c	i2c: pasemi: Wait for write xfers to finish	2022-04-20 09:23:30 +02:00
i3c
ide
idle
iio	iio: adc: Add check for devm_request_threaded_irq	2022-04-08 14:40:25 +02:00
infiniband	scsi: iscsi: Rel ref after iscsi_lookup_endpoint()	2022-04-20 09:23:16 +02:00
input	amba: Make the remove callback return void	2022-04-08 14:40:02 +02:00
interconnect	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
iommu	iommu/omap: Fix regression in probe for NULL pointer dereference	2022-04-13 21:01:07 +02:00
ipack	ipack: ipoctal: fix module reference leak	2021-10-06 15:56:01 +02:00
irqchip	irqchip/gic, gic-v3: Prevent GSI to SGI translations	2022-04-13 21:01:11 +02:00
isdn	isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()	2022-03-16 14:15:57 +01:00
leds
lightnvm
macintosh
mailbox	mailbox: imx: fix wakeup failure from freeze mode	2022-04-08 14:40:41 +02:00
mcb	mcb: fix error handling in mcb_alloc_bus()	2021-09-30 10:11:00 +02:00
md	dm: fix mempool NULL pointer race when completing IO	2022-04-27 13:53:47 +02:00
media	media: rockchip/rga: do proper error checking in probe	2022-04-20 09:23:10 +02:00
memory	memory: renesas-rpc-if: fix platform-device leak in error path	2022-04-20 09:23:26 +02:00
memstick	memstick: jmb38x_ms: use appropriate free function in jmb38x_ms_alloc_host()	2021-11-18 14:04:07 +01:00
message
mfd	mfd: asic3: Add missing iounmap() on error asic3_mfd_probe	2022-04-08 14:40:23 +02:00
misc	kgdbts: fix return value of __setup handler	2022-04-08 14:40:28 +02:00
mmc	mmc: renesas_sdhi: don't overwrite TAP settings when HS400 tuning is complete	2022-04-13 21:01:07 +02:00
most	most: fix control-message timeouts	2021-11-18 14:03:51 +01:00
mtd	ubi: fastmap: Return error code if memory allocation fails in add_aeb()	2022-04-08 14:40:43 +02:00
mux
net	igc: Fix BUG: scheduling while atomic	2022-04-27 13:53:49 +02:00
nfc	nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION	2022-03-28 09:57:07 +02:00
ntb	ntb: intel: fix port config status offset for SPR	2022-03-08 19:09:32 +01:00
nubus
nvdimm	nvdimm/region: Fix default alignment for small regions	2022-04-08 14:40:26 +02:00
nvme	nvme-tcp: lockdep: annotate in-kernel sockets	2022-04-08 14:40:32 +02:00
nvmem	nvmem: core: set size for sysfs bin file	2022-01-27 10:54:22 +01:00
of	of: base: Improve argument length mismatch error	2022-01-27 10:54:28 +01:00
opp	opp: Fix return in _opp_add_static_v2()	2021-11-18 14:04:22 +01:00
oprofile
parisc	parisc: Fix CPU affinity for Lasi, WAX and Dino chips	2022-04-13 21:01:03 +02:00
parport
pci	PCI: endpoint: Fix misused goto label	2022-04-13 21:00:59 +02:00
pcmcia	pcmcia: fix setting of kthread task states	2022-01-27 10:54:03 +01:00
perf	perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant	2022-04-20 09:23:24 +02:00
phy	phy: amlogic: meson8b-usb2: Use dev_err_probe()	2022-04-13 21:01:01 +02:00
pinctrl	pinctrl: nuvoton: npcm7xx: Use %zu printk format for ARRAY_SIZE()	2022-04-08 14:40:41 +02:00
platform	platform/chrome: cros_ec_typec: Check for EC device	2022-04-08 14:40:42 +02:00
pnp
power	power: supply: axp288-charger: Set Vhold to 4.4V	2022-04-13 21:00:57 +02:00
powercap
pps
ps3
ptp	ptp: replace snprintf with sysfs_emit	2022-04-13 21:00:55 +02:00
pwm	pwm: lpc18xx-sct: Initialize driver data and hardware before pwmchip_add()	2022-04-08 14:40:23 +02:00
rapidio
ras
regulator	regulator: wm8994: Add an off-on delay for WM8994 variant	2022-04-20 09:23:22 +02:00
remoteproc	remoteproc: qcom_q6v5_mss: Fix some leaks in q6v5_alloc_memory_region	2022-04-08 14:40:26 +02:00
reset	reset: socfpga: add empty driver allowing consumers to probe	2021-11-18 14:03:42 +01:00
rpmsg	rpmsg: char: Fix race between the release of rpmsg_eptdev and cdev	2022-02-01 17:25:43 +01:00
rtc	rtc: wm8350: Handle error for wm8350_register_irq	2022-04-13 21:00:54 +02:00
s390	scsi: zfcp: Fix failed recovery on gone remote port with non-NPIV FCP devices	2022-02-01 17:25:39 +01:00
sbus
scsi	scsi: iscsi: Fix unbound endpoint error handling	2022-04-20 09:23:30 +02:00
sfi
sh	maple: fix wrong return value of maple_bus_init().	2021-11-26 10:39:12 +01:00
siox
slimbus
soc	soc: ti: wkup_m3_ipc: Fix IRQ check in wkup_m3_ipc_probe	2022-04-08 14:40:07 +02:00
soundwire	soundwire: intel: fix wrong register name in intel_shim_wake	2022-04-08 14:40:24 +02:00
spi	spi: spi-mtk-nor: initialize spi controller after resume	2022-04-27 13:53:48 +02:00
spmi
ssb
staging	staging: wfx: fix an error handling in wfx_init_common()	2022-04-13 21:01:01 +02:00
target	scsi: target: tcmu: Fix possible page UAF	2022-04-20 09:23:21 +02:00
tc
tee	optee: use driver internal tee_context for some rpc	2022-03-02 11:42:47 +01:00
thermal	thermal: int340x: Check for NULL after calling kmemdup()	2022-04-08 14:39:59 +02:00
thunderbolt	thunderbolt: Runtime PM activate both ends of the device link	2022-01-27 10:54:14 +01:00
tty	serial: samsung_tty: do not unlock port->lock for uart_write_wakeup()	2022-04-13 21:01:02 +02:00
uio
usb	usb: dwc3: omap: fix "unbalanced disables for smps10_out1" on omap5evm	2022-04-13 21:01:00 +02:00
vdpa	vdpa/mlx5: should verify CTRL_VQ feature exists for MQ	2022-04-08 14:39:47 +02:00
vfio	amba: Make the remove callback return void	2022-04-08 14:40:02 +02:00
vhost	tuntap: add sanity checks about msg_controllen in sendmsg	2022-04-13 21:00:59 +02:00
video	video: fbdev: sm712fb: Fix crash in smtcfb_write()	2022-04-08 14:40:36 +02:00
virt
virtio	virtio: acknowledge all features before access	2022-03-16 14:16:02 +01:00
visorbus
vlynq
vme
w1	w1: w1_therm: fixes w1_seq for ds28ea00 sensors	2022-04-13 21:01:01 +02:00
watchdog	watchdog: rti-wdt: Add missing pm_runtime_disable() in probe function	2022-04-08 14:40:41 +02:00
xen	xen/gnttab: fix gnttab_end_foreign_access() without page specified	2022-03-11 12:11:54 +01:00
zorro
Kconfig
Makefile