linux/drivers/platform
Dan Carpenter 5ba56d9bd0 platform/olpc: Fix uninitialized data in debugfs write
[ Upstream commit 40ec787e1a ]

The call to:

	size = simple_write_to_buffer(cmdbuf, sizeof(cmdbuf), ppos, buf, size);

will succeed if at least one byte is written to the "cmdbuf" buffer.
The "*ppos" value controls which byte is written.  Another problem is
that this code does not check for errors so it's possible for the entire
buffer to be uninitialized.

Inintialize the struct to zero to prevent reading uninitialized stack
data.

Debugfs is normally only writable by root so the impact of this bug is
very minimal.

Fixes: 6cca83d498 ("Platform: OLPC: move debugfs support from x86 EC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YthIKn+TfZSZMEcM@kili
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-08-21 15:16:02 +02:00
..
chrome platform/chrome: cros_ec: Always expose last resume result 2022-08-21 15:15:54 +02:00
goldfish mm, tree-wide: rename put_user_page*() to unpin_user_page*() 2020-01-31 10:30:38 -08:00
mellanox platform/mellanox: mlxreg-io: Fix read access of n-bytes size attributes 2021-10-20 11:45:05 +02:00
mips MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error. 2022-06-22 14:13:15 +02:00
olpc platform/olpc: Fix uninitialized data in debugfs write 2022-08-21 15:16:02 +02:00
x86 platform/x86: hp-wmi: Ignore Sanitization Mode event 2022-07-21 21:20:14 +02:00
Kconfig platform-drivers-x86 for v5.3-1 2019-07-14 16:51:47 -07:00
Makefile Platform: OLPC: Add XO-1.75 EC driver 2019-05-20 17:27:08 +03:00