mirror of
https://github.com/torvalds/linux.git
synced 2026-09-18 16:48:03 +02:00
9b2dedadf6
In rocket_job_run(), after taking an extra fence reference for
job->done_fence via dma_fence_get(), the error paths have three bugs:
- The dma_fence reference held by job->done_fence is never released,
causing a reference leak.
- pm_runtime_get_sync() increments the usage counter even on failure,
but the error path does not decrement it, leaking the runtime PM
reference and preventing the NPU from suspending.
- A valid but unsignaled fence is returned to the DRM scheduler,
which triggers WARN("Fence ... released with pending signals!")
when the scheduler drops its reference.
Fix by replacing pm_runtime_get_sync() with pm_runtime_resume_and_get()
which auto-balances the usage counter on failure, releasing both fence
references on error, and returning ERR_PTR(ret) instead of the
unsignaled fence.
Cc: stable@vger.kernel.org
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| rocket_core.c | ||
| rocket_core.h | ||
| rocket_device.c | ||
| rocket_device.h | ||
| rocket_drv.c | ||
| rocket_drv.h | ||
| rocket_gem.c | ||
| rocket_gem.h | ||
| rocket_job.c | ||
| rocket_job.h | ||
| rocket_registers.h | ||