Eric Dumazet 3a4f6dba1e inet_diag: fix kernel-infoleak for UDP sockets ... [ Upstream commit 71ddeac8cd ] KMSAN reported a kernel-infoleak [1], that can exploited by unpriv users. After analysis it turned out UDP was not initializing r->idiag_expires. Other users of inet_sk_diag_fill() might make the same mistake in the future, so fix this in inet_sk_diag_fill(). [1] BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:121 [inline] BUG: KMSAN: kernel-infoleak in copyout lib/iov_iter.c:156 [inline] BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670 instrument_copy_to_user include/linux/instrumented.h:121 [inline] copyout lib/iov_iter.c:156 [inline] _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670 copy_to_iter include/linux/uio.h:155 [inline] simple_copy_to_iter+0xf3/0x140 net/core/datagram.c:519 __skb_datagram_iter+0x2cb/0x1280 net/core/datagram.c:425 skb_copy_datagram_iter+0xdc/0x270 net/core/datagram.c:533 skb_copy_datagram_msg include/linux/skbuff.h:3657 [inline] netlink_recvmsg+0x660/0x1c60 net/netlink/af_netlink.c:1974 sock_recvmsg_nosec net/socket.c:944 [inline] sock_recvmsg net/socket.c:962 [inline] sock_read_iter+0x5a9/0x630 net/socket.c:1035 call_read_iter include/linux/fs.h:2156 [inline] new_sync_read fs/read_write.c:400 [inline] vfs_read+0x1631/0x1980 fs/read_write.c:481 ksys_read+0x28c/0x520 fs/read_write.c:619 __do_sys_read fs/read_write.c:629 [inline] __se_sys_read fs/read_write.c:627 [inline] __x64_sys_read+0xdb/0x120 fs/read_write.c:627 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae Uninit was created at: slab_post_alloc_hook mm/slab.h:524 [inline] slab_alloc_node mm/slub.c:3251 [inline] __kmalloc_node_track_caller+0xe0c/0x1510 mm/slub.c:4974 kmalloc_reserve net/core/skbuff.c:354 [inline] __alloc_skb+0x545/0xf90 net/core/skbuff.c:426 alloc_skb include/linux/skbuff.h:1126 [inline] netlink_dump+0x3d5/0x16a0 net/netlink/af_netlink.c:2245 __netlink_dump_start+0xd1c/0xee0 net/netlink/af_netlink.c:2370 netlink_dump_start include/linux/netlink.h:254 [inline] inet_diag_handler_cmd+0x2e7/0x400 net/ipv4/inet_diag.c:1343 sock_diag_rcv_msg+0x24a/0x620 netlink_rcv_skb+0x447/0x800 net/netlink/af_netlink.c:2491 sock_diag_rcv+0x63/0x80 net/core/sock_diag.c:276 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x1095/0x1360 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x16f3/0x1870 net/netlink/af_netlink.c:1916 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg net/socket.c:724 [inline] sock_write_iter+0x594/0x690 net/socket.c:1057 do_iter_readv_writev+0xa7f/0xc70 do_iter_write+0x52c/0x1500 fs/read_write.c:851 vfs_writev fs/read_write.c:924 [inline] do_writev+0x63f/0xe30 fs/read_write.c:967 __do_sys_writev fs/read_write.c:1040 [inline] __se_sys_writev fs/read_write.c:1037 [inline] __x64_sys_writev+0xe5/0x120 fs/read_write.c:1037 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae Bytes 68-71 of 312 are uninitialized Memory access of size 312 starts at ffff88812ab54000 Data copied to user address 0000000020001440 CPU: 1 PID: 6365 Comm: syz-executor801 Not tainted 5.16.0-rc3-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: 3c4d05c805 ("inet_diag: Introduce the inet socket dumping routine") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Link: https://lore.kernel.org/r/20211209185058.53917-1-eric.dumazet@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-12-22 09:30:53 +01:00
..
6lowpan
9p	9p/net: fix missing error check in p9_check_errors	2021-11-18 14:04:29 +01:00
802
8021q	net: vlan: fix underflow for the real_dev refcnt	2021-12-01 09:19:08 +01:00
appletalk
atm
ax25
batman-adv	net: batman-adv: fix error handling	2021-11-02 19:48:22 +01:00
bluetooth	Bluetooth: fix init and cleanup of sco_conn.timeout_work	2021-11-18 14:04:01 +01:00
bpf	bpf, test, cgroup: Use sk_{alloc,free} for test cases	2021-10-27 09:56:56 +02:00
bpfilter
bridge	net: bridge: mcast: use multicast_membership_interval for IGMPv3	2021-10-27 09:56:54 +02:00
caif
can	can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM	2021-12-08 09:03:17 +01:00
ceph
core	bpf: Fix integer overflow in argument calculation for bpf_map_area_alloc	2021-12-17 10:14:41 +01:00
dcb
dccp	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 14:04:08 +01:00
decnet
dns_resolver
dsa
ethernet
ethtool	ethtool: do not perform operations on net devices being unregistered	2021-12-17 10:14:41 +01:00
hsr
ieee802154
ife
ipv4	inet_diag: fix kernel-infoleak for UDP sockets	2021-12-22 09:30:53 +01:00
ipv6	seg6: fix the iif in the IPv6 socket control block	2021-12-14 11:32:36 +01:00
iucv
kcm
key
l2tp
l3mdev
lapb
llc
mac80211	mac80211: track only QoS data frames for admission control	2021-12-22 09:30:52 +01:00
mac802154
mpls	net: mpls: Fix notifications when deleting a device	2021-12-08 09:03:23 +01:00
mptcp	mptcp: fix delack timer	2021-12-01 09:19:04 +01:00
ncsi	net/ncsi : Add payload to be 32-bit aligned to fix dropped packets	2021-12-01 09:19:06 +01:00
netfilter	netfilter: conntrack: annotate data-races around ct->timeout	2021-12-14 11:32:37 +01:00
netlabel
netlink	net: netlink: af_netlink: Prevent empty skb by adding a check on len.	2021-12-17 10:14:40 +01:00
netrom
nfc	nfc: fix segfault in nfc_genl_dump_devices_done	2021-12-17 10:14:39 +01:00
nsh
openvswitch
packet
phonet
psample
qrtr
rds	net/rds: correct socket tunable error in rds_tcp_tune()	2021-12-08 09:03:26 +01:00
rfkill
rose
rxrpc	rxrpc: Fix rxrpc_local leak in rxrpc_lookup_peer()	2021-12-08 09:03:25 +01:00
sched	sch_cake: do not call cake_destroy() from cake_init()	2021-12-22 09:30:53 +01:00
sctp	sctp: add vtag check in sctp_sf_ootb	2021-11-02 19:48:24 +01:00
smc	net/smc: Keep smc_close_final rc during active close	2021-12-08 09:03:26 +01:00
strparser	bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding	2021-11-18 14:04:27 +01:00
sunrpc	SUNRPC: Partial revert of commit 6f9f17287e	2021-11-18 14:04:32 +01:00
switchdev
tipc	tipc: check for null after calling kmemdup	2021-11-26 10:39:19 +01:00
tls	net/tls: Fix authentication failure in CCM mode	2021-12-08 09:03:29 +01:00
unix	af_unix: fix races in sk_peer_pid and sk_peer_cred accesses	2021-10-06 15:55:58 +02:00
vmw_vsock	virtio/vsock: fix the transport to work with VMADDR_CID_ANY	2021-12-22 09:30:52 +01:00
wimax
wireless	cfg80211: call cfg80211_stop_ap when switch from P2P_GO type	2021-11-26 10:39:20 +01:00
x25
xdp
xfrm
compat.c
devres.c
Kconfig
Makefile
socket.c
sysctl_net.c