mirror of
https://github.com/torvalds/linux.git
synced 2026-06-05 13:06:59 +02:00
commit d56e5da0e0 upstream.
Feature check in validate_resctrl_feature_request() takes in the test
name string and maps that to what to check per test.
Pass resource and feature names to validate_resctrl_feature_request()
directly rather than deriving them from the test name inside the
function which makes the feature check easier to extend for new test
cases.
Use !! in the return statement to make the boolean conversion more
obvious even if it is not strictly necessary from correctness point of
view (to avoid it looking like the function is returning a freed
pointer).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Cc: <stable@vger.kernel.org> # selftests/resctrl: Remove duplicate feature check from CMT test
Cc: <stable@vger.kernel.org> # selftests/resctrl: Move _GNU_SOURCE define into Makefile
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
311 lines
7.2 KiB
C
311 lines
7.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Resctrl tests
|
|
*
|
|
* Copyright (C) 2018 Intel Corporation
|
|
*
|
|
* Authors:
|
|
* Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
|
|
* Fenghua Yu <fenghua.yu@intel.com>
|
|
*/
|
|
#include "resctrl.h"
|
|
|
|
#define BENCHMARK_ARGS 64
|
|
#define BENCHMARK_ARG_SIZE 64
|
|
|
|
static int detect_vendor(void)
|
|
{
|
|
FILE *inf = fopen("/proc/cpuinfo", "r");
|
|
int vendor_id = 0;
|
|
char *s = NULL;
|
|
char *res;
|
|
|
|
if (!inf)
|
|
return vendor_id;
|
|
|
|
res = fgrep(inf, "vendor_id");
|
|
|
|
if (res)
|
|
s = strchr(res, ':');
|
|
|
|
if (s && !strcmp(s, ": GenuineIntel\n"))
|
|
vendor_id = ARCH_INTEL;
|
|
else if (s && !strcmp(s, ": AuthenticAMD\n"))
|
|
vendor_id = ARCH_AMD;
|
|
|
|
fclose(inf);
|
|
free(res);
|
|
return vendor_id;
|
|
}
|
|
|
|
int get_vendor(void)
|
|
{
|
|
static int vendor = -1;
|
|
|
|
if (vendor == -1)
|
|
vendor = detect_vendor();
|
|
if (vendor == 0)
|
|
ksft_print_msg("Can not get vendor info...\n");
|
|
|
|
return vendor;
|
|
}
|
|
|
|
static void cmd_help(void)
|
|
{
|
|
printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
|
|
printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");
|
|
printf("\t default benchmark is builtin fill_buf\n");
|
|
printf("\t-t test list: run tests specified in the test list, ");
|
|
printf("e.g. -t mbm,mba,cmt,cat\n");
|
|
printf("\t-n no_of_bits: run cache tests using specified no of bits in cache bit mask\n");
|
|
printf("\t-p cpu_no: specify CPU number to run the test. 1 is default\n");
|
|
printf("\t-h: help\n");
|
|
}
|
|
|
|
void tests_cleanup(void)
|
|
{
|
|
mbm_test_cleanup();
|
|
mba_test_cleanup();
|
|
cmt_test_cleanup();
|
|
cat_test_cleanup();
|
|
}
|
|
|
|
static void run_mbm_test(char **benchmark_cmd, size_t span,
|
|
int cpu_no, char *bw_report)
|
|
{
|
|
int res;
|
|
|
|
ksft_print_msg("Starting MBM BW change ...\n");
|
|
|
|
res = mount_resctrlfs();
|
|
if (res) {
|
|
ksft_exit_fail_msg("Failed to mount resctrl FS\n");
|
|
return;
|
|
}
|
|
|
|
if (!validate_resctrl_feature_request("L3_MON", "mbm_total_bytes") ||
|
|
!validate_resctrl_feature_request("L3_MON", "mbm_local_bytes") ||
|
|
(get_vendor() != ARCH_INTEL)) {
|
|
ksft_test_result_skip("Hardware does not support MBM or MBM is disabled\n");
|
|
goto umount;
|
|
}
|
|
|
|
res = mbm_bw_change(span, cpu_no, bw_report, benchmark_cmd);
|
|
ksft_test_result(!res, "MBM: bw change\n");
|
|
if ((get_vendor() == ARCH_INTEL) && res)
|
|
ksft_print_msg("Intel MBM may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
|
|
|
|
umount:
|
|
umount_resctrlfs();
|
|
}
|
|
|
|
static void run_mba_test(char **benchmark_cmd, int cpu_no, char *bw_report)
|
|
{
|
|
int res;
|
|
|
|
ksft_print_msg("Starting MBA Schemata change ...\n");
|
|
|
|
res = mount_resctrlfs();
|
|
if (res) {
|
|
ksft_exit_fail_msg("Failed to mount resctrl FS\n");
|
|
return;
|
|
}
|
|
|
|
if (!validate_resctrl_feature_request("MB", NULL) || (get_vendor() != ARCH_INTEL)) {
|
|
ksft_test_result_skip("Hardware does not support MBA or MBA is disabled\n");
|
|
goto umount;
|
|
}
|
|
|
|
res = mba_schemata_change(cpu_no, bw_report, benchmark_cmd);
|
|
ksft_test_result(!res, "MBA: schemata change\n");
|
|
|
|
umount:
|
|
umount_resctrlfs();
|
|
}
|
|
|
|
static void run_cmt_test(char **benchmark_cmd, int cpu_no)
|
|
{
|
|
int res;
|
|
|
|
ksft_print_msg("Starting CMT test ...\n");
|
|
|
|
res = mount_resctrlfs();
|
|
if (res) {
|
|
ksft_exit_fail_msg("Failed to mount resctrl FS\n");
|
|
return;
|
|
}
|
|
|
|
if (!validate_resctrl_feature_request("L3_MON", "llc_occupancy")) {
|
|
ksft_test_result_skip("Hardware does not support CMT or CMT is disabled\n");
|
|
goto umount;
|
|
}
|
|
|
|
res = cmt_resctrl_val(cpu_no, 5, benchmark_cmd);
|
|
ksft_test_result(!res, "CMT: test\n");
|
|
if ((get_vendor() == ARCH_INTEL) && res)
|
|
ksft_print_msg("Intel CMT may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
|
|
|
|
umount:
|
|
umount_resctrlfs();
|
|
}
|
|
|
|
static void run_cat_test(int cpu_no, int no_of_bits)
|
|
{
|
|
int res;
|
|
|
|
ksft_print_msg("Starting CAT test ...\n");
|
|
|
|
res = mount_resctrlfs();
|
|
if (res) {
|
|
ksft_exit_fail_msg("Failed to mount resctrl FS\n");
|
|
return;
|
|
}
|
|
|
|
if (!validate_resctrl_feature_request("L3", NULL)) {
|
|
ksft_test_result_skip("Hardware does not support CAT or CAT is disabled\n");
|
|
goto umount;
|
|
}
|
|
|
|
res = cat_perf_miss_val(cpu_no, no_of_bits, "L3");
|
|
ksft_test_result(!res, "CAT: test\n");
|
|
|
|
umount:
|
|
umount_resctrlfs();
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
bool has_ben = false, mbm_test = true, mba_test = true, cmt_test = true;
|
|
char *benchmark_cmd[BENCHMARK_ARGS], bw_report[64], bm_type[64];
|
|
char benchmark_cmd_area[BENCHMARK_ARGS][BENCHMARK_ARG_SIZE];
|
|
int c, cpu_no = 1, argc_new = argc, i, no_of_bits = 0;
|
|
int ben_ind, ben_count, tests = 0;
|
|
size_t span = 250 * MB;
|
|
bool cat_test = true;
|
|
|
|
for (i = 0; i < argc; i++) {
|
|
if (strcmp(argv[i], "-b") == 0) {
|
|
ben_ind = i + 1;
|
|
ben_count = argc - ben_ind;
|
|
argc_new = ben_ind - 1;
|
|
has_ben = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
while ((c = getopt(argc_new, argv, "ht:b:n:p:")) != -1) {
|
|
char *token;
|
|
|
|
switch (c) {
|
|
case 't':
|
|
token = strtok(optarg, ",");
|
|
|
|
mbm_test = false;
|
|
mba_test = false;
|
|
cmt_test = false;
|
|
cat_test = false;
|
|
while (token) {
|
|
if (!strncmp(token, MBM_STR, sizeof(MBM_STR))) {
|
|
mbm_test = true;
|
|
tests++;
|
|
} else if (!strncmp(token, MBA_STR, sizeof(MBA_STR))) {
|
|
mba_test = true;
|
|
tests++;
|
|
} else if (!strncmp(token, CMT_STR, sizeof(CMT_STR))) {
|
|
cmt_test = true;
|
|
tests++;
|
|
} else if (!strncmp(token, CAT_STR, sizeof(CAT_STR))) {
|
|
cat_test = true;
|
|
tests++;
|
|
} else {
|
|
printf("invalid argument\n");
|
|
|
|
return -1;
|
|
}
|
|
token = strtok(NULL, ",");
|
|
}
|
|
break;
|
|
case 'p':
|
|
cpu_no = atoi(optarg);
|
|
break;
|
|
case 'n':
|
|
no_of_bits = atoi(optarg);
|
|
if (no_of_bits <= 0) {
|
|
printf("Bail out! invalid argument for no_of_bits\n");
|
|
return -1;
|
|
}
|
|
break;
|
|
case 'h':
|
|
cmd_help();
|
|
|
|
return 0;
|
|
default:
|
|
printf("invalid argument\n");
|
|
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
ksft_print_header();
|
|
|
|
/*
|
|
* Typically we need root privileges, because:
|
|
* 1. We write to resctrl FS
|
|
* 2. We execute perf commands
|
|
*/
|
|
if (geteuid() != 0)
|
|
return ksft_exit_skip("Not running as root. Skipping...\n");
|
|
|
|
if (has_ben) {
|
|
if (argc - ben_ind >= BENCHMARK_ARGS)
|
|
ksft_exit_fail_msg("Too long benchmark command.\n");
|
|
|
|
/* Extract benchmark command from command line. */
|
|
for (i = ben_ind; i < argc; i++) {
|
|
benchmark_cmd[i - ben_ind] = benchmark_cmd_area[i];
|
|
if (strlen(argv[i]) >= BENCHMARK_ARG_SIZE)
|
|
ksft_exit_fail_msg("Too long benchmark command argument.\n");
|
|
sprintf(benchmark_cmd[i - ben_ind], "%s", argv[i]);
|
|
}
|
|
benchmark_cmd[ben_count] = NULL;
|
|
} else {
|
|
/* If no benchmark is given by "-b" argument, use fill_buf. */
|
|
for (i = 0; i < 5; i++)
|
|
benchmark_cmd[i] = benchmark_cmd_area[i];
|
|
|
|
strcpy(benchmark_cmd[0], "fill_buf");
|
|
sprintf(benchmark_cmd[1], "%zu", span);
|
|
strcpy(benchmark_cmd[2], "1");
|
|
strcpy(benchmark_cmd[3], "0");
|
|
strcpy(benchmark_cmd[4], "false");
|
|
benchmark_cmd[5] = NULL;
|
|
}
|
|
|
|
sprintf(bw_report, "reads");
|
|
sprintf(bm_type, "fill_buf");
|
|
|
|
if (!check_resctrlfs_support())
|
|
return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
|
|
|
|
if (umount_resctrlfs())
|
|
return ksft_exit_skip("resctrl FS unmount failed.\n");
|
|
|
|
filter_dmesg();
|
|
|
|
ksft_set_plan(tests ? : 4);
|
|
|
|
if (mbm_test)
|
|
run_mbm_test(benchmark_cmd, span, cpu_no, bw_report);
|
|
|
|
if (mba_test)
|
|
run_mba_test(benchmark_cmd, cpu_no, bw_report);
|
|
|
|
if (cmt_test)
|
|
run_cmt_test(benchmark_cmd, cpu_no);
|
|
|
|
if (cat_test)
|
|
run_cat_test(cpu_no, no_of_bits);
|
|
|
|
ksft_finished();
|
|
}
|