Li RongQing 06f250215b timer: Read jiffies once when forwarding base clk ... commit e430d802d6 upstream. The timer delayed for more than 3 seconds warning was triggered during testing. Workqueue: events_unbound sched_tick_remote RIP: 0010:sched_tick_remote+0xee/0x100 ... Call Trace: process_one_work+0x18c/0x3a0 worker_thread+0x30/0x380 kthread+0x113/0x130 ret_from_fork+0x22/0x40 The reason is that the code in collect_expired_timers() uses jiffies unprotected: if (next_event > jiffies) base->clk = jiffies; As the compiler is allowed to reload the value base->clk can advance between the check and the store and in the worst case advance farther than next event. That causes the timer expiry to be delayed until the wheel pointer wraps around. Convert the code to use READ_ONCE() Fixes: 236968383c ("timers: Optimize collect_expired_timers() for NOHZ") Signed-off-by: Li RongQing <lirongqing@baidu.com> Signed-off-by: Liang ZhiCheng <liangzhicheng@baidu.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/1568894687-14499-1-git-send-email-lirongqing@baidu.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-10-11 18:20:59 +02:00
..
bpf	bpf: fix use after free in prog symbol exposure	2019-10-07 18:57:19 +02:00
cgroup	cgroup: Fix css_task_iter_advance_css_set() cset skip condition	2019-08-09 17:52:35 +02:00
configs
debug	kdb: Don't back trace on a cpu that didn't round up	2019-02-12 19:47:19 +01:00
dma	dma-direct: do not include SME mask in the DMA supported check	2019-01-13 09:51:05 +01:00
events	perf/core: Fix creating kernel counters for PMUs that override event->cpu	2019-08-16 10:12:50 +02:00
gcov
irq	genirq: Prevent NULL pointer dereference in resend_irqs()	2019-09-19 09:09:34 +02:00
livepatch	livepatch: Nullify obj->mod in klp_module_coming()'s error path	2019-10-07 18:57:10 +02:00
locking	locking/lockdep: Add debug_locks check in __lock_downgrade()	2019-10-01 08:26:07 +02:00
power	x86/power: Fix 'nosmt' vs hibernation triple fault during resume	2019-06-11 12:20:52 +02:00
printk	printk: Do not lose last line in kmsg buffer dump	2019-10-05 13:10:01 +02:00
rcu	rcuperf: Fix cleanup path for invalid perf_type strings	2019-05-31 06:46:30 -07:00
sched	sched/cpufreq: Align trace event behavior of fast switching	2019-10-05 13:09:51 +02:00
time	timer: Read jiffies once when forwarding base clk	2019-10-11 18:20:59 +02:00
trace	tracing: Make sure variable reference alias has correct var_ref_idx	2019-10-11 18:20:57 +02:00
.gitignore
acct.c	acct_on(): don't mess with freeze protection	2019-05-31 06:46:05 -07:00
async.c
audit_fsnotify.c
audit_tree.c
audit_watch.c
audit.c
audit.h
auditfilter.c	audit: fix a memory leak bug	2019-05-31 06:46:17 -07:00
auditsc.c
backtracetest.c
bounds.c	kbuild: fix kernel/bounds.c 'W=1' warning	2018-11-13 11:08:47 -08:00
capability.c
compat.c
configs.c
context_tracking.c
cpu_pm.c
cpu.c	cpu/hotplug: Fix out-of-bounds read when setting fail state	2019-07-21 09:03:11 +02:00
crash_core.c
crash_dump.c
cred.c	access: avoid the RCU grace period for the temporary subjective credentials	2019-07-31 07:27:11 +02:00
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c	cgroup: Call cgroup_release() before __exit_signal()	2019-08-09 17:52:34 +02:00
extable.c
fail_function.c
fork.c	sched/fair: Don't free p->numa_faults with concurrent readers	2019-08-04 09:30:56 +02:00
freezer.c
futex_compat.c
futex.c	locking/futex: Allow low-level atomic operations to return -EAGAIN	2019-05-10 17:54:11 +02:00
groups.c
hung_task.c	kernel: hung_task.c: disable on suspend	2019-04-20 09:16:02 +02:00
iomem.c
irq_work.c	irq_work: Do not raise an IPI when queueing work on the local CPU	2019-05-31 06:46:19 -07:00
jump_label.c	jump_label: move 'asm goto' support test to Kconfig	2019-06-04 08:02:34 +02:00
kallsyms.c	kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol	2019-09-21 07:17:02 +02:00
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	kernel/kcov.c: mark write_comp_data() as notrace	2019-02-12 19:47:20 +01:00
kexec_core.c	kexec: bail out upon SIGKILL when allocating memory.	2019-10-07 18:57:28 +02:00
kexec_file.c
kexec_internal.h
kexec.c
kmod.c
kprobes.c	kprobes: Prohibit probing on BUG() and WARN() address	2019-10-05 13:09:54 +02:00
ksysfs.c
kthread.c
latencytop.c
Makefile	x86/uaccess, kcov: Disable stack protector	2019-06-19 08:18:01 +02:00
memremap.c	mm, devm_memremap_pages: add MEMORY_DEVICE_PRIVATE support	2019-01-13 09:51:04 +01:00
module_signing.c
module-internal.h
module.c	modules: fix compile error if don't have strict module rwx	2019-09-19 09:09:40 +02:00
notifier.c
nsproxy.c
padata.c	padata: use smp_mb in padata_reorder to avoid orphaned padata jobs	2019-07-26 09:14:25 +02:00
panic.c	panic: avoid deadlocks in re-entrant console drivers	2018-12-29 13:37:57 +01:00
params.c
pid_namespace.c	signal/pid_namespace: Fix reboot_pid_ns to use send_sig not force_sig	2019-07-26 09:14:01 +02:00
pid.c	Fix failure path in alloc_pid()	2019-01-13 09:51:06 +01:00
profile.c
ptrace.c	ptrace: Fix ->ptracer_cred handling for PTRACE_TRACEME	2019-07-10 09:53:41 +02:00
range.c
reboot.c
relay.c	relay: check return of create_buf_file() properly	2019-03-13 14:02:35 -07:00
resource.c	resource: fix locking in find_next_iomem_res()	2019-09-16 08:22:20 +02:00
rseq.c
seccomp.c
signal.c	kernel/signal.c: trace_signal_deliver when signal_group_exit	2019-06-09 09:17:20 +02:00
smp.c	cpu/hotplug: Fix "SMT disabled by BIOS" detection for KVM	2019-02-12 19:47:25 +01:00
smpboot.c
smpboot.h
softirq.c
stacktrace.c
stop_machine.c
sys_ni.c
sys.c	kernel/sys.c: prctl: fix false positive in validate_prctl_map()	2019-06-15 11:54:01 +02:00
sysctl_binary.c
sysctl.c	sysctl: return -EINVAL if val violates minmax	2019-06-15 11:53:59 +02:00
task_work.c
taskstats.c
test_kprobes.c
torture.c
tracepoint.c
tsacct.c
ucount.c
uid16.c
uid16.h
umh.c
up.c
user_namespace.c	userns: also map extents in the reverse map to kernel IDs	2018-11-13 11:09:00 -08:00
user-return-notifier.c
user.c
utsname_sysctl.c
utsname.c
watchdog_hld.c
watchdog.c	watchdog: Respect watchdog cpumask on CPU hotplug	2019-04-03 06:26:29 +02:00
workqueue_internal.h
workqueue.c	workqueue: Try to catch flush_work() without INIT_WORK().	2019-05-02 09:58:56 +02:00