YueHaibing 7d562a90a8 at76c50x-usb: Don't register led_trigger if usb_register_driver failed ... commit 09ac2694b0 upstream. Syzkaller report this: [ 1213.468581] BUG: unable to handle kernel paging request at fffffbfff83bf338 [ 1213.469530] #PF error: [normal kernel read fault] [ 1213.469530] PGD 237fe4067 P4D 237fe4067 PUD 237e60067 PMD 1c868b067 PTE 0 [ 1213.473514] Oops: 0000 [#1] SMP KASAN PTI [ 1213.473514] CPU: 0 PID: 6321 Comm: syz-executor.0 Tainted: G C 5.1.0-rc3+ #8 [ 1213.473514] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 [ 1213.473514] RIP: 0010:strcmp+0x31/0xa0 [ 1213.473514] Code: 00 00 00 00 fc ff df 55 53 48 83 ec 08 eb 0a 84 db 48 89 ef 74 5a 4c 89 e6 48 89 f8 48 89 fa 48 8d 6f 01 48 c1 e8 03 83 e2 07 <42> 0f b6 04 28 38 d0 7f 04 84 c0 75 50 48 89 f0 48 89 f2 0f b6 5d [ 1213.473514] RSP: 0018:ffff8881f2b7f950 EFLAGS: 00010246 [ 1213.473514] RAX: 1ffffffff83bf338 RBX: ffff8881ea6f7240 RCX: ffffffff825350c6 [ 1213.473514] RDX: 0000000000000000 RSI: ffffffffc1ee19c0 RDI: ffffffffc1df99c0 [ 1213.473514] RBP: ffffffffc1df99c1 R08: 0000000000000001 R09: 0000000000000004 [ 1213.473514] R10: 0000000000000000 R11: ffff8881de353f00 R12: ffff8881ee727900 [ 1213.473514] R13: dffffc0000000000 R14: 0000000000000001 R15: ffffffffc1eeaaf0 [ 1213.473514] FS: 00007fa66fa01700(0000) GS:ffff8881f7200000(0000) knlGS:0000000000000000 [ 1213.473514] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1213.473514] CR2: fffffbfff83bf338 CR3: 00000001ebb9e005 CR4: 00000000007606f0 [ 1213.473514] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1213.473514] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1213.473514] PKRU: 55555554 [ 1213.473514] Call Trace: [ 1213.473514] led_trigger_register+0x112/0x3f0 [ 1213.473514] led_trigger_register_simple+0x7a/0x110 [ 1213.473514] ? 0xffffffffc1c10000 [ 1213.473514] at76_mod_init+0x77/0x1000 [at76c50x_usb] [ 1213.473514] do_one_initcall+0xbc/0x47d [ 1213.473514] ? perf_trace_initcall_level+0x3a0/0x3a0 [ 1213.473514] ? kasan_unpoison_shadow+0x30/0x40 [ 1213.473514] ? kasan_unpoison_shadow+0x30/0x40 [ 1213.473514] do_init_module+0x1b5/0x547 [ 1213.473514] load_module+0x6405/0x8c10 [ 1213.473514] ? module_frob_arch_sections+0x20/0x20 [ 1213.473514] ? kernel_read_file+0x1e6/0x5d0 [ 1213.473514] ? find_held_lock+0x32/0x1c0 [ 1213.473514] ? cap_capable+0x1ae/0x210 [ 1213.473514] ? __do_sys_finit_module+0x162/0x190 [ 1213.473514] __do_sys_finit_module+0x162/0x190 [ 1213.473514] ? __ia32_sys_init_module+0xa0/0xa0 [ 1213.473514] ? __mutex_unlock_slowpath+0xdc/0x690 [ 1213.473514] ? wait_for_completion+0x370/0x370 [ 1213.473514] ? vfs_write+0x204/0x4a0 [ 1213.473514] ? do_syscall_64+0x18/0x450 [ 1213.473514] do_syscall_64+0x9f/0x450 [ 1213.473514] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 1213.473514] RIP: 0033:0x462e99 [ 1213.473514] Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 [ 1213.473514] RSP: 002b:00007fa66fa00c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 1213.473514] RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99 [ 1213.473514] RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000003 [ 1213.473514] RBP: 00007fa66fa00c70 R08: 0000000000000000 R09: 0000000000000000 [ 1213.473514] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fa66fa016bc [ 1213.473514] R13: 00000000004bcefa R14: 00000000006f6fb0 R15: 0000000000000004 If usb_register failed, no need to call led_trigger_register_simple. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 1264b95146 ("at76c50x-usb: add driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-05-31 06:46:05 -07:00
..
accessibility
acpi	ACPI: PM: Set enable_for_wake for wakeup GPEs during suspend-to-idle	2019-05-22 07:37:41 +02:00
amba
android	binder: fix handling of misaligned binder object	2019-05-02 09:58:56 +02:00
ata	libata: fix using DMA buffers on stack	2019-05-04 09:20:21 +02:00
atm	atm: he: fix sign-extension overflow on large shift	2019-02-27 10:08:57 +01:00
auxdisplay	auxdisplay: hd44780: Fix memory leak on ->remove()	2019-04-20 09:15:55 +02:00
base	driver core: Postpone DMA tear-down until after devres release for probe failure	2019-05-25 18:23:47 +02:00
bcma
block	brd: re-enable __GFP_HIGHMEM in brd_insert_page()	2019-05-25 18:23:24 +02:00
bluetooth	Bluetooth: mediatek: fix up an error path to restore bdev->tx_state	2019-05-08 07:21:52 +02:00
bus
cdrom	cdrom: Fix race condition in cdrom_sysctl_register	2019-04-05 22:33:10 +02:00
char	ipmi:ssif: compare block number correctly for multi-part return messages	2019-05-22 07:37:43 +02:00
clk	clk: sunxi-ng: nkmp: Avoid GENMASK(-1, 0)	2019-05-25 18:23:42 +02:00
clocksource	clocksource/drivers/oxnas: Fix OX820 compatible	2019-05-16 19:41:21 +02:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-19 13:12:38 +01:00
cpufreq	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
cpuidle	cpuidle: big.LITTLE: fix refcount leak	2019-02-12 19:47:08 +01:00
crypto	crypto: vmx - CTR: always increment IV as quadword	2019-05-31 06:46:01 -07:00
dax	mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses	2019-05-22 07:37:40 +02:00
dca
devfreq
dio
dma	dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status	2019-05-02 09:58:55 +02:00
dma-buf
edac	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
eisa
extcon
firewire
firmware	efi: Fix debugobjects warning on 'efi_rts_work'	2019-05-08 07:21:44 +02:00
fmc
fpga	fpga: altera-cvp: fix 'bad IO access' on x86_64	2019-02-12 19:46:59 +01:00
fsi	fsi: master-ast-cf: select GENERIC_ALLOCATOR	2018-12-17 09:24:35 +01:00
gnss	gnss: sirf: fix premature wakeup interrupt enable	2019-03-10 07:17:21 +01:00
gpio	gpio: mxc: add check to return defer probe if clock tree NOT ready	2019-05-08 07:21:53 +02:00
gpu	drm/sun4i: Unbind components before releasing DRM and memory	2019-05-16 19:41:25 +02:00
hid	HID: input: add mapping for "Toggle Display" key	2019-05-16 19:41:19 +02:00
hsi
hv	Drivers: hv: vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()	2019-05-10 17:54:04 +02:00
hwmon	hwmon: (pwm-fan) Disable PWM if fetching cooling data fails	2019-05-16 19:41:18 +02:00
hwspinlock
hwtracing	intel_th: msu: Fix single mode with IOMMU	2019-05-25 18:23:26 +02:00
i2c	i2c: i2c-stm32f7: Fix SDADEL minimum formula	2019-05-08 07:21:55 +02:00
ide	ide: fix a typo in the settings proc file name	2019-01-31 08:14:42 +01:00
idle	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
iio	iio: adc: xilinx: prevent touching unclocked h/w on remove	2019-05-16 19:41:19 +02:00
infiniband	RDMA/hns: Bugfix for mapping user db	2019-05-16 19:41:25 +02:00
input	Input: synaptics-rmi4 - fix possible double free	2019-05-16 19:41:25 +02:00
iommu	iommu/tegra-smmu: Fix invalid ASID bits on Tegra30/114	2019-05-25 18:23:30 +02:00
ipack
irqchip	MIPS: perf: ath79: Fix perfcount IRQ assignment	2019-05-16 19:41:24 +02:00
isdn	isdn: bas_gigaset: use usb_fill_int_urb() properly	2019-05-16 19:41:31 +02:00
leds	leds: trigger: netdev: use memcpy in device_name_store	2019-05-04 09:20:22 +02:00
lightnvm	lightnvm: pblk: add lock protection to list operations	2019-02-12 19:47:08 +01:00
macintosh
mailbox	mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue	2019-03-23 20:09:49 +01:00
mcb
md	md/raid: raid5 preserve the writeback action after the parity check	2019-05-25 18:23:47 +02:00
media	media: vivid: use vfree() instead of kfree() for dev->bitmap_cap	2019-05-31 06:46:04 -07:00
memory	memory: tegra: Fix integer overflow on tick value calculation	2019-05-25 18:23:32 +02:00
memstick	memstick: Prevent memstick host from getting runtime suspended during card detection	2019-02-12 19:47:10 +01:00
message
mfd	mfd: twl-core: Disable IRQ while suspended	2019-05-08 07:21:48 +02:00
misc	lkdtm: Add tests for NULL pointer dereference	2019-04-20 09:16:04 +02:00
mmc	mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem	2019-05-31 06:46:01 -07:00
mtd	mtd: spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write	2019-05-22 07:37:41 +02:00
mux	mux: adgs1408: use the correct MODULE_LICENSE	2018-10-12 17:36:39 +02:00
net	at76c50x-usb: Don't register led_trigger if usb_register_driver failed	2019-05-31 06:46:05 -07:00
nfc	spi: ST ST95HF NFC: declare missing of table	2019-05-16 19:41:25 +02:00
ntb
nubus
nvdimm	libnvdimm/pmem: Bypass CONFIG_HARDENED_USERCOPY overhead	2019-05-31 06:46:01 -07:00
nvme	nvme-fc: correct csn initialization and increments on error	2019-05-10 17:54:09 +02:00
nvmem	nvmem: check the return value of nvmem_add_cells()	2018-11-13 11:08:35 -08:00
of	of: overlay: do not duplicate properties from overlay for new nodes	2019-02-06 17:30:16 +01:00
opp	OPP: Use opp_table->regulators to verify no regulator case	2019-02-12 19:47:08 +01:00
oprofile
parisc	parisc: Skip registering LED when running in QEMU	2019-05-25 18:23:23 +02:00
parport	parport_pc: fix find_superio io compare code, should use equal test.	2019-03-23 20:10:05 +01:00
pci	PCI: Fix issue with "pci=disable_acs_redir" parameter being ignored	2019-05-25 18:23:43 +02:00
pcmcia	pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges	2018-11-13 11:08:17 -08:00
perf	perf/aux: Make perf_event accessible to setup_aux()	2019-04-05 22:33:11 +02:00
phy	phy: ti-pipe3: fix missing bit-wise or operator when assigning val	2019-05-25 18:23:27 +02:00
pinctrl	pinctrl: core: make sure strcmp() doesn't get a null parameter	2019-04-20 09:16:01 +02:00
platform	platform/x86: dell-laptop: fix rfkill functionality	2019-05-16 19:41:18 +02:00
pnp
power	power: supply: sysfs: prevent endless uevent loop with CONFIG_POWER_SUPPLY_DEBUG	2019-05-25 18:23:44 +02:00
powercap	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
pps
ps3
ptp	ptp: Fix pass zero to ERR_PTR() in ptp_clock_register	2019-02-12 19:47:01 +01:00
pwm
rapidio
ras
regulator	regulator: act8865: Fix act8600_sudcdc_voltage_ranges setting	2019-04-05 22:33:15 +02:00
remoteproc	remoteproc: qcom: q6v5: Propagate EPROBE_DEFER	2018-11-13 11:08:52 -08:00
reset	reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev	2019-05-08 07:21:47 +02:00
rpmsg	rpmsg: smd: fix memory leak on channel create	2018-11-13 11:08:55 -08:00
rtc	rtc: da9063: set uie_unsupported when relevant	2019-05-08 07:21:49 +02:00
s390	s390: ctcm: fix ctcm_new_device error return code	2019-05-16 19:41:24 +02:00
sbus	drivers/sbus/char: add of_node_put()	2018-12-21 14:15:17 +01:00
scsi	Revert "scsi: sd: Keep disk read-only when re-reading partition"	2019-05-31 06:46:01 -07:00
sfi
sh
siox
slimbus	slimbus: ngd: mark PM functions as __maybe_unused	2018-12-19 19:19:49 +01:00
sn
soc	soc: sunxi: Fix missing dependency on REGMAP_MMIO	2019-05-10 17:54:10 +02:00
soundwire
spi	spi: pxa2xx: Setup maximum supported DMA transfer length	2019-03-23 20:09:57 +01:00
spmi
ssb	ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit	2019-05-31 06:46:04 -07:00
staging	media: imx: Clear fwnode link struct for each endpoint iteration	2019-05-25 18:23:28 +02:00
target	scsi: target/iscsi: Avoid iscsit_release_commands_from_conn() deadlock	2019-03-23 20:09:59 +01:00
tc	TC: Set DMA masks for devices	2018-11-13 11:08:51 -08:00
tee	tee: optee: avoid possible double list_del()	2019-02-12 19:47:08 +01:00
thermal	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
thunderbolt	thunderbolt: Prevent root port runtime suspend during NVM upgrade	2018-12-17 09:24:36 +01:00
tty	tty: Don't force RISCV SBI console as preferred console	2019-05-22 07:37:43 +02:00
uio	uio: Fix an Oops on load	2018-11-27 16:13:09 +01:00
usb	usb: typec: Fix unchecked return value	2019-05-16 19:41:26 +02:00
uwb
vfio	vfio/pci: use correct format characters	2019-05-08 07:21:49 +02:00
vhost	vhost: reject zero size iova range	2019-04-27 09:36:31 +02:00
video	fbdev: fix WARNING in __alloc_pages_nodemask bug	2019-05-31 06:46:04 -07:00
virt	drivers/virt/fsl_hypervisor.c: prevent integer overflow in ioctl	2019-05-16 19:41:31 +02:00
virtio	virtio_pci: fix a NULL pointer reference in vp_del_vqs	2019-05-10 17:54:08 +02:00
visorbus
vlynq
vme
w1	USB: w1 ds2490: Fix bug caused by improper use of altsetting array	2019-05-08 07:21:43 +02:00
watchdog	watchdog: mt7621_wdt/rt2880_wdt: Fix compilation problem	2019-02-27 10:08:52 +01:00
xen	fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock	2019-05-08 07:21:51 +02:00
zorro
Kconfig
Makefile