linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-08 06:25:52 +02:00

Linux kernel source tree

Go to file

Long Li 005be66842 xfs: abort intent items when recovery intents fail commit `f8f9d952e4` upstream. When recovering intents, we capture newly created intent items as part of committing recovered intent items. If intent recovery fails at a later point, we forget to remove those newly created intent items from the AIL and hang: [root@localhost ~]# cat /proc/539/stack [<0>] xfs_ail_push_all_sync+0x174/0x230 [<0>] xfs_unmount_flush_inodes+0x8d/0xd0 [<0>] xfs_mountfs+0x15f7/0x1e70 [<0>] xfs_fs_fill_super+0x10ec/0x1b20 [<0>] get_tree_bdev+0x3c8/0x730 [<0>] vfs_get_tree+0x89/0x2c0 [<0>] path_mount+0xecf/0x1800 [<0>] do_mount+0xf3/0x110 [<0>] __x64_sys_mount+0x154/0x1f0 [<0>] do_syscall_64+0x39/0x80 [<0>] entry_SYSCALL_64_after_hwframe+0x63/0xcd When newly created intent items fail to commit via transaction, intent recovery hasn't created done items for these newly created intent items, so the capture structure is the sole owner of the captured intent items. We must release them explicitly or else they leak: unreferenced object 0xffff888016719108 (size 432): comm "mount", pid 529, jiffies 4294706839 (age 144.463s) hex dump (first 32 bytes): 08 91 71 16 80 88 ff ff 08 91 71 16 80 88 ff ff ..q.......q..... 18 91 71 16 80 88 ff ff 18 91 71 16 80 88 ff ff ..q.......q..... backtrace: [<ffffffff8230c68f>] xfs_efi_init+0x18f/0x1d0 [<ffffffff8230c720>] xfs_extent_free_create_intent+0x50/0x150 [<ffffffff821b671a>] xfs_defer_create_intents+0x16a/0x340 [<ffffffff821bac3e>] xfs_defer_ops_capture_and_commit+0x8e/0xad0 [<ffffffff82322bb9>] xfs_cui_item_recover+0x819/0x980 [<ffffffff823289b6>] xlog_recover_process_intents+0x246/0xb70 [<ffffffff8233249a>] xlog_recover_finish+0x8a/0x9a0 [<ffffffff822eeafb>] xfs_log_mount_finish+0x2bb/0x4a0 [<ffffffff822c0f4f>] xfs_mountfs+0x14bf/0x1e70 [<ffffffff822d1f80>] xfs_fs_fill_super+0x10d0/0x1b20 [<ffffffff81a21fa2>] get_tree_bdev+0x3d2/0x6d0 [<ffffffff81a1ee09>] vfs_get_tree+0x89/0x2c0 [<ffffffff81a9f35f>] path_mount+0xecf/0x1800 [<ffffffff81a9fd83>] do_mount+0xf3/0x110 [<ffffffff81aa00e4>] __x64_sys_mount+0x154/0x1f0 [<ffffffff83968739>] do_syscall_64+0x39/0x80 Fix the problem above by abort intent items that don't have a done item when recovery intents fail. Fixes: `e6fff81e48` ("xfs: proper replay of deferred ops queued during log recovery") Signed-off-by: Long Li <leo.lilong@huawei.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com> Acked-by: Chandan Babu R <chandanbabu@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-16 19:10:45 +01:00
arch	LoongArch/smp: Call rcutree_report_cpu_starting() at tlb_init()	2024-02-05 20:14:38 +00:00
block	blk-mq: fix IO hang from sbitmap wakeup race	2024-02-05 20:14:33 +00:00
certs	certs: Reference revocation list for all keyrings	2023-08-17 20:12:41 +00:00
crypto	crypto: api - Disallow identical driver names	2024-01-31 16:18:49 -08:00
Documentation	rust: upgrade to Rust 1.73.0	2024-02-16 19:10:43 +01:00
drivers	phy: ti: phy-omap-usb2: Fix NULL pointer dereference for SRP	2024-02-16 19:10:42 +01:00
fs	xfs: abort intent items when recovery intents fail	2024-02-16 19:10:45 +01:00
include	dmaengine: fix is_slave_direction() return false when DMA_DEV_TO_DEV	2024-02-16 19:10:42 +01:00
init	rootfs: Fix support for rootfstype= when root= is given	2024-01-25 15:35:46 -08:00
io_uring	io_uring: adjust defer tw counting	2024-01-25 15:36:00 -08:00
ipc	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
kernel	perf: Fix the nr_addr_filters fix	2024-02-05 20:14:33 +00:00
lib	kunit: run test suites only after module initialization completes	2024-02-05 20:14:34 +00:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	memblock: fix crash when reserved memory is not added to memory	2024-01-31 16:19:12 -08:00
net	af_unix: fix lockdep positive in sk_diag_dump_icons()	2024-02-05 20:14:37 +00:00
rust	rust: upgrade to Rust 1.73.0	2024-02-16 19:10:43 +01:00
samples	vfio/mtty: Overhaul mtty interrupt handling	2024-01-10 17:16:55 +01:00
scripts	rust: upgrade to Rust 1.73.0	2024-02-16 19:10:43 +01:00
security	lsm: new security_file_ioctl_compat() hook	2024-01-31 16:18:54 -08:00
sound	ASoC: codecs: wsa883x: fix PA volume control	2024-02-05 20:14:39 +00:00
tools	perf evlist: Fix evlist__new_default() for > 1 core PMU	2024-02-16 19:10:42 +01:00
usr	initramfs: Encode dependency on KBUILD_BUILD_TIMESTAMP	2023-06-06 17:54:49 +09:00
virt	ARM:	2023-09-07 13:52:20 -07:00
.clang-format	iommu: Add for_each_group_device()	2023-05-23 08:15:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes	.gitattributes: set diff driver for Rust source code files	2023-05-31 17:48:25 +02:00
.gitignore	kbuild: rpm-pkg: rename binkernel.spec to kernel.spec	2023-07-25 00:59:33 +09:00
.mailmap	20 hotfixes. 12 are cc:stable and the remainder address post-6.5 issues	2023-10-24 09:52:16 -10:00
.rustfmt.toml
COPYING
CREDITS	USB: Remove Wireless USB and UWB documentation	2023-08-09 14:17:32 +02:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig
MAINTAINERS	MAINTAINERS: add Catherine as xfs maintainer for 6.6.y	2024-02-16 19:10:43 +01:00
Makefile	Linux 6.6.16	2024-02-05 20:14:39 +00:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.