mirror of
https://github.com/torvalds/linux.git
synced 2026-07-28 01:55:51 +02:00
57bb59ab6f
We always used 5 sec as the default command timeout. But soon after it was introduced, David effectively made us ignore the timeout (it was passed to process.communicate() as the wrong argument). Gal recently fixed that, but turns out the 5 sec is not enough for a lot of tests and setups. The fix caused regressions. In particular running reconfig commands (e.g. XDP attach) on mlx5 with 32 rings and 9k MTU, on a heavily-debug-enabled kernel takes more than 5 sec. The XDP installation command will time out after 5 sec but since the sleeps in the kernel are non interruptible the command finishes anyway, leaving the XDP program attached, but with non-zero exit code. defer()ed cleanups are not installed, breaking the environment for subsequent tests. Since "install XDP" is a pretty normal command a "point fix" does not seem appropriate. 32 rings is a fairly reasonable config, too, so we should just increase the timeout to 20 sec. There's no real reason behind the value of 20. Fixes: |
||
|---|---|---|
| .. | ||
| py | ||
| sh | ||
| .gitignore | ||
| csum.c | ||
| gro.c | ||
| ksft_setup_loopback.sh | ||
| ksft.h | ||
| Makefile | ||
| xdp_dummy.bpf.c | ||
| xdp_helper.c | ||
| xdp_metadata.bpf.c | ||
| xdp_native.bpf.c | ||