mirror of
https://github.com/torvalds/linux.git
synced 2026-05-24 07:03:03 +02:00
d9db9c8db5
The test constantly fails on my Intel hybrid machine. The issue was it
has two events in the output even if I only gave it one event.
$ perf stat -e instructions -- perf test -w sqrtloop
Performance counter stats for 'perf test -w sqrtloop':
910,856,421 cpu_atom/instructions/ (28.05%)
14,852,865,997 cpu_core/instructions/ (96.79%)
1.014313341 seconds time elapsed
1.004114000 seconds user
0.008174000 seconds sys
Let's modify the awk script to add the values for each line and print
the total. The variable 'i' has a number of input lines that have valid
output and variable 'c' has the sum of actual counter values. That way
it should work on any platforms.
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
87 lines
2.5 KiB
Bash
Executable File
87 lines
2.5 KiB
Bash
Executable File
#!/bin/bash
|
|
# perf stat --bpf-counters test (exclusive)
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
set -e
|
|
|
|
workload="perf test -w sqrtloop"
|
|
|
|
# check whether $2 is within +/- 20% of $1
|
|
compare_number()
|
|
{
|
|
first_num=$1
|
|
second_num=$2
|
|
|
|
# upper bound is first_num * 120%
|
|
upper=$(expr $first_num + $first_num / 5 )
|
|
# lower bound is first_num * 80%
|
|
lower=$(expr $first_num - $first_num / 5 )
|
|
|
|
if [ $second_num -gt $upper ] || [ $second_num -lt $lower ]; then
|
|
echo "The difference between $first_num and $second_num are greater than 20%."
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
check_counts()
|
|
{
|
|
base_instructions=$1
|
|
bpf_instructions=$2
|
|
|
|
if [ "$base_instructions" = "<not" ]; then
|
|
echo "Skipping: instructions event not counted"
|
|
exit 2
|
|
fi
|
|
if [ "$bpf_instructions" = "<not" ]; then
|
|
echo "Failed: instructions not counted with --bpf-counters"
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
test_bpf_counters()
|
|
{
|
|
printf "Testing --bpf-counters "
|
|
base_instructions=$(perf stat --no-big-num -e instructions -- $workload 2>&1 | \
|
|
awk -v i=0 -v c=0 '/instructions/ { \
|
|
if ($1 != "<not") { i++; c += $1 } \
|
|
} END { if (i > 0) printf "%.0f", c; else print "<not" }')
|
|
bpf_instructions=$(perf stat --no-big-num --bpf-counters -e instructions -- $workload 2>&1 | \
|
|
awk -v i=0 -v c=0 '/instructions/ { \
|
|
if ($1 != "<not") { i++; c += $1 } \
|
|
} END { if (i > 0) printf "%.0f", c; else print "<not" }')
|
|
check_counts $base_instructions $bpf_instructions
|
|
compare_number $base_instructions $bpf_instructions
|
|
echo "[Success]"
|
|
}
|
|
|
|
test_bpf_modifier()
|
|
{
|
|
printf "Testing bpf event modifier "
|
|
stat_output=$(perf stat --no-big-num -e instructions/name=base_instructions/,instructions/name=bpf_instructions/b -- $workload 2>&1)
|
|
base_instructions=$(echo "$stat_output"| \
|
|
awk -v i=0 -v c=0 '/base_instructions/ { \
|
|
if ($1 != "<not") { i++; c += $1 } \
|
|
} END { if (i > 0) printf "%.0f", c; else print "<not" }')
|
|
bpf_instructions=$(echo "$stat_output"| \
|
|
awk -v i=0 -v c=0 '/bpf_instructions/ { \
|
|
if ($1 != "<not") { i++; c += $1 } \
|
|
} END { if (i > 0) printf "%.0f", c; else print "<not" }')
|
|
check_counts $base_instructions $bpf_instructions
|
|
compare_number $base_instructions $bpf_instructions
|
|
echo "[Success]"
|
|
}
|
|
|
|
# skip if --bpf-counters is not supported
|
|
if ! perf stat -e instructions --bpf-counters true > /dev/null 2>&1; then
|
|
if [ "$1" = "-v" ]; then
|
|
echo "Skipping: --bpf-counters not supported"
|
|
perf --no-pager stat -e instructions --bpf-counters true || true
|
|
fi
|
|
exit 2
|
|
fi
|
|
|
|
test_bpf_counters
|
|
test_bpf_modifier
|
|
|
|
exit 0
|