mirror of
https://github.com/torvalds/linux.git
synced 2026-05-29 17:43:52 +02:00
dad701bdb7
kconfiglint reports two warnings for sound/soc/tegra/Makefile:
M002: composite module 'snd-soc-tegra-utils' defined but not in any obj-*
M008: composite module 'snd-soc-tegra-utils': tegra_asoc_utils.o has no
source file
The composite module definition
`snd-soc-tegra-utils-y += tegra_asoc_utils.o` references a source file that
no longer exists and defines a module that is never included in any obj-*
target.
The tegra_asoc_utils module was originally introduced in commit
a3cd50deef ("ASoC: Tegra: Move utilities to separate module") by Stephen
Warren in 2011 to provide shared clock/rate utility functions for Tegra
machine drivers. At that time, the Makefile had both the composite
definition (`snd-soc-tegra-utils-objs`) and the build target
(`obj-$(CONFIG_SND_TEGRA_SOC) += snd-soc-tegra-utils.o`).
In 2021,
commit 8c1b3b1593 ("ASoC: tegra: Squash utils into common machine
driver")
by Dmitry Osipenko merged tegra_asoc_utils.c into tegra_asoc_machine.c,
deleting both the .c and .h files. That commit correctly removed the obj-*
build target line but overlooked the composite module definition line
(`snd-soc-tegra-utils-objs += tegra_asoc_utils.o`).
The orphaned line persisted unnoticed and was even mechanically updated in
2024 by
commit 51a50d6ad7 ("ASoC: tegra: Use *-y instead of *-objs in
Makefile")
by Takashi Iwai, which converted it from `-objs` to `-y` syntax as part of
a treewide cleanup — inadvertently refreshing a stale definition.
Remove the orphaned composite module definition since it serves no purpose:
the source file was deleted, the obj-* target was already removed, and the
functionality now lives in tegra_asoc_machine.c.
Assisted-by: Claude:claude-opus-4-6 kconfiglint
Signed-off-by: Sasha Levin <sashal@kernel.org>
Link: https://patch.msgid.link/20260426000249.54799-1-sashal@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
53 lines
2.5 KiB
Makefile
53 lines
2.5 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
# Tegra platform Support
|
|
snd-soc-tegra-pcm-y := tegra_pcm.o
|
|
snd-soc-tegra20-ac97-y := tegra20_ac97.o
|
|
snd-soc-tegra20-das-y := tegra20_das.o
|
|
snd-soc-tegra20-i2s-y := tegra20_i2s.o
|
|
snd-soc-tegra20-spdif-y := tegra20_spdif.o
|
|
snd-soc-tegra30-ahub-y := tegra30_ahub.o
|
|
snd-soc-tegra30-i2s-y := tegra30_i2s.o
|
|
snd-soc-tegra210-ahub-y := tegra210_ahub.o
|
|
snd-soc-tegra210-dmic-y := tegra210_dmic.o
|
|
snd-soc-tegra210-i2s-y := tegra210_i2s.o
|
|
snd-soc-tegra186-asrc-y := tegra186_asrc.o
|
|
snd-soc-tegra186-dspk-y := tegra186_dspk.o
|
|
snd-soc-tegra210-admaif-y := tegra210_admaif.o tegra_isomgr_bw.o
|
|
snd-soc-tegra210-mvc-y := tegra210_mvc.o
|
|
snd-soc-tegra210-sfc-y := tegra210_sfc.o
|
|
snd-soc-tegra210-amx-y := tegra210_amx.o
|
|
snd-soc-tegra210-adx-y := tegra210_adx.o
|
|
snd-soc-tegra210-mixer-y := tegra210_mixer.o
|
|
snd-soc-tegra210-ope-y := tegra210_ope.o tegra210_mbdrc.o tegra210_peq.o
|
|
|
|
obj-$(CONFIG_SND_SOC_TEGRA) += snd-soc-tegra-pcm.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA20_AC97) += snd-soc-tegra20-ac97.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA20_DAS) += snd-soc-tegra20-das.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA20_I2S) += snd-soc-tegra20-i2s.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA20_SPDIF) += snd-soc-tegra20-spdif.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA30_AHUB) += snd-soc-tegra30-ahub.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA30_I2S) += snd-soc-tegra30-i2s.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_DMIC) += snd-soc-tegra210-dmic.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_AHUB) += snd-soc-tegra210-ahub.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_I2S) += snd-soc-tegra210-i2s.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA186_ASRC) += snd-soc-tegra186-asrc.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA186_DSPK) += snd-soc-tegra186-dspk.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_ADMAIF) += snd-soc-tegra210-admaif.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_MVC) += snd-soc-tegra210-mvc.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_SFC) += snd-soc-tegra210-sfc.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_AMX) += snd-soc-tegra210-amx.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_ADX) += snd-soc-tegra210-adx.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_MIXER) += snd-soc-tegra210-mixer.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA210_OPE) += snd-soc-tegra210-ope.o
|
|
|
|
# Tegra machine Support
|
|
snd-soc-tegra-wm8903-y := tegra_wm8903.o
|
|
snd-soc-tegra-wm8962-y := tegra_wm8962.o
|
|
snd-soc-tegra-machine-y := tegra_asoc_machine.o
|
|
snd-soc-tegra-audio-graph-card-y := tegra_audio_graph_card.o
|
|
|
|
obj-$(CONFIG_SND_SOC_TEGRA_WM8903) += snd-soc-tegra-wm8903.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA_WM8962) += snd-soc-tegra-wm8962.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA_MACHINE_DRV) += snd-soc-tegra-machine.o
|
|
obj-$(CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD) += snd-soc-tegra-audio-graph-card.o
|