mirror of
https://github.com/torvalds/linux.git
synced 2026-05-12 16:18:45 +02:00
7995b216a7
bpf_mptcp_sock_from_subflow() only checks if sk->sk_protocol is
IPPROTO_TCP, but RAW socket can bypass it:
socket(AF_INET, SOCK_RAW, IPPROTO_TCP)
In this case, it would NOT be valid to call sk_is_mptcp() which will
assume sk is a pointer to a struct tcp_sock, and wrongly checks for:
tcp_sk(sk)->is_mptcp.
Fixes: 3bc253c2e6 ("bpf: Add bpf_skc_to_mptcp_sock_proto")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260504210610.180150-4-kuniyu@google.com
37 lines
855 B
C
37 lines
855 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Multipath TCP
|
|
*
|
|
* Copyright (c) 2020, Tessares SA.
|
|
* Copyright (c) 2022, SUSE.
|
|
*
|
|
* Author: Nicolas Rybowski <nicolas.rybowski@tessares.net>
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "MPTCP: " fmt
|
|
|
|
#include <linux/bpf.h>
|
|
#include "protocol.h"
|
|
|
|
struct mptcp_sock *bpf_mptcp_sock_from_subflow(struct sock *sk)
|
|
{
|
|
if (sk && sk_fullsock(sk) && sk_is_tcp(sk) && sk_is_mptcp(sk))
|
|
return mptcp_sk(mptcp_subflow_ctx(sk)->conn);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
BTF_SET8_START(bpf_mptcp_fmodret_ids)
|
|
BTF_ID_FLAGS(func, update_socket_protocol)
|
|
BTF_SET8_END(bpf_mptcp_fmodret_ids)
|
|
|
|
static const struct btf_kfunc_id_set bpf_mptcp_fmodret_set = {
|
|
.owner = THIS_MODULE,
|
|
.set = &bpf_mptcp_fmodret_ids,
|
|
};
|
|
|
|
static int __init bpf_mptcp_kfunc_init(void)
|
|
{
|
|
return register_btf_fmodret_id_set(&bpf_mptcp_fmodret_set);
|
|
}
|
|
late_initcall(bpf_mptcp_kfunc_init);
|