linux/net/llc
Xuanqiang Luo 2c72eb6286 llc: fix SAP refcount leak when creating incoming sockets
llc_sap_add_socket() takes a SAP reference for each socket added to a SAP,
and llc_sap_remove_socket() releases it. llc_create_incoming_sock() takes
an additional SAP reference after adding the child socket.

This extra reference was balanced by an explicit llc_sap_put() in
llc_ui_release() until commit 3100aa9d74 ("llc: fix SAP reference
counting w.r.t. socket handling") removed that put. The corresponding hold
in the accept path was left behind.

When such a child socket is removed, only the reference taken by
llc_sap_add_socket() is released. The extra reference keeps the SAP alive
after its last socket is removed. Remove the obsolete hold.

Fixes: 3100aa9d74 ("llc: fix SAP reference counting w.r.t. socket handling")
Cc: stable@vger.kernel.org
Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Link: https://patch.msgid.link/20260712130343.518797-1-xuanqiang.luo@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2026-07-17 13:17:46 +02:00
..
af_llc.c llc: fix SAP refcount leak in llc_ui_autobind() 2026-07-05 09:05:14 +02:00
Kconfig net: remove redundant 'depends on NET' 2021-01-27 17:04:12 -08:00
llc_c_ac.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_c_ev.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_c_st.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_conn.c llc: fix SAP refcount leak when creating incoming sockets 2026-07-17 13:17:46 +02:00
llc_core.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_if.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_input.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_output.c llc/snap: constify dev_addr passing 2021-10-13 09:40:46 -07:00
llc_pdu.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_proc.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_s_ac.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_s_ev.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_s_st.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_sap.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_station.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
Makefile llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
sysctl_net_llc.c net: llc: make empty have static storage duration 2026-06-18 17:52:56 -07:00